From 3b943f214c893927dcb43a9a8f1705b7cde5a614 Mon Sep 17 00:00:00 2001 From: Camotoy <20743703+Camotoy@users.noreply.github.com> Date: Thu, 13 Jan 2022 20:03:38 -0500 Subject: [PATCH] Update comments --- .../protocol/java/entity/JavaEntityEventTranslator.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/org/geysermc/geyser/translator/protocol/java/entity/JavaEntityEventTranslator.java b/core/src/main/java/org/geysermc/geyser/translator/protocol/java/entity/JavaEntityEventTranslator.java index d67ad3857..f34f7bd17 100644 --- a/core/src/main/java/org/geysermc/geyser/translator/protocol/java/entity/JavaEntityEventTranslator.java +++ b/core/src/main/java/org/geysermc/geyser/translator/protocol/java/entity/JavaEntityEventTranslator.java @@ -238,9 +238,9 @@ public class JavaEntityEventTranslator extends PacketTranslator<ClientboundEntit if (entity instanceof LivingEntity) { // Not ideal, but... // LevelEventType.PARTICLE_DEATH_SMOKE doesn't work (as of 1.18.2 Bedrock) - // EntityEventType.DEATH_SMOKE_CLOUD also plays the entity noise - // I wasn't able to figure out how the vanilla Bedrock server does it, - // but it appears to use neither of these. + // EntityEventType.DEATH_SMOKE_CLOUD also plays the entity death noise + // Bedrock sends the particles through EntityEventType.DEATH, but Java despawns the entity + // prematurely so they don't show up. Vector3f position = entity.getPosition(); float baseX = position.getX(); float baseY = position.getY(); @@ -256,7 +256,7 @@ public class JavaEntityEventTranslator extends PacketTranslator<ClientboundEntit LevelEventPacket levelEventPacket = new LevelEventPacket(); levelEventPacket.setPosition(Vector3f.from(x, y, z)); levelEventPacket.setType(LevelEventType.PARTICLE_EXPLODE); - //session.sendUpstreamPacket(levelEventPacket); + session.sendUpstreamPacket(levelEventPacket); } } break;