OpenSource/GeyserMC
OpenSource/GeyserMC
1
0
Fork 0
mirror of https://github.com/GeyserMC/Geyser.git synced 2025-02-16 18:31:57 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fixed an issue where there would be a null score in SetScorePacket

Browse source
This commit is contained in:
Tim203 2023-12-16 23:42:59 +01:00
parent 6e56666be2
commit 58ff00db96
No known key found for this signature in database
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/src/main/java/org/geysermc/geyser/scoreboard/Scoreboard.java
View file

@ -258,7 +258,12 @@ public final class Scoreboard {
for (Score score : objective.getScores().values()) { for (Score score : objective.getScores().values()) {
if (score.getUpdateType() == REMOVE) { if (score.getUpdateType() == REMOVE) {
removeScores.add(score.getCachedInfo()); ScoreInfo cachedInfo = score.getCachedInfo();
// cachedInfo can be null here when ScoreboardUpdater is being used and a score is added and
// removed before a single update cycle is performed
if (cachedInfo != null) {
removeScores.add(cachedInfo);
}
// score is pending to be removed, so we can remove it from the objective // score is pending to be removed, so we can remove it from the objective
objective.removeScore0(score.getName()); objective.removeScore0(score.getName());
break; break;