OpenSource/PaperMC
OpenSource/PaperMC
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2025-01-02 17:32:03 +01:00
Code Issues Projects Releases Packages Wiki Activity
PaperMC/paper-server/patches/sources/com/mojang/datafixers/DataFixerBuilder.java.patch

22 lines
1.3 KiB
Diff
Raw Normal View History

Cache DataFixerUpper Rewrite Rules on demand Mojang precaches every single potential rewrite rule that could ever exist on server startup. This includes rules from all the way back to versions from 6+ years ago. This is the source of why the server hogs every CPU core at 100% every start. For anyone who hard resets for updates or has force upgraded their entire world, this results in completely wasted cpu cycles. This massive CPU usage also delays server startup time. We improve this by making "min version to precache" that defaults to a future version so that no rewrite rules are precached. someone who expects to be converting a lot chunks could theoretically set -DPaper.minPrecachedDatafixVersion=<dataVersionConvertingFrom> as a startup parameter and only build from that point on. However this will likely never be needed as the server will still run the same cache logic on demand when it's actually needed. The only cost would be some delay on the FIRST chunk conversion, but paper already runs chunk conversions on another thread so this will likely never be a concern for TPS. This patch will significantly reduce CPU use on startup, reduce memory usage, and improve server startup time.
2020-09-12 23:21:38 +02:00
--- a/com/mojang/datafixers/DataFixerBuilder.java
+++ b/com/mojang/datafixers/DataFixerBuilder.java
First few files and initial rebuild
2024-12-13 16:52:45 +01:00
@@ -29,8 +_,10 @@
Cache DataFixerUpper Rewrite Rules on demand Mojang precaches every single potential rewrite rule that could ever exist on server startup. This includes rules from all the way back to versions from 6+ years ago. This is the source of why the server hogs every CPU core at 100% every start. For anyone who hard resets for updates or has force upgraded their entire world, this results in completely wasted cpu cycles. This massive CPU usage also delays server startup time. We improve this by making "min version to precache" that defaults to a future version so that no rewrite rules are precached. someone who expects to be converting a lot chunks could theoretically set -DPaper.minPrecachedDatafixVersion=<dataVersionConvertingFrom> as a startup parameter and only build from that point on. However this will likely never be needed as the server will still run the same cache logic on demand when it's actually needed. The only cost would be some delay on the FIRST chunk conversion, but paper already runs chunk conversions on another thread so this will likely never be a concern for TPS. This patch will significantly reduce CPU use on startup, reduce memory usage, and improve server startup time.
2020-09-12 23:21:38 +02:00
private final Int2ObjectSortedMap<Schema> schemas = new Int2ObjectAVLTreeMap<>();
private final List<DataFix> globalList = new ArrayList<>();
private final IntSortedSet fixerVersions = new IntAVLTreeSet();
+ private final int minDataFixPrecacheVersion; // Paper - Perf: Cache DataFixerUpper Rewrite Rules on demand
public DataFixerBuilder(final int dataVersion) {
Small diff cleanups from patch updating And remove a dumb log change in PacketEncoder
2024-12-17 16:50:59 +01:00
+ this.minDataFixPrecacheVersion = Integer.getInteger("Paper.minPrecachedDatafixVersion", dataVersion + 1) * 10; // Paper - Perf: default to precache nothing - Mojang stores versions * 10 to allow for 'sub versions'
Cache DataFixerUpper Rewrite Rules on demand Mojang precaches every single potential rewrite rule that could ever exist on server startup. This includes rules from all the way back to versions from 6+ years ago. This is the source of why the server hogs every CPU core at 100% every start. For anyone who hard resets for updates or has force upgraded their entire world, this results in completely wasted cpu cycles. This massive CPU usage also delays server startup time. We improve this by making "min version to precache" that defaults to a future version so that no rewrite rules are precached. someone who expects to be converting a lot chunks could theoretically set -DPaper.minPrecachedDatafixVersion=<dataVersionConvertingFrom> as a startup parameter and only build from that point on. However this will likely never be needed as the server will still run the same cache logic on demand when it's actually needed. The only cost would be some delay on the FIRST chunk conversion, but paper already runs chunk conversions on another thread so this will likely never be a concern for TPS. This patch will significantly reduce CPU use on startup, reduce memory usage, and improve server startup time.
2020-09-12 23:21:38 +02:00
this.dataVersion = dataVersion;
}
First few files and initial rebuild
2024-12-13 16:52:45 +01:00
@@ -88,6 +_,7 @@
Cache DataFixerUpper Rewrite Rules on demand Mojang precaches every single potential rewrite rule that could ever exist on server startup. This includes rules from all the way back to versions from 6+ years ago. This is the source of why the server hogs every CPU core at 100% every start. For anyone who hard resets for updates or has force upgraded their entire world, this results in completely wasted cpu cycles. This massive CPU usage also delays server startup time. We improve this by making "min version to precache" that defaults to a future version so that no rewrite rules are precached. someone who expects to be converting a lot chunks could theoretically set -DPaper.minPrecachedDatafixVersion=<dataVersionConvertingFrom> as a startup parameter and only build from that point on. However this will likely never be needed as the server will still run the same cache logic on demand when it's actually needed. The only cost would be some delay on the FIRST chunk conversion, but paper already runs chunk conversions on another thread so this will likely never be a concern for TPS. This patch will significantly reduce CPU use on startup, reduce memory usage, and improve server startup time.
2020-09-12 23:21:38 +02:00
final IntIterator iterator = fixerUpper.fixerVersions().iterator();
while (iterator.hasNext()) {
final int versionKey = iterator.nextInt();
+ if (versionKey < minDataFixPrecacheVersion) continue; // Paper - Perf: Cache DataFixerUpper Rewrite Rules on demand
final Schema schema = schemas.get(versionKey);
for (final String typeName : schema.types()) {
if (!requiredTypeNames.contains(typeName)) {
Reference in a new issue Copy permalink