2021-06-11 14:02:28 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Callahan <mr.callahhh@gmail.com>
|
|
|
|
Date: Wed, 8 Apr 2020 02:42:14 -0500
|
|
|
|
Subject: [PATCH] Async command map building
|
|
|
|
|
2022-08-08 13:32:17 +02:00
|
|
|
This adds a custom pool inorder to make sure that they are closed
|
|
|
|
without much though, as it doesn't matter if the client is not sent
|
|
|
|
commands if the server is restarting. Using the default async pool caused issues to arise
|
|
|
|
due to the shutdown logic generally being much later.
|
2021-06-11 14:02:28 +02:00
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/commands/Commands.java b/src/main/java/net/minecraft/commands/Commands.java
|
2024-11-29 17:07:35 +01:00
|
|
|
index 2008fd542eaf1c2fac776ae1751c227a3b6dde4b..34564f4118eab9e95176cb4ff4bc93fbe97d9b6b 100644
|
2021-06-11 14:02:28 +02:00
|
|
|
--- a/src/main/java/net/minecraft/commands/Commands.java
|
|
|
|
+++ b/src/main/java/net/minecraft/commands/Commands.java
|
2024-11-29 17:07:35 +01:00
|
|
|
@@ -455,6 +455,19 @@ public class Commands {
|
2021-06-11 14:02:28 +02:00
|
|
|
if ( org.spigotmc.SpigotConfig.tabComplete < 0 ) return; // Spigot
|
|
|
|
// CraftBukkit start
|
|
|
|
// Register Vanilla commands into builtRoot as before
|
2024-01-21 13:56:22 +01:00
|
|
|
+ // Paper start - Perf: Async command map building
|
2024-11-29 17:07:35 +01:00
|
|
|
+ COMMAND_SENDING_POOL.execute(() -> this.sendAsync(player));
|
2021-06-11 14:02:28 +02:00
|
|
|
+ }
|
|
|
|
+
|
2024-11-29 17:07:35 +01:00
|
|
|
+ public static final java.util.concurrent.ExecutorService COMMAND_SENDING_POOL = java.util.concurrent.Executors.newFixedThreadPool(2,
|
2022-08-08 13:32:17 +02:00
|
|
|
+ new com.google.common.util.concurrent.ThreadFactoryBuilder()
|
|
|
|
+ .setNameFormat("Paper Async Command Builder Thread Pool - %1$d")
|
|
|
|
+ .setUncaughtExceptionHandler(new net.minecraft.DefaultUncaughtExceptionHandlerWithName(net.minecraft.server.MinecraftServer.LOGGER))
|
2024-11-29 17:07:35 +01:00
|
|
|
+ .build()
|
2022-08-08 13:32:17 +02:00
|
|
|
+ );
|
|
|
|
+
|
2021-08-26 18:41:22 +02:00
|
|
|
+ private void sendAsync(ServerPlayer player) {
|
2024-01-21 13:56:22 +01:00
|
|
|
+ // Paper end - Perf: Async command map building
|
2021-06-11 14:02:28 +02:00
|
|
|
Map<CommandNode<CommandSourceStack>, CommandNode<SharedSuggestionProvider>> map = Maps.newIdentityHashMap(); // Use identity to prevent aliasing issues
|
|
|
|
RootCommandNode vanillaRoot = new RootCommandNode();
|
|
|
|
|
2024-11-29 17:07:35 +01:00
|
|
|
@@ -472,7 +485,14 @@ public class Commands {
|
2021-06-11 14:02:28 +02:00
|
|
|
for (CommandNode node : rootcommandnode.getChildren()) {
|
|
|
|
bukkit.add(node.getName());
|
|
|
|
}
|
2024-01-21 13:56:22 +01:00
|
|
|
+ // Paper start - Perf: Async command map building
|
2022-08-08 13:32:17 +02:00
|
|
|
+ net.minecraft.server.MinecraftServer.getServer().execute(() -> {
|
2021-08-26 18:41:22 +02:00
|
|
|
+ runSync(player, bukkit, rootcommandnode);
|
2021-06-11 14:02:28 +02:00
|
|
|
+ });
|
|
|
|
+ }
|
|
|
|
|
2021-08-26 18:41:22 +02:00
|
|
|
+ private void runSync(ServerPlayer player, Collection<String> bukkit, RootCommandNode<SharedSuggestionProvider> rootcommandnode) {
|
2024-01-21 13:56:22 +01:00
|
|
|
+ // Paper end - Perf: Async command map building
|
2021-08-26 18:41:22 +02:00
|
|
|
PlayerCommandSendEvent event = new PlayerCommandSendEvent(player.getBukkitEntity(), new LinkedHashSet<>(bukkit));
|
2021-06-11 14:02:28 +02:00
|
|
|
event.getPlayer().getServer().getPluginManager().callEvent(event);
|
|
|
|
|
2022-08-08 13:32:17 +02:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
|
2024-11-29 17:07:35 +01:00
|
|
|
index 9a9291282f7ec99be9badf8b32fab5f0ea0f1037..feb45369b41b597fd603c12f3da23759923b6a6d 100644
|
2022-08-08 13:32:17 +02:00
|
|
|
--- a/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/MinecraftServer.java
|
2024-10-31 22:30:18 +01:00
|
|
|
@@ -944,6 +944,7 @@ public abstract class MinecraftServer extends ReentrantBlockableEventLoop<TickTa
|
2022-08-08 13:32:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
MinecraftServer.LOGGER.info("Stopping server");
|
2024-01-21 13:56:22 +01:00
|
|
|
+ Commands.COMMAND_SENDING_POOL.shutdownNow(); // Paper - Perf: Async command map building; Shutdown and don't bother finishing
|
2022-08-08 13:32:17 +02:00
|
|
|
// CraftBukkit start
|
|
|
|
if (this.server != null) {
|
2024-10-27 18:11:15 +01:00
|
|
|
this.server.disablePlugins();
|