PaperMC/patches/server/0672-Fix-PlayerBucketEmptyEvent-result-itemstack.patch

45 lines
2.1 KiB
Diff
Raw Normal View History

2021-06-11 14:02:28 +02:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Jake Potrebic <jake.m.potrebic@gmail.com>
Date: Thu, 20 May 2021 22:16:37 -0700
Subject: [PATCH] Fix PlayerBucketEmptyEvent result itemstack
Fixes SPIGOT-2560: https://hub.spigotmc.org/jira/projects/SPIGOT/issues/SPIGOT-2560
diff --git a/src/main/java/net/minecraft/world/item/BucketItem.java b/src/main/java/net/minecraft/world/item/BucketItem.java
2021-11-24 23:50:33 +01:00
index 5406acd65d4e1146f3bd7340ff9a1954a5c39ddb..b5a5c56fbb66c17dd2e2d1f4d69d2b1826cd4951 100644
2021-06-11 14:02:28 +02:00
--- a/src/main/java/net/minecraft/world/item/BucketItem.java
+++ b/src/main/java/net/minecraft/world/item/BucketItem.java
2021-11-24 23:50:33 +01:00
@@ -39,6 +39,8 @@ import org.bukkit.event.player.PlayerBucketFillEvent;
2021-06-15 05:50:26 +02:00
public class BucketItem extends Item implements DispensibleContainerItem {
+ private static ItemStack itemLeftInHandAfterPlayerBucketEmptyEvent = null; // Paper
+
public final Fluid content;
public BucketItem(Fluid fluid, Item.Properties settings) {
2021-11-24 23:50:33 +01:00
@@ -120,6 +122,13 @@ public class BucketItem extends Item implements DispensibleContainerItem {
2021-06-11 14:02:28 +02:00
}
2021-06-15 05:50:26 +02:00
public static ItemStack getEmptySuccessItem(ItemStack stack, Player player) {
+ // Paper start
2021-06-11 14:02:28 +02:00
+ if (itemLeftInHandAfterPlayerBucketEmptyEvent != null) {
+ ItemStack itemInHand = itemLeftInHandAfterPlayerBucketEmptyEvent;
+ itemLeftInHandAfterPlayerBucketEmptyEvent = null;
+ return itemInHand;
+ }
2021-06-15 05:50:26 +02:00
+ // Paper end
return !player.getAbilities().instabuild ? new ItemStack(Items.BUCKET) : stack;
2021-06-11 14:02:28 +02:00
}
2021-11-24 23:50:33 +01:00
@@ -152,6 +161,9 @@ public class BucketItem extends Item implements DispensibleContainerItem {
2021-06-11 14:02:28 +02:00
((ServerPlayer) entityhuman).getBukkitEntity().updateInventory(); // SPIGOT-4541
return false;
}
+ // Paper start
+ itemLeftInHandAfterPlayerBucketEmptyEvent = event.getItemStack().equals(CraftItemStack.asNewCraftStack(net.minecraft.world.item.Items.BUCKET)) ? null : CraftItemStack.asNMSCopy(event.getItemStack());
+ // Paper end
}
// CraftBukkit end
if (!flag1) {