mirror of
https://github.com/PaperMC/Paper.git
synced 2024-11-24 08:06:41 +01:00
69 lines
4.4 KiB
Diff
69 lines
4.4 KiB
Diff
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Shane Freeder <theboyetronic@gmail.com>
|
||
|
|
Date: Sun, 11 Nov 2018 21:01:09 +0000
|
||
|
|
Subject: [PATCH] Don't allow digging into unloaded chunks
|
||
|
|
|
||
|
|
|
||
|
|
diff --git a/src/main/java/net/minecraft/server/level/PlayerInteractManager.java b/src/main/java/net/minecraft/server/level/PlayerInteractManager.java
|
||
|
|
index 14f287d30c9a141f78f6311bef02a6fc4fa17564..d86b1e528b53db809ac993aa2f1d2799d4f1a574 100644
|
||
|
|
--- a/src/main/java/net/minecraft/server/level/PlayerInteractManager.java
|
||
|
|
+++ b/src/main/java/net/minecraft/server/level/PlayerInteractManager.java
|
||
|
|
@@ -114,8 +114,8 @@ public class PlayerInteractManager {
|
||
|
|
IBlockData iblockdata;
|
||
|
|
|
||
|
|
if (this.j) {
|
||
|
|
- iblockdata = this.world.getType(this.k);
|
||
|
|
- if (iblockdata.isAir()) {
|
||
|
|
+ iblockdata = this.world.getTypeIfLoaded(this.k); // Paper
|
||
|
|
+ if (iblockdata == null || iblockdata.isAir()) { // Paper
|
||
|
|
this.j = false;
|
||
|
|
} else {
|
||
|
|
float f = this.a(iblockdata, this.k, this.l);
|
||
|
|
@@ -126,7 +126,13 @@ public class PlayerInteractManager {
|
||
|
|
}
|
||
|
|
}
|
||
|
|
} else if (this.f) {
|
||
|
|
- iblockdata = this.world.getType(this.h);
|
||
|
|
+ // Paper start - don't want to do same logic as above, return instead
|
||
|
|
+ iblockdata = this.world.getTypeIfLoaded(this.h);
|
||
|
|
+ if (iblockdata == null) {
|
||
|
|
+ this.f = false;
|
||
|
|
+ return;
|
||
|
|
+ }
|
||
|
|
+ // Paper end
|
||
|
|
if (iblockdata.isAir()) {
|
||
|
|
this.world.a(this.player.getId(), this.h, -1);
|
||
|
|
this.m = -1;
|
||
|
|
@@ -290,10 +296,12 @@ public class PlayerInteractManager {
|
||
|
|
this.player.playerConnection.sendPacket(new PacketPlayOutBlockBreak(blockposition, this.world.getType(blockposition), packetplayinblockdig_enumplayerdigtype, true, "stopped destroying"));
|
||
|
|
} else if (packetplayinblockdig_enumplayerdigtype == PacketPlayInBlockDig.EnumPlayerDigType.ABORT_DESTROY_BLOCK) {
|
||
|
|
this.f = false;
|
||
|
|
- if (!Objects.equals(this.h, blockposition)) {
|
||
|
|
+ if (!Objects.equals(this.h, blockposition) && !BlockPosition.ZERO.equals(this.h)) {
|
||
|
|
PlayerInteractManager.LOGGER.debug("Mismatch in destroy block pos: " + this.h + " " + blockposition); // CraftBukkit - SPIGOT-5457 sent by client when interact event cancelled
|
||
|
|
- this.world.a(this.player.getId(), this.h, -1);
|
||
|
|
- this.player.playerConnection.sendPacket(new PacketPlayOutBlockBreak(this.h, this.world.getType(this.h), packetplayinblockdig_enumplayerdigtype, true, "aborted mismatched destroying"));
|
||
|
|
+ IBlockData type = this.world.getTypeIfLoaded(this.h); // Paper - don't load unloaded chunks for stale records here
|
||
|
|
+ if (type != null) this.world.a(this.player.getId(), this.h, -1); // Paper
|
||
|
|
+ if (type != null) this.player.playerConnection.sendPacket(new PacketPlayOutBlockBreak(this.h, type, packetplayinblockdig_enumplayerdigtype, true, "aborted mismatched destroying")); // Paper
|
||
|
|
+ this.h = BlockPosition.ZERO; // Paper
|
||
|
|
}
|
||
|
|
|
||
|
|
this.world.a(this.player.getId(), blockposition, -1);
|
||
|
|
diff --git a/src/main/java/net/minecraft/server/network/PlayerConnection.java b/src/main/java/net/minecraft/server/network/PlayerConnection.java
|
||
|
|
index f48683ef9afe3e5d0e0e5959c698152e9086632b..6f40d9fd45b42935d6eb58981f1d7aac2b4c2454 100644
|
||
|
|
--- a/src/main/java/net/minecraft/server/network/PlayerConnection.java
|
||
|
|
+++ b/src/main/java/net/minecraft/server/network/PlayerConnection.java
|
||
|
|
@@ -1520,6 +1520,11 @@ public class PlayerConnection implements PacketListenerPlayIn {
|
||
|
|
case START_DESTROY_BLOCK:
|
||
|
|
case ABORT_DESTROY_BLOCK:
|
||
|
|
case STOP_DESTROY_BLOCK:
|
||
|
|
+ // Paper start - Don't allow digging in unloaded chunks
|
||
|
|
+ if (this.player.world.getChunkIfLoadedImmediately(blockposition.getX() >> 4, blockposition.getZ() >> 4) == null) {
|
||
|
|
+ return;
|
||
|
|
+ }
|
||
|
|
+ // Paper end - Don't allow digging in unloaded chunks
|
||
|
|
this.player.playerInteractManager.a(blockposition, packetplayinblockdig_enumplayerdigtype, packetplayinblockdig.c(), this.minecraftServer.getMaxBuildHeight());
|
||
|
|
return;
|
||
|
|
default:
|