PaperMC/Spigot-Server-Patches/0132-Fix-AIOOBE-in-inventory-handling.patch

From 11333f7c95d933a90522c37fa3579f2aee1fdaed Mon Sep 17 00:00:00 2001
From: Brokkonaut <hannos17@gmx.de>
Date: Sun, 4 Sep 2016 16:35:43 -0500
Subject: [PATCH] Fix AIOOBE in inventory handling


diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
index 1dce60f8cc..aad33272f0 100644
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
@@ -2098,7 +2098,7 @@ public class PlayerConnection implements PacketListenerPlayIn, ITickable {
                     case CLONE:
                         if (packetplayinwindowclick.d() == 2) {
                             click = ClickType.MIDDLE;
-                            if (packetplayinwindowclick.c() == -999) {
+                            if (packetplayinwindowclick.c() < 0) { // Paper - GH-404
                                 action = InventoryAction.NOTHING;
                             } else {
                                 Slot slot = this.player.activeContainer.getSlot(packetplayinwindowclick.c());
-- 
2.19.0
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 39ce5d3a SPIGOT-4399: ItemMeta.equals broken with AttributeModifiers CraftBukkit Changes: 1cf8b5dc SPIGOT-4400: Populators running on existing chunks 116cb9a1 SPIGOT-4399: Add attribute modifier equality test 5ee1c18a SPIGOT-4398: Set ASM7_EXPERIMENTAL flag 2018-09-29 01:31:59 +02:00			`From 11333f7c95d933a90522c37fa3579f2aee1fdaed Mon Sep 17 00:00:00 2001`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`From: Brokkonaut <hannos17@gmx.de>`
			`Date: Sun, 4 Sep 2016 16:35:43 -0500`
			`Subject: [PATCH] Fix AIOOBE in inventory handling`


			`diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java`
Updated Upstream (Bukkit/CraftBukkit/Spigot) Upstream has released updates that appears to apply and compile correctly. This update has been tested to ensure that World Conversion still occurs correctly. Bukkit Changes: 0812ce2c SPIGOT-4397: isChunkGenerated API CraftBukkit Changes: 4824655c SPIGOT-4398: Upgrade to ASM 6.2.1 for better Java 11 support eea43870 MC-134115: Fix issues converting tile entities 1a7f2d10 SPIGOT-4397: isChunkGenerated API 40aed54d SPIGOT-4396: Improve vehicle movement Spigot Changes: f6a273b1 Rebuild patches 2018-09-27 04:35:42 +02:00			`index 1dce60f8cc..aad33272f0 100644`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`--- a/src/main/java/net/minecraft/server/PlayerConnection.java`
			`+++ b/src/main/java/net/minecraft/server/PlayerConnection.java`
Updated Upstream (Bukkit/CraftBukkit/Spigot) Upstream has released updates that appears to apply and compile correctly. This update has been tested to ensure that World Conversion still occurs correctly. Bukkit Changes: 0812ce2c SPIGOT-4397: isChunkGenerated API CraftBukkit Changes: 4824655c SPIGOT-4398: Upgrade to ASM 6.2.1 for better Java 11 support eea43870 MC-134115: Fix issues converting tile entities 1a7f2d10 SPIGOT-4397: isChunkGenerated API 40aed54d SPIGOT-4396: Improve vehicle movement Spigot Changes: f6a273b1 Rebuild patches 2018-09-27 04:35:42 +02:00			`@@ -2098,7 +2098,7 @@ public class PlayerConnection implements PacketListenerPlayIn, ITickable {`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`case CLONE:`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`if (packetplayinwindowclick.d() == 2) {`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`click = ClickType.MIDDLE;`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`- if (packetplayinwindowclick.c() == -999) {`
			`+ if (packetplayinwindowclick.c() < 0) { // Paper - GH-404`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`action = InventoryAction.NOTHING;`
			`} else {`
NOT FINISHED! even more 1.13-pre patches! 2018-07-16 22:08:09 +02:00			`Slot slot = this.player.activeContainer.getSlot(packetplayinwindowclick.c());`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00			`--`
Updated Upstream (Bukkit/CraftBukkit/Spigot) Upstream has released updates that appears to apply and compile correctly. This update has been tested to ensure that World Conversion still occurs correctly. Bukkit Changes: 0812ce2c SPIGOT-4397: isChunkGenerated API CraftBukkit Changes: 4824655c SPIGOT-4398: Upgrade to ASM 6.2.1 for better Java 11 support eea43870 MC-134115: Fix issues converting tile entities 1a7f2d10 SPIGOT-4397: isChunkGenerated API 40aed54d SPIGOT-4396: Improve vehicle movement Spigot Changes: f6a273b1 Rebuild patches 2018-09-27 04:35:42 +02:00			`2.19.0`
Fix an AIOOBE in inventory handling Closes GH-404 2016-09-04 23:49:29 +02:00