PaperMC/Spigot-Server-Patches/0356-Fix-sounds-when-item-frames-are-modified-MC-123450.patch

34 lines
1.8 KiB
Diff
Raw Normal View History

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2019-04-27 21:05:20 +02:00
From: Phoenix616 <mail@moep.tv>
Date: Sat, 27 Apr 2019 20:00:43 +0100
Subject: [PATCH] Fix sounds when item frames are modified (MC-123450)
This also fixes the adding sound playing when the item frame direction is changed.
diff --git a/src/main/java/net/minecraft/server/EntityItemFrame.java b/src/main/java/net/minecraft/server/EntityItemFrame.java
index bb40f21d969e8166c9af365eabcc2fcb7511eef4..e20915578720f6d18955a4ddc6fb436af807acb3 100644
2019-04-27 21:05:20 +02:00
--- a/src/main/java/net/minecraft/server/EntityItemFrame.java
+++ b/src/main/java/net/minecraft/server/EntityItemFrame.java
2020-06-25 16:09:55 +02:00
@@ -247,7 +247,7 @@ public class EntityItemFrame extends EntityHanging {
2019-04-27 21:05:20 +02:00
}
2019-05-10 21:03:43 +02:00
this.getDataWatcher().set(EntityItemFrame.ITEM, itemstack);
2019-04-27 21:05:20 +02:00
- if (!itemstack.isEmpty() && playSound) { // CraftBukkit
+ if (!itemstack.isEmpty() && flag && playSound) { // CraftBukkit // Paper - only play sound when update flag is set
2020-06-25 16:09:55 +02:00
this.playSound(SoundEffects.ENTITY_ITEM_FRAME_ADD_ITEM, 1.0F, 1.0F);
2019-04-27 21:05:20 +02:00
}
diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftItemFrame.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftItemFrame.java
index 79d443abb7975a1c181dee3cd17f8aa9164ad05d..8a43416ae2a9b923e3fa2b207931cb48cdb6bbd2 100644
2019-04-27 21:05:20 +02:00
--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftItemFrame.java
+++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftItemFrame.java
2019-05-10 21:03:43 +02:00
@@ -49,7 +49,7 @@ public class CraftItemFrame extends CraftHanging implements ItemFrame {
2019-04-27 21:05:20 +02:00
old.die();
EntityItemFrame frame = new EntityItemFrame(world, position, direction);
2019-04-27 21:05:20 +02:00
- frame.setItem(item);
+ frame.setItem(item, true, false); // Paper - fix itemframe sound
world.addEntity(frame);
this.entity = frame;
}