OpenSource/PaperMC
OpenSource/PaperMC
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2024-12-29 07:48:53 +01:00
Code Issues Projects Releases Packages Wiki Activity
PaperMC/Spigot-Server-Patches/0157-Raise-string-limit-for-packet-serialization.patch

28 lines
1.3 KiB
Diff
Raw Normal View History

Optimize Hoppers - Lots of itemstack cloning removed. Only clone if the item is actually moved - Return true when a plugin cancels inventory move item event instead of false, as false causes pulls to cycle through all items. However, pushes do not exhibit the same behavior, so this is not something plugins could of been relying on. - Add option (Default on) to cooldown hoppers when they fail to move an item due to full inventory - Skip subsequent InventoryMoveItemEvents if a plugin does not use the item after first event fire for an iteration
2018-01-18 07:00:51 +01:00
From 71992d13aa8e1c501cbef940dba3c689298668d0 Mon Sep 17 00:00:00 2001
Raise string limit for packet serialization The default limit is possible to hit with 50 page books with color codes, causing clients to disconnect. Bump the limit up a hair to above currently seen sizes.
2016-09-22 05:56:41 +02:00
From: Aikar <aikar@aikar.co>
Date: Wed, 21 Sep 2016 23:54:20 -0400
Subject: [PATCH] Raise string limit for packet serialization
The default limit is possible to hit with 50 page books with color codes, causing clients to disconnect.
Bump the limit up a hair to above currently seen sizes.
diff --git a/src/main/java/net/minecraft/server/PacketDataSerializer.java b/src/main/java/net/minecraft/server/PacketDataSerializer.java
Optimize Hoppers - Lots of itemstack cloning removed. Only clone if the item is actually moved - Return true when a plugin cancels inventory move item event instead of false, as false causes pulls to cycle through all items. However, pushes do not exhibit the same behavior, so this is not something plugins could of been relying on. - Add option (Default on) to cooldown hoppers when they fail to move an item due to full inventory - Skip subsequent InventoryMoveItemEvents if a plugin does not use the item after first event fire for an iteration
2018-01-18 07:00:51 +01:00
index a8fc7e431..c1273e988 100644
Raise string limit for packet serialization The default limit is possible to hit with 50 page books with color codes, causing clients to disconnect. Bump the limit up a hair to above currently seen sizes.
2016-09-22 05:56:41 +02:00
--- a/src/main/java/net/minecraft/server/PacketDataSerializer.java
+++ b/src/main/java/net/minecraft/server/PacketDataSerializer.java
Update to MC 1.12-pre2
2017-05-14 20:05:01 +02:00
@@ -300,8 +300,8 @@ public class PacketDataSerializer extends ByteBuf {
Raise string limit for packet serialization The default limit is possible to hit with 50 page books with color codes, causing clients to disconnect. Bump the limit up a hair to above currently seen sizes.
2016-09-22 05:56:41 +02:00
public PacketDataSerializer a(String s) {
Update to MC 1.12-pre2
2017-05-14 20:05:01 +02:00
byte[] abyte = s.getBytes(StandardCharsets.UTF_8);
Raise string limit for packet serialization The default limit is possible to hit with 50 page books with color codes, causing clients to disconnect. Bump the limit up a hair to above currently seen sizes.
2016-09-22 05:56:41 +02:00
- if (abyte.length > 32767) {
Update Paper to MC 1.11
2016-11-17 03:23:38 +01:00
- throw new EncoderException("String too big (was " + abyte.length + " bytes encoded, max " + 32767 + ")");
Raise string limit for packet serialization The default limit is possible to hit with 50 page books with color codes, causing clients to disconnect. Bump the limit up a hair to above currently seen sizes.
2016-09-22 05:56:41 +02:00
+ if (abyte.length > 44767) { // Paper - raise limit a bit more as normal means can trigger this
+ throw new EncoderException("String too big (was " + s.length() + " bytes encoded, max " + 44767 + ")"); // Paper
} else {
this.d(abyte.length);
this.writeBytes(abyte);
--
Optimize Hoppers - Lots of itemstack cloning removed. Only clone if the item is actually moved - Return true when a plugin cancels inventory move item event instead of false, as false causes pulls to cycle through all items. However, pushes do not exhibit the same behavior, so this is not something plugins could of been relying on. - Add option (Default on) to cooldown hoppers when they fail to move an item due to full inventory - Skip subsequent InventoryMoveItemEvents if a plugin does not use the item after first event fire for an iteration
2018-01-18 07:00:51 +01:00
2.16.1
Raise string limit for packet serialization The default limit is possible to hit with 50 page books with color codes, causing clients to disconnect. Bump the limit up a hair to above currently seen sizes.
2016-09-22 05:56:41 +02:00
Reference in a new issue Copy permalink