PaperMC/Spigot-Server-Patches/Change-implementation-of-tile-entity-removal-list.patch

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Joseph Hirschfeld <joe@ibj.io>
Date: Thu, 3 Mar 2016 02:39:54 -0600
Subject: [PATCH] Change implementation of (tile)entity removal list

use sets for faster removal

diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
index da049cefe4..76704abda1 100644
--- a/src/main/java/net/minecraft/server/World.java
+++ b/src/main/java/net/minecraft/server/World.java
@@ -0,0 +0,0 @@ public abstract class World implements IIBlockAccess, GeneratorAccess, AutoClose
     public final List<TileEntity> tileEntityList = Lists.newArrayList();
     public final List<TileEntity> tileEntityListTick = Lists.newArrayList();
     protected final List<TileEntity> tileEntityListPending = Lists.newArrayList();
-    protected final List<TileEntity> tileEntityListUnload = Lists.newArrayList();
+    protected final java.util.Set<TileEntity> tileEntityListUnload = com.google.common.collect.Sets.newHashSet(); // Paper
     private final long b = 16777215L;
     final Thread serverThread; // CraftBukkit - package private
     private int u;
--
Change implementation of tile entity removal list 2016-02-21 04:34:29 +01:00			`From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001`
			`From: Joseph Hirschfeld <joe@ibj.io>`
Paper 1.9 2016-03-01 00:09:49 +01:00			`Date: Thu, 3 Mar 2016 02:39:54 -0600`
Change implementation of tile entity removal list 2016-02-21 04:34:29 +01:00			`Subject: [PATCH] Change implementation of (tile)entity removal list`

Numerous fixes to entity related changes While it wasn't really "broken" before, if plugins use NMS (which they really should't be) and mess with entity management themselves, and get it wrong, they could ultimately corrupt our state expectations. I've been unable to reproduce any issues locally, but these changes are the result of me analyzing the code pretty deeply and seeing about how to make it more durable to abnormal usage. Any servers seeing oddities, please run with -Ddebug.entities=true and send me any logs triggered. 2019-04-06 05:08:45 +02:00			`use sets for faster removal`
Change implementation of tile entity removal list 2016-02-21 04:34:29 +01:00
			`diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java`
Fix server deadlock when loading some chunks (#2647) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing CraftBukkit Changes: 7554e08e Add UUID support to CraftProfileBanList 3fe37460 SPIGOT-5378: Fix TileEntity fixer deadlock 12386dd4 SPIGOT-5375: Add spaces to coordinates from tile fixer 606c19e2 SPIGOT-5373: Simultaneous left+right click in creative mode does not work 13caf848 SPIGOT-5370: Fix Block#rayTrace considering other blocks. 2019-10-20 11:03:39 +02:00			`index da049cefe4..76704abda1 100644`
Change implementation of tile entity removal list 2016-02-21 04:34:29 +01:00			`--- a/src/main/java/net/minecraft/server/World.java`
			`+++ b/src/main/java/net/minecraft/server/World.java`
More work for 1.14 2019-04-26 03:24:00 +02:00			`@@ -0,0 +0,0 @@ public abstract class World implements IIBlockAccess, GeneratorAccess, AutoClose`
Re-add TileEntity removal list, fix build 2016-03-25 08:50:56 +01:00			`public final List<TileEntity> tileEntityList = Lists.newArrayList();`
Paper 1.9 2016-03-01 00:09:49 +01:00			`public final List<TileEntity> tileEntityListTick = Lists.newArrayList();`
More work for 1.14 2019-04-26 03:24:00 +02:00			`protected final List<TileEntity> tileEntityListPending = Lists.newArrayList();`
			`- protected final List<TileEntity> tileEntityListUnload = Lists.newArrayList();`
			`+ protected final java.util.Set<TileEntity> tileEntityListUnload = com.google.common.collect.Sets.newHashSet(); // Paper`
			`private final long b = 16777215L;`
Fix server deadlock when loading some chunks (#2647) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing CraftBukkit Changes: 7554e08e Add UUID support to CraftProfileBanList 3fe37460 SPIGOT-5378: Fix TileEntity fixer deadlock 12386dd4 SPIGOT-5375: Add spaces to coordinates from tile fixer 606c19e2 SPIGOT-5373: Simultaneous left+right click in creative mode does not work 13caf848 SPIGOT-5370: Fix Block#rayTrace considering other blocks. 2019-10-20 11:03:39 +02:00			`final Thread serverThread; // CraftBukkit - package private`
Update to 1.14.4 (#2333) 2019-07-20 06:01:24 +02:00			`private int u;`
Change implementation of tile entity removal list 2016-02-21 04:34:29 +01:00			`--`