2019-04-22 23:36:14 +02:00
|
|
|
From 07d5f44136276bd9b2e3faaf2454084a5fb16776 Mon Sep 17 00:00:00 2001
|
2017-01-07 22:08:16 +01:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Sat, 7 Jan 2017 16:06:44 -0500
|
|
|
|
Subject: [PATCH] Enforce Sync Chunk Unloads
|
|
|
|
|
|
|
|
Unloading Chunks async is extremely dangerous. This will force it to main
|
|
|
|
the same way we handle async chunk loads.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftWorld.java b/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
|
2019-04-22 23:36:14 +02:00
|
|
|
index 010c5fc731..6718028190 100644
|
2017-01-07 22:08:16 +01:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
|
2019-01-01 04:15:55 +01:00
|
|
|
@@ -236,6 +236,7 @@ public class CraftWorld implements World {
|
2017-01-07 22:08:16 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
private boolean unloadChunk0(int x, int z, boolean save) {
|
|
|
|
+ Boolean result = MCUtil.ensureMain("Unload Chunk", () -> { // Paper - Ensure never async
|
2018-12-17 06:18:06 +01:00
|
|
|
net.minecraft.server.Chunk chunk = world.getChunkProvider().getChunkAt(x, z, false, false);
|
2017-01-07 22:08:16 +01:00
|
|
|
if (chunk == null) {
|
|
|
|
return true;
|
2019-01-01 04:15:55 +01:00
|
|
|
@@ -243,6 +244,7 @@ public class CraftWorld implements World {
|
2017-01-07 22:08:16 +01:00
|
|
|
|
|
|
|
// If chunk had previously been queued to save, must do save to avoid loss of that data
|
2018-12-17 06:18:06 +01:00
|
|
|
return world.getChunkProvider().unloadChunk(chunk, chunk.mustSave || save);
|
2017-01-07 22:08:16 +01:00
|
|
|
+ }); return result != null ? result : false; // Paper - Ensure never async
|
|
|
|
}
|
|
|
|
|
|
|
|
public boolean regenerateChunk(int x, int z) {
|
|
|
|
--
|
2019-04-22 23:36:14 +02:00
|
|
|
2.21.0
|
2017-01-07 22:08:16 +01:00
|
|
|
|