2021-06-11 14:02:28 +02:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Aikar <aikar@aikar.co>
Date: Mon, 4 Mar 2013 23:46:10 -0500
Subject: [PATCH] Chunk Save Reattempt
We commonly have "Stream Closed" errors on chunk saving, so this code should re-try to save the chunk in the event of failure and hopefully prevent rollbacks.
diff --git a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java
2024-04-24 03:25:14 +02:00
index b24e8255ab18eb5b2e4968aa62aa3d72ef33f0eb..12b7d50f49a2184aaf220a4a50a137b217c57124 100644
2021-06-11 14:02:28 +02:00
--- a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java
+++ b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java
2024-04-24 03:25:14 +02:00
@@ -296,7 +296,7 @@ public class RegionFile implements AutoCloseable {
2021-06-11 14:02:28 +02:00
return true;
}
} catch (IOException ioexception) {
2024-01-23 14:34:17 +01:00
- com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(ioexception); // Paper - ServerExceptionEvent
+ com.destroystokyo.paper.util.SneakyThrow.sneaky(ioexception); // Paper - Chunk save reattempt; we want the upper try/catch to retry this
2021-06-11 14:02:28 +02:00
return false;
}
}
diff --git a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java
2024-06-14 13:07:50 +02:00
index 4091d4d68b58bdefb2fdac1815e351d4f7c8a523..b7d0a48f38f0d8ae586012bb4e9a9faec21103c2 100644
2021-06-11 14:02:28 +02:00
--- a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java
+++ b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java
2024-06-14 13:07:50 +02:00
@@ -134,6 +134,11 @@ public class RegionFileStorage implements AutoCloseable {
2024-01-24 13:07:40 +01:00
protected void write(ChunkPos pos, @Nullable CompoundTag nbt) throws IOException {
RegionFile regionfile = this.getRegionFile(pos, false); // CraftBukkit
+ // Paper start - Chunk save reattempt
+ int attempts = 0;
+ Exception lastException = null;
2024-01-24 14:05:59 +01:00
+ while (attempts++ < 5) { try {
2024-01-24 13:07:40 +01:00
+ // Paper end - Chunk save reattempt
2021-06-11 14:02:28 +02:00
2021-06-12 02:57:04 +02:00
if (nbt == null) {
regionfile.clear(pos);
2024-06-14 13:07:50 +02:00
@@ -158,7 +163,18 @@ public class RegionFileStorage implements AutoCloseable {
2022-09-01 18:51:59 +02:00
dataoutputstream.close();
2021-06-12 02:57:04 +02:00
}
2021-06-11 14:02:28 +02:00
}
2024-01-23 14:34:17 +01:00
+ // Paper start - Chunk save reattempt
2024-01-24 13:07:40 +01:00
+ return;
+ } catch (Exception ex) {
+ lastException = ex;
+ }
2021-06-11 14:02:28 +02:00
+ }
2022-09-01 18:51:59 +02:00
2024-01-24 13:07:40 +01:00
+ if (lastException != null) {
+ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(lastException);
+ net.minecraft.server.MinecraftServer.LOGGER.error("Failed to save chunk {}", pos, lastException);
2021-06-11 14:02:28 +02:00
+ }
2024-01-23 14:34:17 +01:00
+ // Paper end - Chunk save reattempt
2024-01-24 13:07:40 +01:00
}
public void close() throws IOException {