From 0aed7fbd5452b93961ff364508eacf5c2ad553c0 Mon Sep 17 00:00:00 2001
From: Aikar <aikar@aikar.co>
Date: Sun, 28 Jun 2020 19:12:11 -0400
Subject: [PATCH] Improve Legacy Component serialization size

Don't constantly send format: false for all formatting options when parent already
has it false

Going to PR this to Spigot, but putting it out here for now

Should help with reducing size of items with lots of colors from
legacy format.
---
 ...-Legacy-Component-serialization-size.patch | 47 +++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644 Spigot-Server-Patches/Improve-Legacy-Component-serialization-size.patch

diff --git a/Spigot-Server-Patches/Improve-Legacy-Component-serialization-size.patch b/Spigot-Server-Patches/Improve-Legacy-Component-serialization-size.patch
new file mode 100644
index 0000000000..64b78da12d
--- /dev/null
+++ b/Spigot-Server-Patches/Improve-Legacy-Component-serialization-size.patch
@@ -0,0 +1,47 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Aikar <aikar@aikar.co>
+Date: Sun, 28 Jun 2020 19:08:41 -0400
+Subject: [PATCH] Improve Legacy Component serialization size
+
+Don't constantly send format: false for all formatting options when parent already
+has it false
+
+diff --git a/src/main/java/org/bukkit/craftbukkit/util/CraftChatMessage.java b/src/main/java/org/bukkit/craftbukkit/util/CraftChatMessage.java
+index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644
+--- a/src/main/java/org/bukkit/craftbukkit/util/CraftChatMessage.java
++++ b/src/main/java/org/bukkit/craftbukkit/util/CraftChatMessage.java
+@@ -0,0 +0,0 @@ public final class CraftChatMessage {
+         // Separate pattern with no group 3, new lines are part of previous string
+         private static final Pattern INCREMENTAL_PATTERN_KEEP_NEWLINES = Pattern.compile("(" + String.valueOf(org.bukkit.ChatColor.COLOR_CHAR) + "[0-9a-fk-orx])|((?:(?:https?):\\/\\/)?(?:[-\\w_\\.]{2,}\\.[a-z]{2,4}.*?(?=[\\.\\?!,;:]?(?:[" + String.valueOf(org.bukkit.ChatColor.COLOR_CHAR) + " ]|$))))", Pattern.CASE_INSENSITIVE);
+         // ChatColor.b does not explicitly reset, its more of empty
++        private static final ChatModifier EMPTY = ChatModifier.b; // Paper - OBFHELPER
+         private static final ChatModifier RESET = ChatModifier.b.setBold(false).setItalic(false).setUnderline(false).setStrikethrough(false).setRandom(false);
+ 
+         private final List<IChatBaseComponent> list = new ArrayList<IChatBaseComponent>();
+@@ -0,0 +0,0 @@ public final class CraftChatMessage {
+                             throw new AssertionError("Unexpected message format");
+                         }
+                     } else { // Color resets formatting
+-                        modifier = RESET.setColor(format);
++                        // Paper start - improve legacy formatting
++                        ChatModifier previous = modifier;
++                        modifier = EMPTY.setColor(format);
++                        if (previous.isBold()) {
++                            modifier = modifier.setBold(false);
++                        }
++                        if (previous.isItalic()) {
++                            modifier = modifier.setItalic(false);
++                        }
++                        if (previous.isRandom()) {
++                            modifier = modifier.setRandom(false);
++                        }
++                        if (previous.isStrikethrough()) {
++                            modifier = modifier.setStrikethrough(false);
++                        }
++                        if (previous.isUnderlined()) {
++                            modifier = modifier.setUnderline(false);
++                        }
++                        // Paper end
+                     }
+                     needsAdd = true;
+                     break;