diff --git a/README.md b/README.md index 283f378144..b63c7eedde 100644 --- a/README.md +++ b/README.md @@ -66,9 +66,9 @@ will help to ensure the PR can be easily maintained over time and encourage the * There needs to be a new line at the end of every file. * Imports should be organised in a logical manner. - * Do not group packages unless already grouped. + * Do not group packages * All new imports should be within existing CraftBukkit comments if any are present. If not, make them. - * __Absolutely no wildcard imports.__ + * __Absolutely no wildcard imports outside of tests.__ * If you only use an import once, don't import it. Use the fully qualified name. Any questions about these requirements can be asked in #spigot-dev in IRC. diff --git a/src/test/java/org/bukkit/LootTablesTest.java b/src/test/java/org/bukkit/LootTablesTest.java index 8d2cbb44cc..bb44fd7aae 100644 --- a/src/test/java/org/bukkit/LootTablesTest.java +++ b/src/test/java/org/bukkit/LootTablesTest.java @@ -1,5 +1,7 @@ package org.bukkit; +import net.minecraft.server.MinecraftKey; +import org.bukkit.craftbukkit.util.CraftNamespacedKey; import org.bukkit.loot.LootTable; import org.bukkit.loot.LootTables; import org.bukkit.support.AbstractTestingBase; @@ -19,4 +21,15 @@ public class LootTablesTest extends AbstractTestingBase { Assert.assertEquals(lootTable.getKey(), table.getKey()); } } + + @Test + public void testNMS() { + for (MinecraftKey key : net.minecraft.server.LootTables.a()) { + NamespacedKey bukkitKey = CraftNamespacedKey.fromMinecraft(key); + LootTables lootTable = Registry.LOOT_TABLES.get(bukkitKey); + + Assert.assertNotNull("Unknown LootTable " + key, lootTable); + Assert.assertEquals(lootTable.getKey(), bukkitKey); + } + } }