#1324: Improve ItemFactory#enchantItem consistency

By: Miles Holder <mwholder2005@gmail.com>
This commit is contained in:
CraftBukkit/Spigot 2024-01-06 16:07:58 +11:00
parent 8cd8851498
commit 19e69bb8fc

View file

@ -489,13 +489,8 @@ public final class CraftItemFactory implements ItemFactory {
private static ItemStack enchantItem(RandomSource source, ItemStack itemStack, int level, boolean allowTreasures) {
Preconditions.checkArgument(itemStack != null, "ItemStack must not be null");
Preconditions.checkArgument(!itemStack.getType().isAir(), "ItemStack must not be air");
if (!(itemStack instanceof CraftItemStack)) {
itemStack = CraftItemStack.asCraftCopy(itemStack);
}
itemStack = CraftItemStack.asCraftCopy(itemStack);
CraftItemStack craft = (CraftItemStack) itemStack;
EnchantmentManager.enchantItem(source, craft.handle, level, allowTreasures);
return craft;
return CraftItemStack.asCraftMirror(EnchantmentManager.enchantItem(source, craft.handle, level, allowTreasures));
}
}