mirror of
https://github.com/PaperMC/Paper.git
synced 2024-11-21 22:57:01 +01:00
Fixes for new paperweight
This commit is contained in:
Kyle Wood
parent
91e3bfd050
commit
216bd81bef
9 changed files with 28 additions and 480 deletions
|
|
@ -14,103 +14,6 @@ index e431e3435737e28394d81b56568a08b3c3148b9b..c484aff2c192bf42059b5689327909e4
|
|||
# Eclipse stuff
|
||||
/.classpath
|
||||
/.project
|
||||
diff --git a/README.md b/README.md
|
||||
deleted file mode 100644
|
||||
index 31c5e1cdd15ceb0d79b293073dafc974b308d9d9..0000000000000000000000000000000000000000
|
||||
--- a/README.md
|
||||
+++ /dev/null
|
||||
@@ -1,91 +0,0 @@
|
||||
-Bukkit
|
||||
-======
|
||||
-A plugin API for [Minecraft](https://minecraft.net/) servers, currently maintained by [SpigotMC](http://www.spigotmc.org/).
|
||||
-
|
||||
-#### Index
|
||||
-* [Bug Reporting](#bug-reporting)
|
||||
-* [Compilation](#compilation)
|
||||
-* [Contributing](#contributing)
|
||||
-* [Bukkit's Goals](#bukkits-goals)
|
||||
-* [Code Requirements](#code-requirements)
|
||||
-
|
||||
-Bug Reporting
|
||||
--------------
|
||||
-The development team is very open to both bug and feature requests / suggestions. You can submit these on the [JIRA Issue Tracker](http://hub.spigotmc.org/jira/).
|
||||
-
|
||||
-Compilation
|
||||
------------
|
||||
-Bukkit is a Java program which uses [Maven 3](http://maven.apache.org/) for compilation. To compile fresh from Git, simply perform the following steps:
|
||||
-
|
||||
-* Install Maven and Git using your preferred installation methods.
|
||||
-* `git clone https://hub.spigotmc.org/stash/scm/spigot/bukkit.git`.
|
||||
-* `mvn -P development clean install`.
|
||||
-
|
||||
-Some IDEs such as [NetBeans](https://netbeans.org/) can perform these steps for you. Any Maven capable Java IDE can be used to develop with Bukkit, however the current team's personal preference is to use NetBeans.
|
||||
-
|
||||
-Contributing
|
||||
-------------
|
||||
-Contributions of all sorts are welcome. To manage community contributions, we use the pull request functionality of Stash. In to gain access to Stash and create a pull request, you will first need to perform the following steps:
|
||||
-
|
||||
-* Create an account on [JIRA](http://hub.spigotmc.org/jira/).
|
||||
-* Fill in the [SpigotMC CLA](http://www.spigotmc.org/go/cla) and wait up to 24 hours for your Stash account to be activated. Please ensure that your username and email addresses match.
|
||||
-* Log into Stash using your JIRA credentials.
|
||||
-
|
||||
-Once you have performed these steps you can create a fork, push your code changes, and then submit it for review.
|
||||
-
|
||||
-If you submit a PR involving both Bukkit and CraftBukkit, each PR should link the other.
|
||||
-
|
||||
-Although the minimum requirement for compilation & usage is Java 8, we prefer all contributions to be written in Java 7 style code unless there is a compelling reason otherwise.
|
||||
-
|
||||
-Bukkit's Goals
|
||||
---------------
|
||||
-As a rough guideline, ask yourself the following questions to determine if the proposed change fits the Bukkit project's goals. Please remember that this is only a rough guideline
|
||||
-and it may or may not reflect the definitive answer to this question.
|
||||
-Discussions about proposed changes are held in the [Spigot IRC](https://www.spigotmc.org/wiki/irc-guide/).
|
||||
-
|
||||
-* Does it expose an implementation detail of the server software, or the protocol or file formats?
|
||||
-
|
||||
- 1. If your change revolves around an implementation detail then it is not proper API design. Examples of bad API design would be along the lines of
|
||||
- a packet API or an NBT storage API.
|
||||
-* Does it result in unexpected behaviour as defined by the Vanilla specification?
|
||||
- 1. One of the goals of the Bukkit project is to be an extended Minecraft Server. Meaning if you choose to run the Bukkit server without any plugin, it should function
|
||||
- exactly as the Minecraft Server would with some rare exceptions. If your change alters the behaviour of the server in such a way that you would not have the same experience as you
|
||||
- would in Vanilla, your change does not fit with the Bukkit project's goals.
|
||||
-* Does it expose an issue or vulnerability when operating within the Vanilla environment?
|
||||
- 1. One of the goals of the Bukkit project is to be able to operate within the limitations of the Vanilla environment. If your change results in, or exposes, the ability to, for example,
|
||||
- crash the client invalid data is set, it does not fit the Bukkit project's needs.
|
||||
-
|
||||
-If you answered yes to any of these questions, chances are high your change does not fit within the Bukkit project's goals and will likely not be accepted.
|
||||
-Regardless, there are a few other important questions that need to be asked before you start working on a change:
|
||||
-* Is this change reasonably supportable and maintainable?
|
||||
- 1. *Are there tests for this change? Does this change rely on magic numbers?*
|
||||
-* Is this change reasonably future proof?
|
||||
-
|
||||
-Code Requirements
|
||||
------------------
|
||||
-* For the most part, CraftBukkit and Bukkit use the [Sun/Oracle coding standards](http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html).
|
||||
-* No tabs; use 4 spaces instead.
|
||||
- * Empty lines should contain no spaces.
|
||||
-* No trailing whitespaces.
|
||||
-* No 80 character column limit, or 'weird' mid-statement newlines unless absolutely necessary.
|
||||
- * The 80 character column limit still applies to documentation.
|
||||
-* No one-line methods.
|
||||
-* All major additions should have documentation.
|
||||
-* Try to follow test driven development where available.
|
||||
-* All code should be free of magic values. If this is not possible, it should be marked with a TODO comment indicating it should be addressed in the future.
|
||||
- * If magic values are absolutely necessary for your change, what those values represent should be documented in the code as well as an explanation in the Pull Request description on why those values are necessary.
|
||||
-* No unnecessary code changes. Look through all your changes before you submit it.
|
||||
-* Do not attempt to fix multiple problems with a single patch or pull request.
|
||||
-* Avoid moving or renaming classes.
|
||||
-* All non-private methods and constructors must have specified nullability through [annotations](https://github.com/JetBrains/java-annotations)
|
||||
-
|
||||
-Bukkit/CraftBukkit employs [JUnit 4](http://www.vogella.com/articles/JUnit/article.html) for testing. Pull Requests(PR) should attempt to integrate within that framework as appropriate.
|
||||
-Bukkit is a large project and what seems simple to a PR author at the time of writing may easily be overlooked by other authors and updates. Including unit tests with your PR
|
||||
-will help to ensure the PR can be easily maintained over time and encourage the Spigot team to pull the PR.
|
||||
-
|
||||
-* There needs to be a new line at the end of every file.
|
||||
-* Imports should be organised in a logical manner.
|
||||
- * Do not group packages
|
||||
- * __Absolutely no wildcard imports outside of tests.__
|
||||
-
|
||||
-Any questions about these requirements can be asked in #spigot-dev in IRC.
|
||||
diff --git a/build.gradle.kts b/build.gradle.kts
|
||||
new file mode 100644
|
||||
index 0000000000000000000000000000000000000000..5cf81a0fdc112223d19a20c9be597b60e8a35173
|
||||
|
|
|
|||
|
|
@ -15,355 +15,6 @@ index 67fb370cad6924895a6b27052dbd5c1767e3f0c9..3e05459f27c4c5697ae65da504d67a6a
|
|||
# Eclipse stuff
|
||||
/.classpath
|
||||
/.project
|
||||
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
|
||||
deleted file mode 100644
|
||||
index fd928f73a43f283ed379df98987600b0149eed55..0000000000000000000000000000000000000000
|
||||
--- a/CONTRIBUTING.md
|
||||
+++ /dev/null
|
||||
@@ -1,53 +0,0 @@
|
||||
-Creating a Pull Request
|
||||
------------------------
|
||||
-##### Pull Request Title Example
|
||||
-The first line in a Pull Request(PR) message is an imperative statement briefly explaining what the PR is achieving.
|
||||
-If the PR fixes a bug, or implements a new feature as requested from the [JIRA](http://hub.spigotmc.org/jira/), then it should reference that ticket.
|
||||
-This is accomplished by simply type SPIGOT-####, where #### is the ticket number. (i.e. SPIGOT-3510).
|
||||
-You can reference multiple tickets in a single commit message; for example: "SPIGOT-1, SPIGOT-2" without the quotes.
|
||||
-
|
||||
-__For Example:__
|
||||
-* SPIGOT-3510: Velocity broken for certain entities
|
||||
-* MC-111753, SPIGOT-2971: Brewing stand not reloading
|
||||
-
|
||||
-As you can see, Minecraft tickets can be referenced by including the appropriate ticket number (i.e. MC-111753).
|
||||
-Where a pull request is spread across multiple repositories, please keep the title and first line of the commit message the same for each.
|
||||
-
|
||||
-##### Pull Request Message Expectations
|
||||
-The body of a PR needs to describe how the ticket was resolved, or if there was no ticket, describe the problem itself.
|
||||
-If a PR is for both Bukkit and CraftBukkit it should include a link to the appropriate PR. [Read this to learn how to link to a PR.](https://confluence.atlassian.com/bitbucketserver053/markdown-syntax-guide-938022413.html?utm_campaign=in-app-help&utm_medium=in-app-help&utm_source=stash#Markdownsyntaxguide-Linkingtopullrequests)
|
||||
-
|
||||
-##### Submitting the Changes
|
||||
-* Push your changes to a topic branch in your fork of the repository.
|
||||
-* Submit a pull request to the relevant repository in the Spigot organization.
|
||||
- * Make sure your pull request meets our [code requirements.](README.md)
|
||||
-* If you are fixing a JIRA ticket, be sure to update the ticket with a link to the pull request.
|
||||
- * All bug fixes must be accompanied by a JIRA ticket.
|
||||
-* Ensure all changes (including in patches) have our Minimal Diff Policy in mind.
|
||||
-
|
||||
-##### Pull Request Feedback
|
||||
-Spigot has a lot of Pull Requests open. Some of these are old and no longer maintained. As a general rule, we do not delete PRs because they are old or abandoned.
|
||||
-
|
||||
-You will eventually receive feedback on your Pull Requests. If the criticism is rough, do not take it personally. We have all started out, or just made bad PRs.
|
||||
-Take the advice and use it to make yourself better. If you think someone is being malicious contact an [admin](https://www.spigotmc.org/XenStaff/#Administrator).
|
||||
-
|
||||
-Feedback goes both ways. If you believe a feature should be present then be prepared to argue your case.
|
||||
-Per our Code Requirements, formatting issues are almost always required to be fixed before a PR is accepted.
|
||||
-
|
||||
-Although we have many discussions on Stash, there are also many discussions in the #spigot-dev channel of IRC.
|
||||
-Join us there if you plan on contributing to Spigot!
|
||||
-
|
||||
-##### Tips to Get Your Pull Request Accepted
|
||||
-Making sure to follow the conventions!
|
||||
-
|
||||
-* Your change should fit with Bukkit's goals.
|
||||
-* Make sure you follow our conventions to the letter.
|
||||
-* Check for formatting errors. They may be invisible, but [we notice.](https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/pull-requests/298/diff)
|
||||
-* Provide proper JavaDocs where appropriate.
|
||||
- * JavaDocs should detail every limitation, caveat, and gotcha the code has.
|
||||
-* Provide proper accompanying documentation where appropriate.
|
||||
-* Test your code and provide adequate testing material and/or proof.
|
||||
- * For example: adding an event? Test it with a plugin and provide us with the source.
|
||||
-* Make sure you follow our conventions to the letter.
|
||||
-
|
||||
-__Note:__ The project is often on a code freeze leading up to the release of a Minecraft update in order to give the team a static code base to work with.
|
||||
diff --git a/README.md b/README.md
|
||||
deleted file mode 100644
|
||||
index b63c7eeddece8dc421ae4a0a254ed7bee9ad71c1..0000000000000000000000000000000000000000
|
||||
--- a/README.md
|
||||
+++ /dev/null
|
||||
@@ -1,284 +0,0 @@
|
||||
-CraftBukkit
|
||||
-======
|
||||
-An implementation of the [Bukkit](https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit) plugin API for [Minecraft](https://minecraft.net/) servers, currently maintained by [SpigotMC](http://www.spigotmc.org/).
|
||||
-
|
||||
-#### Index
|
||||
-
|
||||
-* [Bug Reporting](#bug-reporting)
|
||||
-* [Compilation](#compilation)
|
||||
-* [Contributing](#contributing)
|
||||
-* [Code Requirements](#code-requirements)
|
||||
- * [Applying Patches](#applying-patches)
|
||||
- * [Making Changes to Minecraft](#making-changes-to-minecraft)
|
||||
- * [Minimal Diff Policy](#minimal-diff-policy)
|
||||
- * [CraftBukkit Comments](#craftbukkit-comments)
|
||||
-* [Creating Pull Requests](#creating-pull-requests)
|
||||
-* [Useful Resources](#useful-resources)
|
||||
-
|
||||
-Bug Reporting
|
||||
--------------
|
||||
-The development team is very open to both bug and feature requests / suggestions. You can submit these on the [JIRA Issue Tracker](http://hub.spigotmc.org/jira/).
|
||||
-
|
||||
-Compilation
|
||||
------------
|
||||
-CraftBukkit is a Java program which uses [Maven 3](http://maven.apache.org/) for compilation. To compile fresh from Git, simply perform the following steps:
|
||||
-
|
||||
-* Install Git using your preferred installation methods.
|
||||
-* Download and run [BuildTools](https://www.spigotmc.org/wiki/buildtools/)
|
||||
-
|
||||
-Some IDEs such as [NetBeans](https://netbeans.org/) can perform these steps for you. Any Maven capable Java IDE can be used to develop with CraftBukkit, however the current team's personal preference is to use NetBeans.
|
||||
-
|
||||
-Contributing
|
||||
-------------
|
||||
-Contributions of all sorts are welcome. To manage community contributions, we use the pull request functionality of Stash. In to gain access to Stash and create a pull request, you will first need to perform the following steps:
|
||||
-
|
||||
-* Create an account on [JIRA](http://hub.spigotmc.org/jira/).
|
||||
-* Fill in the [SpigotMC CLA](http://www.spigotmc.org/go/cla) and wait up to 24 hours for your Stash account to be activated. Please ensure that your username and email addresses match.
|
||||
-* Log into Stash using your JIRA credentials.
|
||||
-
|
||||
-Once you have performed these steps you can create a fork, push your code changes, and then submit it for review.
|
||||
-
|
||||
-If you submit a PR involving both Bukkit and CraftBukkit, each PR should link the other.
|
||||
-
|
||||
-Although the minimum requirement for compilation & usage is Java 8, we prefer all contributions to be written in Java 7 style code unless there is a compelling reason otherwise.
|
||||
-
|
||||
-Code Requirements
|
||||
------------------
|
||||
-* For the most part, CraftBukkit and Bukkit use the [Sun/Oracle coding standards](http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html).
|
||||
-* No tabs; use 4 spaces instead.
|
||||
- * Empty lines should contain no spaces.
|
||||
-* No trailing whitespaces.
|
||||
-* No 80 character column limit, or 'weird' mid-statement newlines unless absolutely necessary.
|
||||
- * The 80 character column limit still applies to documentation.
|
||||
-* No one-line methods.
|
||||
-* All major additions should have documentation.
|
||||
-* Try to follow test driven development where available.
|
||||
-* All code should be free of magic values. If this is not possible, it should be marked with a TODO comment indicating it should be addressed in the future.
|
||||
- * If magic values are absolutely necessary for your change, what those values represent should be documented in the code as well as an explanation in the Pull Request description on why those values are necessary.
|
||||
-* No unnecessary code changes. Look through all your changes before you submit it.
|
||||
-* Do not attempt to fix multiple problems with a single patch or pull request.
|
||||
-* Do not submit your personal changes to configuration files.
|
||||
-* Avoid moving or renaming classes.
|
||||
-
|
||||
-Bukkit/CraftBukkit employs [JUnit 4](http://www.vogella.com/articles/JUnit/article.html) for testing. Pull Requests(PR) should attempt to integrate within that framework as appropriate.
|
||||
-Bukkit is a large project and what seems simple to a PR author at the time of writing may easily be overlooked by other authors and updates. Including unit tests with your PR
|
||||
-will help to ensure the PR can be easily maintained over time and encourage the Spigot team to pull the PR.
|
||||
-
|
||||
-* There needs to be a new line at the end of every file.
|
||||
-* Imports should be organised in a logical manner.
|
||||
- * Do not group packages
|
||||
- * All new imports should be within existing CraftBukkit comments if any are present. If not, make them.
|
||||
- * __Absolutely no wildcard imports outside of tests.__
|
||||
- * If you only use an import once, don't import it. Use the fully qualified name.
|
||||
-
|
||||
-Any questions about these requirements can be asked in #spigot-dev in IRC.
|
||||
-
|
||||
-Applying Patches
|
||||
-----------------
|
||||
-Any time new patches are created and/or updated in CraftBukkit, you need to apply them to your development environment.
|
||||
-
|
||||
-1. Pull changes from CraftBukkit repo.
|
||||
-2. Run the `applyPatches.sh` script in the CraftBukkit directory.
|
||||
- - This script requires a decompile directory from BuildTools. (e.g. <BuildTools Directory>/work/decompile-XXXXXX)
|
||||
-3. Your development environment is now up to date with the latest CraftBukkit patches!
|
||||
-
|
||||
-Making Changes to Minecraft
|
||||
----------------------------
|
||||
-Importing new NMS classes to CraftBukkit is actually very simple.
|
||||
-
|
||||
-1. Find the `work/decompile-XXXXXX` folder in your BuildTools folder.
|
||||
-2. Find the class you want to add in the `net/minecraft/server` folder and copy it.
|
||||
-3. Copy the selected file to the `src/main/java/net/minecraft/server` folder in CraftBukkit.
|
||||
-4. Implement changes.
|
||||
-5. Run `makePatches.sh` to create a new patch for the new class.
|
||||
- * _Be sure that Git recognizes the new file. This might require manually adding the file._
|
||||
-6. Commit new patch.
|
||||
-
|
||||
-Done! You have added a new patch for CraftBukkit!
|
||||
-
|
||||
-**Making Changes to NMS Classes**
|
||||
-
|
||||
-Bukkit/CB employs a Minimal Diff policy to help guide when changes should be changed to Minecraft and what those changes should be.
|
||||
-This is to ensure that any changes have the smallest impact possible on the update process whenever a new Minecraft version is released.
|
||||
-As well as the Minimal Diff Policy, *every* change made to a Minecraft class must be marked with the appropriate CraftBukkit comment.
|
||||
-At no point should you rename an existing/obfuscated field or method. All references to existing/obfusacted fields/methods should be marked with the `// PAIL rename` comment.
|
||||
-Mapping of new fields/methods are done when there are enough changes to warrant the work. (Any questions can be asked in #spigot-dev in [IRC](https://www.spigotmc.org/wiki/irc-guide/))
|
||||
-
|
||||
-__*Key Points*__:
|
||||
-* All additions to patches must be accompanied by an appropriate comment.
|
||||
-* To avoid large patches, avoid adding methods where possible. We prefer making fields public over adding methods in patches.
|
||||
- * If you *have* to add a method to a patch, please explain why in the Pull Request description.
|
||||
-* __Never__ rename an existing field or method. If you want something renamed, include a ```PAIL rename``` comment
|
||||
-* Converting a method/class from one access level to another (i.e. private to public) is fine as long as that method is not overridden in subclasses.
|
||||
- * If a method is overridden in its' subclasses, create a new method that calls that method instead (along with appropriate CraftBukkit comments).
|
||||
-* If you can use a field to accomplish something, use that over creating a new method.
|
||||
-
|
||||
-Minimal Diff Policy
|
||||
--------------------
|
||||
-
|
||||
-The Minimal Diff Policy is key to any changes made within Minecraft classes. When people think of the phrase "minimal diffs", they often take it
|
||||
-to the extreme - they go completely out of their way to abstract the changes they are trying to make away from editing Minecraft's classes as much as possible.
|
||||
-However, this is not what is meant by "minimal diffs". Instead, when trying to understand this policy, it helps to keep in mind its goal: to reduce the impact of changes we make
|
||||
-to Minecraft's internals have on our update process.
|
||||
-
|
||||
-To put it simply, the Minimal Diffs Policy simply means to make the smallest change in a Minecraft class possible without duplicating logic.
|
||||
-
|
||||
-Here are a few tips you should keep in mind, or common areas you should focus on:
|
||||
-
|
||||
-* Try to avoid duplicating logic or code when making changes.
|
||||
-* Try to keep your changes easily discernible - don't nest or group several unrelated changes together.
|
||||
- * All changes must be surrounded by [CraftBukkit comments](#craftbukkit-comments).
|
||||
-* If you only use an import once within a class, don't import it and use a fully qualified name instead.
|
||||
-* Try to employ "short-circuiting" of logic if at all possible. This means you should force a conditional to be the value needed to side step the code block to achieve your desired effect.
|
||||
-
|
||||
-__For example, to short circuit this:__
|
||||
-```java
|
||||
-if (!this.world.isClientSide && !this.isDead && (d0*d0) + d1 + (d2*d2) > 0.0D) {
|
||||
- this.die();
|
||||
- this.h();
|
||||
-}
|
||||
-```
|
||||
-__You would do this:__
|
||||
-```java
|
||||
-if (false && !this.world.isClientSide && !this.isDead && (d0*d0) + d1 + (d2*d2) > 0.0D) {
|
||||
- this.die();
|
||||
- this.h();
|
||||
-}
|
||||
-```
|
||||
-
|
||||
-* When adding a validation check, this applies everywhere not just in Minecraft classes, see if the Validate package has a better, more concise method you can use instead.
|
||||
- * The Preconditions package works just as well. Either are acceptable; though these are, by no means, the only accepted validation strategies.
|
||||
-
|
||||
-__For example, you should use:__
|
||||
-```java
|
||||
-Validate.notNull(sender, "Sender cannot be null");
|
||||
-```
|
||||
-__Instead of:__
|
||||
-```java
|
||||
-if (sender == null) {
|
||||
- throw new IllegalArgumentException("Sender cannot be null");
|
||||
-}
|
||||
-```
|
||||
-
|
||||
-* When the change you are trying to make involves removing code, or delegating it somewhere else, instead of removing it, you should comment it out.
|
||||
-
|
||||
-__For example:__
|
||||
-```java
|
||||
-// CraftBukkit start - special case dropping so we can get info from the tile entity
|
||||
-public void dropNaturally(World world, int i, int j, int k, int l, float f, int i1) {
|
||||
- if (world.random.nextFloat() < f) {
|
||||
- ItemStack itemstack = new ItemStack(Item.SKULL, 1, this.getDropData(world, i, j, k));
|
||||
- TileEntitySkull tileentityskull = (TileEntitySkull) world.getTileEntity(i, j, k);
|
||||
-
|
||||
- if (tileentityskull.getSkullType() == 3 && tileentityskull.getExtraType() != null && tileentityskull.getExtraType().length() > 0) {
|
||||
- itemstack.setTag(new NBTTagCompound());
|
||||
- itemstack.getTag().setString("SkullOwner", tileentityskull.getExtraType());
|
||||
- }
|
||||
-
|
||||
- this.b(world, i, j, k, itemstack);
|
||||
- }
|
||||
-}
|
||||
-// CraftBukkit end
|
||||
-
|
||||
-public void remove(World world, int i, int j, int k, int l, int i1) {
|
||||
- if (!world.isStatic) {
|
||||
- /* CraftBukkit start - drop item in code above, not here
|
||||
- if ((i1 & 8) == 0) {
|
||||
- ItemStack itemstack = new ItemStack(Item.SKULL, 1, this.getDropData(world, i, j, k));
|
||||
- TileEntitySkull tileentityskull = (TileEntitySkull) world.getTileEntity(i, j, k);
|
||||
-
|
||||
- if (tileentityskull.getSkullType() == 3 && tileentityskull.getExtraType() != null && tileentityskull.getExtraType().length() > 0) {
|
||||
- itemstack.setTag(new NBTTagCompound());
|
||||
- itemstack.getTag().setString("SkullOwner", tileentityskull.getExtraType());
|
||||
- }
|
||||
-
|
||||
- this.b(world, i, j, k, itemstack);
|
||||
- }
|
||||
- // CraftBukkit end */
|
||||
-
|
||||
- super.remove(world, i, j, k, l, i1);
|
||||
- }
|
||||
-}
|
||||
-```
|
||||
-
|
||||
-#### CraftBukkit Comments
|
||||
-
|
||||
-Changes to a Minecraft class should be clearly marked using CraftBukkit comments.
|
||||
-
|
||||
-* All CraftBukkit comments should be capitalised appropriately. (i.e. CraftBukkit, not CB/craftBukkit, etc.)
|
||||
-* If the change only affects one line of code, use an end of line CraftBukkit comment
|
||||
-
|
||||
-__Examples:__
|
||||
-
|
||||
-If the change is obvious, then you need a simple end of line comment.
|
||||
-```java
|
||||
-if (true || minecraftserver.getAllowNether()) { // CraftBukkit
|
||||
-```
|
||||
-
|
||||
-Every reference to an obfuscated field/method in NMS should be marked with:
|
||||
-```java
|
||||
-// PAIL rename newName
|
||||
-```
|
||||
-All PAIL rename comments must include a new name.
|
||||
-
|
||||
-If, however, the change is something important to note or difficult to discern, you should include a reason at the end of the comment
|
||||
-```java
|
||||
-public int fireTicks; // PAIL private -> public
|
||||
-```
|
||||
-Changing access levels must include a PAIL comment indicating the previous access level and the new access level.
|
||||
-
|
||||
-If adding the CraftBukkit comment negatively affects the readability of the code, then you should place the comment on a new line *above* the change you made.
|
||||
-```java
|
||||
-// CraftBukkit
|
||||
-if (!isEffect && !world.isStatic && world.difficulty >= 2 && world.areChunksLoaded(MathHelper.floor(d0), MathHelper.floor(d1), MathHelper.floor(d2), 10)) {
|
||||
-```
|
||||
-
|
||||
-* If the change affects more than one line, you should use a multi-line CraftBukkit comment.
|
||||
-
|
||||
-__Example:__
|
||||
-
|
||||
-The majority of the time, multi-line changes should be accompanied by a reason since they're usually much more complicated than a single line change.
|
||||
-*If the change is something important to note or difficult to discern, you should include a reason at the end of line CraftBukkit comment.*
|
||||
-```java
|
||||
-// CraftBukkit start - special case dropping so we can get info from the tile entity
|
||||
-public void dropNaturally(World world, int i, int j, int k, int l, float f, int i1) {
|
||||
- if (world.random.nextFloat() < f) {
|
||||
- ItemStack itemstack = new ItemStack(Item.SKULL, 1, this.getDropData(world, i, j, k));
|
||||
- TileEntitySkull tileentityskull = (TileEntitySkull) world.getTileEntity(i, j, k);
|
||||
-
|
||||
- if (tileentityskull.getSkullType() == 3 && tileentityskull.getExtraType() != null && tileentityskull.getExtraType().length() > 0) {
|
||||
- itemstack.setTag(new NBTTagCompound());
|
||||
- itemstack.getTag().setString("SkullOwner", tileentityskull.getExtraType());
|
||||
- }
|
||||
-
|
||||
- this.b(world, i, j, k, itemstack);
|
||||
- }
|
||||
-}
|
||||
-// CraftBukkit end
|
||||
-```
|
||||
-Otherwise, if the change is obvious, such as firing an event, then you can simply use a multi-line comment.
|
||||
-```java
|
||||
- // CraftBukkit start
|
||||
- BlockIgniteEvent event = new BlockIgniteEvent(this.cworld.getBlockAt(i, j, k), BlockIgniteEvent.IgniteCause.LIGHTNING, null);
|
||||
- world.getServer().getPluginManager().callEvent(event);
|
||||
-
|
||||
- if (!event.isCancelled()) {
|
||||
- world.setTypeIdUpdate(i, j, k, Block.FIRE);
|
||||
- }
|
||||
- // CraftBukkit end
|
||||
-```
|
||||
-* All CraftBukkit comments should be on the same indentation level the code block it is in.
|
||||
-
|
||||
-__Imports in Minecraft Classes__
|
||||
-* Do not remove unused imports if they are not marked by CraftBukkit comments.
|
||||
-
|
||||
-Creating Pull Requests
|
||||
-----------------------
|
||||
-To learn what Spigot expects of a Pull Request please view the [Contributing guidelines](CONTRIBUTING.md)
|
||||
-
|
||||
-Useful Resources
|
||||
-----------------
|
||||
-
|
||||
-* [An example pull request demonstrating the things we look out for](https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/pull-requests/365/overview)
|
||||
-* [JIRA, our bug tracker](http://hub.spigotmc.org/jira/)
|
||||
-* [Join us on IRC - #spigot-dev @ irc.spi.gt](https://www.spigotmc.org/wiki/irc-guide/)
|
||||
diff --git a/build.gradle.kts b/build.gradle.kts
|
||||
new file mode 100644
|
||||
index 0000000000000000000000000000000000000000..73df2d0ded415fc718ffb1ef7ca63fc9b9fc7ecd
|
||||
|
|
|
|||
|
|
@ -5,11 +5,11 @@ Subject: [PATCH] Fix remap
|
|||
|
||||
|
||||
diff --git a/src/main/java/net/minecraft/world/entity/monster/Phantom.java b/src/main/java/net/minecraft/world/entity/monster/Phantom.java
|
||||
index 4a2fecdfbda34d6360d50e2ac017907a62b4a043..06921838c363fbcde8be9a55741538d3b3c9f6b0 100644
|
||||
index d82c562550532ae0981da153bcacfa977aeb9ca2..4708eabc69351735444087c975d32f96e1c69804 100644
|
||||
--- a/src/main/java/net/minecraft/world/entity/monster/Phantom.java
|
||||
+++ b/src/main/java/net/minecraft/world/entity/monster/Phantom.java
|
||||
@@ -236,7 +236,7 @@ public class Phantom extends FlyingMob implements Enemy {
|
||||
List<Player> list = Phantom.this.level.getNearbyPlayers(this.attackTargeting, (LivingEntity) Phantom.this, Phantom.this.getBoundingBox().inflate(16.0D, 64.0D, 16.0D));
|
||||
List<Player> list = Phantom.this.level.getNearbyPlayers(this.b, (LivingEntity) Phantom.this, Phantom.this.getBoundingBox().inflate(16.0D, 64.0D, 16.0D));
|
||||
|
||||
if (!list.isEmpty()) {
|
||||
- list.sort(Comparator.comparing(Entity::getY).reversed());
|
||||
|
|
|
|||
|
|
@ -5,19 +5,19 @@ Subject: [PATCH] Switch to AtomicInteger for chatSpamTickCount
|
|||
|
||||
|
||||
diff --git a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
||||
index 70b5ac18bcab5bbb46b1e206b512e5a1c8131748..861efdeb98bd7321afffe4780df7df1fadb2d9d9 100644
|
||||
index f93d5d13cf32550794db71b876210d969bd6ef2b..0a7bf606616271b550a5b42e993b39bfb604fedf 100644
|
||||
--- a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
||||
+++ b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
||||
@@ -222,8 +222,7 @@ public class ServerGamePacketListenerImpl implements ServerGamePacketListener {
|
||||
private boolean keepAlivePending;
|
||||
private long keepAliveChallenge;
|
||||
private long h;
|
||||
// CraftBukkit start - multithreaded fields
|
||||
- private volatile int chatSpamTickCount;
|
||||
- private static final AtomicIntegerFieldUpdater chatSpamField = AtomicIntegerFieldUpdater.newUpdater(ServerGamePacketListenerImpl.class, "chatThrottle");
|
||||
+ private final java.util.concurrent.atomic.AtomicInteger chatSpamTickCount = new java.util.concurrent.atomic.AtomicInteger(0); // Paper - switch to AtomicInteger
|
||||
// CraftBukkit end
|
||||
private int dropSpamTickCount;
|
||||
private final Int2ShortMap expectedAcks = new Int2ShortOpenHashMap();
|
||||
private int j;
|
||||
private final Int2ShortMap k = new Int2ShortOpenHashMap();
|
||||
@@ -351,7 +350,7 @@ public class ServerGamePacketListenerImpl implements ServerGamePacketListener {
|
||||
|
||||
this.server.getProfiler().pop();
|
||||
|
|
|
|||
|
|
@ -2,4 +2,4 @@ authlib com/mojang/authlib/yggdrasil/YggdrasilGameProfileRepository.java
|
|||
datafixerupper com/mojang/datafixers/DataFixerBuilder.java
|
||||
datafixerupper com/mojang/datafixers/util/Either.java
|
||||
datafixerupper com/mojang/serialization/codecs/KeyDispatchCodec.java
|
||||
datafixerupper com/mojang/serialization Dynamic.java
|
||||
datafixerupper com/mojang/serialization/Dynamic.java
|
||||
|
|
@ -1,16 +1,10 @@
|
|||
plugins {
|
||||
java
|
||||
id("com.github.johnrengelman.shadow") version "7.0.0" apply false
|
||||
id("io.papermc.paperweight.core") version "1.0.0-LOCAL-SNAPSHOT"
|
||||
id("io.papermc.paperweight.core") version "1.1.7-LOCAL-SNAPSHOT"
|
||||
}
|
||||
|
||||
group = "com.destroystokyo.paper"
|
||||
version = providers.gradleProperty("projectVersion").forUseAtConfigurationTime().get()
|
||||
|
||||
val mcVersion = providers.gradleProperty("mcVersion")
|
||||
val packageVersion = providers.gradleProperty("packageVersion")
|
||||
|
||||
allprojects {
|
||||
subprojects {
|
||||
apply(plugin = "java")
|
||||
|
||||
java {
|
||||
|
|
@ -18,11 +12,9 @@ allprojects {
|
|||
languageVersion.set(JavaLanguageVersion.of(11))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
subprojects {
|
||||
tasks.withType<JavaCompile>().configureEach {
|
||||
options.encoding = "UTF-8"
|
||||
tasks.withType<JavaCompile> {
|
||||
options.encoding = Charsets.UTF_8.name()
|
||||
options.release.set(8)
|
||||
}
|
||||
|
||||
|
|
@ -42,9 +34,8 @@ subprojects {
|
|||
}
|
||||
|
||||
repositories {
|
||||
mavenLocal()
|
||||
|
||||
maven("https://wav.jfrog.io/artifactory/repo/") {
|
||||
mavenCentral()
|
||||
maven("https://papermc.io/repo/repository/maven-public/") {
|
||||
content {
|
||||
onlyForConfigurations("paperclip")
|
||||
}
|
||||
|
|
@ -63,21 +54,22 @@ repositories {
|
|||
|
||||
dependencies {
|
||||
paramMappings("org.quiltmc:yarn:1.16.5+build.6:mergedv2")
|
||||
remapper("org.quiltmc:tiny-remapper:0.3.2:fat@jar")
|
||||
decompiler("net.minecraftforge:forgeflower:1.5.498.5@jar")
|
||||
paperclip("io.papermc:paperclip:2.0.0-SNAPSHOT@jar")
|
||||
remapper("org.quiltmc:tiny-remapper:0.4.1")
|
||||
decompiler("net.minecraftforge:forgeflower:1.5.498.12")
|
||||
paperclip("io.papermc:paperclip:2.0.1")
|
||||
}
|
||||
|
||||
paperweight {
|
||||
minecraftVersion.set(mcVersion)
|
||||
versionPackage.set(packageVersion)
|
||||
minecraftVersion.set(providers.gradleProperty("mcVersion"))
|
||||
serverProject.set(project(":Paper-Server"))
|
||||
|
||||
paper {
|
||||
mappingsPatch.set(file("build-data/mappings-patch.tiny"))
|
||||
spigotApiPatchDir.set(layout.projectDirectory.dir("Spigot-API-Patches"))
|
||||
spigotServerPatchDir.set(layout.projectDirectory.dir("Spigot-Server-Patches"))
|
||||
|
||||
additionalSpigotMemberMappings.set(file("build-data/additional-spigot-member-mappings.csrg"))
|
||||
mappingsPatch.set(layout.projectDirectory.file("build-data/mappings-patch.tiny"))
|
||||
|
||||
craftBukkitPatchPatchesDir.set(file("build-data/craftbukkit-patch-patches"))
|
||||
additionalSpigotMemberMappings.set(layout.projectDirectory.file("build-data/additional-spigot-member-mappings.csrg"))
|
||||
craftBukkitPatchPatchesDir.set(layout.projectDirectory.dir("build-data/craftbukkit-patch-patches"))
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,3 +1,5 @@
|
|||
group = io.papermc.paper
|
||||
version = 1.16.5-R0.1-SNAPSHOT
|
||||
|
||||
mcVersion = 1.16.5
|
||||
projectVersion = 1.16.5-R0.1-SNAPSHOT
|
||||
packageVersion = 1_16_R3
|
||||
|
|
|
|||
2
gradle/wrapper/gradle-wrapper.properties
vendored
2
gradle/wrapper/gradle-wrapper.properties
vendored
|
|
@ -1,5 +1,5 @@
|
|||
distributionBase=GRADLE_USER_HOME
|
||||
distributionPath=wrapper/dists
|
||||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-bin.zip
|
||||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.1-bin.zip
|
||||
zipStoreBase=GRADLE_USER_HOME
|
||||
zipStorePath=wrapper/dists
|
||||
|
|
|
|||
|
|
@ -1,8 +1,8 @@
|
|||
pluginManagement {
|
||||
repositories {
|
||||
gradlePluginPortal()
|
||||
maven("https://wav.jfrog.io/artifactory/repo/")
|
||||
mavenLocal()
|
||||
gradlePluginPortal()
|
||||
maven("https://papermc.io/repo/repository/maven-public/")
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue