From 30ccd487cf365b01fb35ce32119a8071ee9da823 Mon Sep 17 00:00:00 2001
From: Shane Freeder <theboyetronic@gmail.com>
Date: Sat, 19 Mar 2022 12:12:22 +0000
Subject: [PATCH] Buffer OOB setBlock calls

lets debug mode throw a trace in order to potentially see where
such calls are cascading from easier, but, generally, if you see one setBlock
call, you're gonna see more, and this just potentially causes a flood of logs
which can cause issues for slower terminals, etc.

We can limit the flood by just allowing one for a single gen region,
we'll also only gen a trace for the first one, I see no real pressing need
to generate more, given that that would *massively* negate this patch otherwise
---
 .../server/level/WorldGenRegion.java.patch    | 46 ++++++++++++++-----
 1 file changed, 35 insertions(+), 11 deletions(-)

diff --git a/paper-server/patches/sources/net/minecraft/server/level/WorldGenRegion.java.patch b/paper-server/patches/sources/net/minecraft/server/level/WorldGenRegion.java.patch
index 1d2368fa8b..5f8886a191 100644
--- a/paper-server/patches/sources/net/minecraft/server/level/WorldGenRegion.java.patch
+++ b/paper-server/patches/sources/net/minecraft/server/level/WorldGenRegion.java.patch
@@ -1,12 +1,14 @@
 --- a/net/minecraft/server/level/WorldGenRegion.java
 +++ b/net/minecraft/server/level/WorldGenRegion.java
-@@ -169,7 +169,27 @@
-         return k < this.generatingStep.directDependencies().size();
-     }
+@@ -167,7 +167,27 @@
+         int k = this.center.getPos().getChessboardDistance(chunkX, chunkZ);
  
+         return k < this.generatingStep.directDependencies().size();
++    }
++
 +    // Paper start - if loaded util
 +    @Nullable
-     @Override
++    @Override
 +    public ChunkAccess getChunkIfLoadedImmediately(int x, int z) {
 +        return this.getChunk(x, z, ChunkStatus.FULL, false);
 +    }
@@ -21,13 +23,11 @@
 +    public final FluidState getFluidIfLoaded(BlockPos blockposition) {
 +        ChunkAccess chunk = this.getChunkIfLoadedImmediately(blockposition.getX() >> 4, blockposition.getZ() >> 4);
 +        return chunk == null ? null : chunk.getFluidState(blockposition);
-+    }
-+    // Paper end
-+
-+    @Override
-     public BlockState getBlockState(BlockPos pos) {
-         return this.getChunk(SectionPos.blockToSectionCoord(pos.getX()), SectionPos.blockToSectionCoord(pos.getZ())).getBlockState(pos);
      }
++    // Paper end
+ 
+     @Override
+     public BlockState getBlockState(BlockPos pos) {
 @@ -217,7 +237,7 @@
          if (iblockdata.isAir()) {
              return false;
@@ -37,7 +37,31 @@
                  BlockEntity tileentity = iblockdata.hasBlockEntity() ? this.getBlockEntity(pos) : null;
  
                  Block.dropResources(iblockdata, this.level, pos, tileentity, breakingEntity, ItemStack.EMPTY);
-@@ -336,6 +356,13 @@
+@@ -264,6 +284,7 @@
+         }
+     }
+ 
++    private boolean hasSetFarWarned = false; // Paper - Buffer OOB setBlock calls
+     @Override
+     public boolean ensureCanWrite(BlockPos pos) {
+         int i = SectionPos.blockToSectionCoord(pos.getX());
+@@ -283,7 +304,15 @@
+ 
+             return true;
+         } else {
++            // Paper start - Buffer OOB setBlock calls
++            if (!hasSetFarWarned) {
+             Util.logAndPauseIfInIde("Detected setBlock in a far chunk [" + i + ", " + j + "], pos: " + String.valueOf(pos) + ", status: " + String.valueOf(this.generatingStep.targetStatus()) + (this.currentlyGenerating == null ? "" : ", currently generating: " + (String) this.currentlyGenerating.get()));
++                hasSetFarWarned = true;
++                if (this.getServer() != null && this.getServer().isDebugging()) {
++                    io.papermc.paper.util.TraceUtil.dumpTraceForThread("far setBlock call");
++                }
++            }
++            // Paper end - Buffer OOB setBlock calls
+             return false;
+         }
+     }
+@@ -336,6 +365,13 @@
  
      @Override
      public boolean addFreshEntity(Entity entity) {