From 391324437a654965be7aa40b35d149bd89325de2 Mon Sep 17 00:00:00 2001 From: Minecrell Date: Thu, 19 Jul 2018 20:14:27 +0200 Subject: [PATCH] Avoid adding NetworkManager twice The removal of `ServerConnection.this.h.add(networkmanager);` got lost in the 1.13 update, causing network managers to be registered twice. Fixes "handleDisconnection() called twice" warning spam in console. --- .../Avoid-blocking-on-Network-Manager-creation.patch | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Spigot-Server-Patches/Avoid-blocking-on-Network-Manager-creation.patch b/Spigot-Server-Patches/Avoid-blocking-on-Network-Manager-creation.patch index a68c6ccff6..8c4cc73e2b 100644 --- a/Spigot-Server-Patches/Avoid-blocking-on-Network-Manager-creation.patch +++ b/Spigot-Server-Patches/Avoid-blocking-on-Network-Manager-creation.patch @@ -6,7 +6,7 @@ Subject: [PATCH] Avoid blocking on Network Manager creation Per Paper issue 294 diff --git a/src/main/java/net/minecraft/server/ServerConnection.java b/src/main/java/net/minecraft/server/ServerConnection.java -index be8d07f41..ad49673c1 100644 +index be8d07f41..9808561eb 100644 --- a/src/main/java/net/minecraft/server/ServerConnection.java +++ b/src/main/java/net/minecraft/server/ServerConnection.java @@ -0,0 +0,0 @@ public class ServerConnection { @@ -26,9 +26,10 @@ index be8d07f41..ad49673c1 100644 public ServerConnection(MinecraftServer minecraftserver) { this.e = minecraftserver; @@ -0,0 +0,0 @@ public class ServerConnection { + channel.pipeline().addLast("timeout", new ReadTimeoutHandler(30)).addLast("legacy_query", new LegacyPingHandler(ServerConnection.this)).addLast("splitter", new PacketSplitter()).addLast("decoder", new PacketDecoder(EnumProtocolDirection.SERVERBOUND)).addLast("prepender", new PacketPrepender()).addLast("encoder", new PacketEncoder(EnumProtocolDirection.CLIENTBOUND)); NetworkManager networkmanager = new NetworkManager(EnumProtocolDirection.SERVERBOUND); - ServerConnection.this.g.add(networkmanager); +- ServerConnection.this.g.add(networkmanager); + pending.add(networkmanager); // Paper channel.pipeline().addLast("packet_handler", networkmanager); networkmanager.setPacketListener(new HandshakeListener(ServerConnection.this.e, networkmanager));