OpenSource/PaperMC
OpenSource/PaperMC
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2025-01-09 19:49:35 +01:00
Code Issues Projects Releases Packages Wiki Activity

Validate method parameters when registering events. Fixes BUKKIT-3779

Browse source 
By: feildmaster <admin@feildmaster.com>
This commit is contained in:
Bukkit/Spigot 2013-03-16 17:17:09 -05:00
parent 6e7076fd64
commit 50f297d941
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
paper-api/src/main/java/org/bukkit/plugin/java/JavaPluginLoader.java
View file

@ -380,8 +380,8 @@ public class JavaPluginLoader implements PluginLoader {
for (final Method method : methods) { for (final Method method : methods) {
final EventHandler eh = method.getAnnotation(EventHandler.class); final EventHandler eh = method.getAnnotation(EventHandler.class);
if (eh == null) continue; if (eh == null) continue;
final Class<?> checkClass = method.getParameterTypes()[0]; final Class<?> checkClass;
if (!Event.class.isAssignableFrom(checkClass) || method.getParameterTypes().length != 1) { if (method.getParameterTypes().length != 1 || !Event.class.isAssignableFrom(checkClass = method.getParameterTypes()[0])) {
plugin.getLogger().severe(plugin.getDescription().getFullName() + " attempted to register an invalid EventHandler method signature \"" + method.toGenericString() + "\" in " + listener.getClass()); plugin.getLogger().severe(plugin.getDescription().getFullName() + " attempted to register an invalid EventHandler method signature \"" + method.toGenericString() + "\" in " + listener.getClass());
continue; continue;
} }