OpenSource/PaperMC
OpenSource/PaperMC
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2025-01-08 19:34:09 +01:00
Code Issues Projects Releases Packages Wiki Activity

Deprecate ItemStack durability methods in favour of ItemMeta Damageable as they are being frequently used incorrectly.

Browse source 
By: md_5 <git@md-5.net>
This commit is contained in:
Bukkit/Spigot 2018-08-25 22:27:13 +10:00
parent f8d657dc45
commit 57171268d8
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
paper-api/src/main/java/org/bukkit/inventory/ItemStack.java
View file

@ -51,6 +51,7 @@ public class ItemStack implements Cloneable, ConfigurationSerializable {
* @param type item material * @param type item material
* @param amount stack size * @param amount stack size
* @param damage durability / damage * @param damage durability / damage
* @deprecated see {@link #setDurability(short)}
*/ */
public ItemStack(final Material type, final int amount, final short damage) { public ItemStack(final Material type, final int amount, final short damage) {
this(type, amount, damage, null); this(type, amount, damage, null);
@ -177,7 +178,13 @@ public class ItemStack implements Cloneable, ConfigurationSerializable {
* Sets the durability of this item * Sets the durability of this item
* *
* @param durability Durability of this item * @param durability Durability of this item
* @deprecated durability is now part of ItemMeta. To avoid confusion and
* misuse, {@link #getItemMeta()}, {@link #setItemMeta(ItemMeta)} and
* {@link Damageable#setDamage(int)} should be used instead. This is because
* any call to this method will be overwritten by subsequent setting of
* ItemMeta which was created before this call.
*/ */
@Deprecated
public void setDurability(final short durability) { public void setDurability(final short durability) {
ItemMeta meta = getItemMeta(); ItemMeta meta = getItemMeta();
if (meta != null) { if (meta != null) {
@ -190,7 +197,9 @@ public class ItemStack implements Cloneable, ConfigurationSerializable {
* Gets the durability of this item * Gets the durability of this item
* *
* @return Durability of this item * @return Durability of this item
* @deprecated see {@link #setDurability(short)}
*/ */
@Deprecated
public short getDurability() { public short getDurability() {
ItemMeta meta = getItemMeta(); ItemMeta meta = getItemMeta();
return (meta == null) ? 0 : (short) ((Damageable) meta).getDamage(); return (meta == null) ? 0 : (short) ((Damageable) meta).getDamage();