From 59da9d1a80f988c99cdd6c228be8bf44bff3f3ef Mon Sep 17 00:00:00 2001 From: Jake Potrebic <jake.m.potrebic@gmail.com> Date: Mon, 17 Jun 2024 17:42:48 -0700 Subject: [PATCH] Fix NPE for Jukebox#setRecord Fallback to the global registry if no level exists Fixes #10899 --- .../Fix-NPE-for-Jukebox-setRecord.patch | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 patches/server/Fix-NPE-for-Jukebox-setRecord.patch diff --git a/patches/server/Fix-NPE-for-Jukebox-setRecord.patch b/patches/server/Fix-NPE-for-Jukebox-setRecord.patch new file mode 100644 index 0000000000..5e4f062270 --- /dev/null +++ b/patches/server/Fix-NPE-for-Jukebox-setRecord.patch @@ -0,0 +1,20 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Jake Potrebic <jake.m.potrebic@gmail.com> +Date: Mon, 17 Jun 2024 17:41:09 -0700 +Subject: [PATCH] Fix NPE for Jukebox#setRecord + +Fallback to the global registry if no level exists + +diff --git a/src/main/java/net/minecraft/world/level/block/entity/JukeboxBlockEntity.java b/src/main/java/net/minecraft/world/level/block/entity/JukeboxBlockEntity.java +index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644 +--- a/src/main/java/net/minecraft/world/level/block/entity/JukeboxBlockEntity.java ++++ b/src/main/java/net/minecraft/world/level/block/entity/JukeboxBlockEntity.java +@@ -0,0 +0,0 @@ public class JukeboxBlockEntity extends BlockEntity implements Clearable, Contai + public void setSongItemWithoutPlaying(ItemStack itemstack, long ticksSinceSongStarted) { // CraftBukkit - add argument + this.item = itemstack; + this.jukeboxSongPlayer.song = null; // CraftBukkit - reset +- JukeboxSong.fromStack(this.level.registryAccess(), itemstack).ifPresent((holder) -> { ++ JukeboxSong.fromStack(this.level != null ? this.level.registryAccess() : org.bukkit.craftbukkit.CraftRegistry.getMinecraftRegistry(), itemstack).ifPresent((holder) -> { // Paper - fallback to other RegistyrAccess if no level + this.jukeboxSongPlayer.setSongWithoutPlaying(holder, ticksSinceSongStarted); // CraftBukkit - add argument + }); + // CraftBukkit start - add null check for level