From 5ac3ad3792f27b8527c989635d138ba7512b04b7 Mon Sep 17 00:00:00 2001 From: Jake Potrebic Date: Thu, 27 May 2021 21:58:33 -0700 Subject: [PATCH] More PotionEffectType API --- .../src/main/java/org/bukkit/Registry.java | 9 +++ .../org/bukkit/potion/PotionEffectType.java | 55 ++++++++++++++++++- .../potion/PotionEffectTypeWrapper.java | 37 +++++++++++++ 3 files changed, 100 insertions(+), 1 deletion(-) diff --git a/paper-api/src/main/java/org/bukkit/Registry.java b/paper-api/src/main/java/org/bukkit/Registry.java index d03bdf6617..b2bd12736d 100644 --- a/paper-api/src/main/java/org/bukkit/Registry.java +++ b/paper-api/src/main/java/org/bukkit/Registry.java @@ -367,6 +367,15 @@ public interface Registry extends Iterable { * @see GameEvent */ Registry GAME_EVENT = io.papermc.paper.registry.RegistryAccess.registryAccess().getRegistry(io.papermc.paper.registry.RegistryKey.GAME_EVENT); // Paper + + // Paper start - potion effect type registry + /** + * Potion effect types. + * + * @see org.bukkit.potion.PotionEffectType + */ + Registry POTION_EFFECT_TYPE = EFFECT; + // Paper end - potion effect type registry /** * Get the object by its key. * diff --git a/paper-api/src/main/java/org/bukkit/potion/PotionEffectType.java b/paper-api/src/main/java/org/bukkit/potion/PotionEffectType.java index 6375eed0ef..5f32728fad 100644 --- a/paper-api/src/main/java/org/bukkit/potion/PotionEffectType.java +++ b/paper-api/src/main/java/org/bukkit/potion/PotionEffectType.java @@ -17,7 +17,7 @@ import org.jetbrains.annotations.Nullable; /** * Represents a type of potion and its effect on an entity. */ -public abstract class PotionEffectType implements Keyed, Translatable { +public abstract class PotionEffectType implements Keyed, Translatable, net.kyori.adventure.translation.Translatable { // Paper - implement Translatable private static final BiMap ID_MAP = HashBiMap.create(); /** @@ -360,4 +360,57 @@ public abstract class PotionEffectType implements Keyed, Translatable { public static PotionEffectType[] values() { return Lists.newArrayList(Registry.EFFECT).toArray(new PotionEffectType[0]); } + + // Paper start + /** + * Gets the effect attributes in an immutable map. + * + * @return the attribute map + */ + public abstract @NotNull java.util.Map getEffectAttributes(); + + /** + * Gets the true modifier amount based on the effect amplifier. + * + * @param attribute the attribute + * @param effectAmplifier the effect amplifier (0 indexed) + * @return the modifier amount + * @throws IllegalArgumentException if the supplied attribute is not present in the map from {@link #getEffectAttributes()} + */ + public abstract double getAttributeModifierAmount(@NotNull org.bukkit.attribute.Attribute attribute, int effectAmplifier); + + /** + * Gets the category of this effect + * + * @return the category + */ + public abstract @NotNull PotionEffectType.Category getEffectCategory(); + + /** + * Category of {@link PotionEffectType}s + */ + public enum Category { + + BENEFICIAL(net.kyori.adventure.text.format.NamedTextColor.BLUE), + HARMFUL(net.kyori.adventure.text.format.NamedTextColor.RED), + NEUTRAL(net.kyori.adventure.text.format.NamedTextColor.BLUE); + + private final net.kyori.adventure.text.format.TextColor color; + + Category(net.kyori.adventure.text.format.TextColor color) { + this.color = color; + } + + /** + * Gets the text color used when displaying potions + * of this category. + * + * @return the text color + */ + @NotNull + public net.kyori.adventure.text.format.TextColor getColor() { + return color; + } + } + // Paper end } diff --git a/paper-api/src/main/java/org/bukkit/potion/PotionEffectTypeWrapper.java b/paper-api/src/main/java/org/bukkit/potion/PotionEffectTypeWrapper.java index 6861d1cfce..7acdeb9054 100644 --- a/paper-api/src/main/java/org/bukkit/potion/PotionEffectTypeWrapper.java +++ b/paper-api/src/main/java/org/bukkit/potion/PotionEffectTypeWrapper.java @@ -19,4 +19,41 @@ public abstract class PotionEffectTypeWrapper extends PotionEffectType { public PotionEffectType getType() { return this; } + + @Override + public boolean isInstant() { + return getType().isInstant(); + } + + @NotNull + @Override + public org.bukkit.Color getColor() { + return getType().getColor(); + } + // Paper start + @Override + public @NotNull org.bukkit.NamespacedKey getKey() { + return this.getType().getKey(); + } + + @Override + public @NotNull java.util.Map getEffectAttributes() { + return this.getType().getEffectAttributes(); + } + + @Override + public double getAttributeModifierAmount(@NotNull org.bukkit.attribute.Attribute attribute, int effectAmplifier) { + return this.getType().getAttributeModifierAmount(attribute, effectAmplifier); + } + + @Override + public @NotNull PotionEffectType.Category getEffectCategory() { + return this.getType().getEffectCategory(); + } + + @Override + public @NotNull String translationKey() { + return this.getType().translationKey(); + } + // Paper end }