From 687db1c4106d054c38027bba7806a7af058f565c Mon Sep 17 00:00:00 2001 From: Warrior <50800980+Warriorrrr@users.noreply.github.com> Date: Mon, 15 May 2023 17:21:57 +0200 Subject: [PATCH] More accurate isInOpenWater impl (#9194) --- .../More-accurate-isInOpenWater-impl.patch | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 patches/server/More-accurate-isInOpenWater-impl.patch diff --git a/patches/server/More-accurate-isInOpenWater-impl.patch b/patches/server/More-accurate-isInOpenWater-impl.patch new file mode 100644 index 0000000000..7ab5bcc501 --- /dev/null +++ b/patches/server/More-accurate-isInOpenWater-impl.patch @@ -0,0 +1,27 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Warrior <50800980+Warriorrrr@users.noreply.github.com> +Date: Sun, 7 May 2023 22:33:50 +0200 +Subject: [PATCH] More accurate isInOpenWater impl + +For fishing hooks, the openWater field is true by default, and only calculated when a "fish" is approaching the bobber. +This patch changes the API impl to calculate the open water state itself instead of returning this field. + +Relevant link: https://github.com/PaperMC/Paper/issues/9131 + +== AT == +public net.minecraft.world.entity.projectile.FishingHook calculateOpenWater(Lnet/minecraft/core/BlockPos;)Z +public net.minecraft.world.entity.projectile.FishingHook outOfWaterTime + +diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftFishHook.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftFishHook.java +index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644 +--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftFishHook.java ++++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftFishHook.java +@@ -0,0 +0,0 @@ public class CraftFishHook extends CraftProjectile implements FishHook { + + @Override + public boolean isInOpenWater() { +- return this.getHandle().isOpenWaterFishing(); ++ return this.getHandle().outOfWaterTime < 10 && this.getHandle().calculateOpenWater(this.getHandle().blockPosition()); // Paper - isOpenWaterFishing is only calculated when a "fish" is approaching the hook + } + + @Override