Added pull request conventions that should be followed if you want your pull requests accepted.

By: EvilSeph <evilseph@unaligned.org>
This commit is contained in:
Bukkit/Spigot 2011-02-18 17:14:18 -05:00
parent d7633fa07b
commit 77a963e3eb

View file

@ -11,7 +11,7 @@ We use maven to handle our dependencies.
* Install [Maven 3](http://maven.apache.org/download.html)
* Check out this repo and: `mvn clean install`
Coding Conventions
Coding and Pull Request Conventions
-----------
* We generally follow the Sun/Oracle coding standards.
@ -19,5 +19,8 @@ Coding Conventions
* No trailing whitespaces.
* No 80 column limit or midstatement newlines.
* Proper javadoc for each method added/changed to describe what it does.
* The number of commits in a pull request should be kept to a minimum (squish them into one most of the time - use common sense!).
* No merges should be included in pull requests unless the pull request's purpose is a merge.
* Pull requests should be tested (does it compile? AND does it work?) before submission.
Follow the above conventions if you want your pull requests accepted.