From 88b2f00a0368053f9dad47087b6dfae68a09e3fc Mon Sep 17 00:00:00 2001 From: Lexi Date: Thu, 30 Sep 2021 20:39:17 -0400 Subject: [PATCH] Preserve overstacked loot (#5943) --- .../server/Preserve-overstacked-loot.patch | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 patches/server/Preserve-overstacked-loot.patch diff --git a/patches/server/Preserve-overstacked-loot.patch b/patches/server/Preserve-overstacked-loot.patch new file mode 100644 index 0000000000..0dc068f5c5 --- /dev/null +++ b/patches/server/Preserve-overstacked-loot.patch @@ -0,0 +1,72 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: lexikiq +Date: Mon, 21 Jun 2021 23:21:58 -0400 +Subject: [PATCH] Preserve overstacked loot + +Preserves overstacked items in loot tables, such as shulker box drops, to prevent the items +from being deleted (as they'd overflow past the bounds of the container)-- or worse, causing +chunk bans via the large amount of NBT created by unstacking the items. + +Fixes GH-5140 and GH-4748. + +diff --git a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java +index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644 +--- a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java ++++ b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java +@@ -0,0 +0,0 @@ public class PaperWorldConfig { + allowPlayerCrammingDamage = getBoolean("allow-player-cramming-damage", allowPlayerCrammingDamage); + } + ++ public boolean splitOverstackedLoot = true; ++ private void splitOverstackedLoot() { ++ splitOverstackedLoot = getBoolean("split-overstacked-loot", splitOverstackedLoot); ++ } ++ + private Table sensorTickRates; + private Table behaviorTickRates; + private void tickRates() { +diff --git a/src/main/java/net/minecraft/world/level/storage/loot/LootTable.java b/src/main/java/net/minecraft/world/level/storage/loot/LootTable.java +index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644 +--- a/src/main/java/net/minecraft/world/level/storage/loot/LootTable.java ++++ b/src/main/java/net/minecraft/world/level/storage/loot/LootTable.java +@@ -0,0 +0,0 @@ public class LootTable { + this.compositeFunction = LootItemFunctions.compose(functions); + } + ++ @Deprecated // Paper - preserve overstacked items + public static Consumer createStackSplitter(Consumer lootConsumer) { ++ // Paper start - preserve overstacked items ++ return createStackSplitter(lootConsumer, null); ++ } ++ ++ public static Consumer createStackSplitter(Consumer lootConsumer, @org.jetbrains.annotations.Nullable net.minecraft.server.level.ServerLevel world) { ++ boolean skipSplitter = world != null && !world.paperConfig.splitOverstackedLoot; ++ // Paper end + return (itemstack) -> { +- if (itemstack.getCount() < itemstack.getMaxStackSize()) { ++ if (skipSplitter || itemstack.getCount() < itemstack.getMaxStackSize()) { // Paper - preserve overstacked items + lootConsumer.accept(itemstack); + } else { + int i = itemstack.getCount(); +@@ -0,0 +0,0 @@ public class LootTable { + } + + public void getRandomItems(LootContext context, Consumer lootConsumer) { +- this.getRandomItemsRaw(context, LootTable.createStackSplitter(lootConsumer)); ++ this.getRandomItemsRaw(context, LootTable.createStackSplitter(lootConsumer, context.getLevel())); // Paper - preserve overstacked items + } + + public List getRandomItems(LootContext context) { +diff --git a/src/main/java/net/minecraft/world/level/storage/loot/functions/SetContainerContents.java b/src/main/java/net/minecraft/world/level/storage/loot/functions/SetContainerContents.java +index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644 +--- a/src/main/java/net/minecraft/world/level/storage/loot/functions/SetContainerContents.java ++++ b/src/main/java/net/minecraft/world/level/storage/loot/functions/SetContainerContents.java +@@ -0,0 +0,0 @@ public class SetContainerContents extends LootItemConditionalFunction { + NonNullList nonNullList = NonNullList.create(); + this.entries.forEach((entry) -> { + entry.expand(context, (choice) -> { +- choice.createItemStack(LootTable.createStackSplitter(nonNullList::add), context); ++ choice.createItemStack(LootTable.createStackSplitter(nonNullList::add, context.getLevel()), context); // Paper - preserve overstacked items + }); + }); + CompoundTag compoundTag = new CompoundTag();