mirror of
https://github.com/PaperMC/Paper.git
synced 2025-01-08 19:34:09 +01:00
Minecraft spec has changed and we're required to follow. We now build with Java 6.
By: EvilSeph <evilseph@gmail.com>
This commit is contained in:
parent
33843978fc
commit
a8125bab26
1 changed files with 2 additions and 2 deletions
|
@ -56,7 +56,7 @@ If you answered yes to any of these questions, chances are high your change does
|
||||||
* If the work you want to do involves editing Minecraft classes, be sure to read over the [Using Minecraft Internals](#using-minecraft-internals) section.
|
* If the work you want to do involves editing Minecraft classes, be sure to read over the [Using Minecraft Internals](#using-minecraft-internals) section.
|
||||||
* Make sure your commit messages are in the [proper format](#commit-message-example).
|
* Make sure your commit messages are in the [proper format](#commit-message-example).
|
||||||
* Test your changes to make sure it actually addresses the issue it should.
|
* Test your changes to make sure it actually addresses the issue it should.
|
||||||
* Make sure your code compiles under Java 5, as that is what the project has to be built with.
|
* Make sure your code compiles under Java 6, as that is what the project has to be built with.
|
||||||
|
|
||||||
### Code Requirements
|
### Code Requirements
|
||||||
* We generally follow the [Sun/Oracle coding standards](http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html).
|
* We generally follow the [Sun/Oracle coding standards](http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html).
|
||||||
|
@ -476,7 +476,7 @@ Making sure you follow the above conventions is important, but just the beginnin
|
||||||
|
|
||||||
* Your change should [fit with Bukkit's goals](#does-the-change-fit-bukkits-goals).
|
* Your change should [fit with Bukkit's goals](#does-the-change-fit-bukkits-goals).
|
||||||
* Make sure you follow all of our conventions to the letter.
|
* Make sure you follow all of our conventions to the letter.
|
||||||
* Make sure your code compiles under Java 5.
|
* Make sure your code compiles under Java 6.
|
||||||
* Check for misplaced whitespaces. It may be invisible, but [we notice](https://github.com/Bukkit/CraftBukkit/pull/1070).
|
* Check for misplaced whitespaces. It may be invisible, but [we notice](https://github.com/Bukkit/CraftBukkit/pull/1070).
|
||||||
* Provide proper JavaDocs where appropriate.
|
* Provide proper JavaDocs where appropriate.
|
||||||
* JavaDocs should detail every limitation, caveat and gotcha the code has.
|
* JavaDocs should detail every limitation, caveat and gotcha the code has.
|
||||||
|
|
Loading…
Reference in a new issue