From c54c062e6ff742445bf7749c84106ca67090172d Mon Sep 17 00:00:00 2001 From: Jake Potrebic Date: Thu, 5 Dec 2024 01:51:01 -0800 Subject: [PATCH] Port exact choice improvements (#11705) --- ...ove-exact-choice-recipe-ingredients.patch} | 293 ++++++++++-------- 1 file changed, 156 insertions(+), 137 deletions(-) rename patches/{unapplied/server/1061-Improve-exact-choice-recipe-ingredients.patch => server/1070-Improve-exact-choice-recipe-ingredients.patch} (59%) diff --git a/patches/unapplied/server/1061-Improve-exact-choice-recipe-ingredients.patch b/patches/server/1070-Improve-exact-choice-recipe-ingredients.patch similarity index 59% rename from patches/unapplied/server/1061-Improve-exact-choice-recipe-ingredients.patch rename to patches/server/1070-Improve-exact-choice-recipe-ingredients.patch index eaed7d5bad..06adda1e62 100644 --- a/patches/unapplied/server/1061-Improve-exact-choice-recipe-ingredients.patch +++ b/patches/server/1070-Improve-exact-choice-recipe-ingredients.patch @@ -13,7 +13,7 @@ public net.minecraft.world.item.ItemStackLinkedSet TYPE_AND_TAG diff --git a/src/main/java/io/papermc/paper/inventory/recipe/ItemOrExact.java b/src/main/java/io/papermc/paper/inventory/recipe/ItemOrExact.java new file mode 100644 -index 0000000000000000000000000000000000000000..caaad8f54fb892dfd6c7d4e02ab9c32997f89a6a +index 0000000000000000000000000000000000000000..ce745e49cd54fe3ae187785563a1bd311d14b5b2 --- /dev/null +++ b/src/main/java/io/papermc/paper/inventory/recipe/ItemOrExact.java @@ -0,0 +1,63 @@ @@ -41,7 +41,7 @@ index 0000000000000000000000000000000000000000..caaad8f54fb892dfd6c7d4e02ab9c329 + + @Override + public boolean matches(final ItemStack stack) { -+ return stack.is(this.item) && stack.getComponentsPatch().isEmpty(); ++ return stack.is(this.item); + } + + @Override @@ -82,10 +82,10 @@ index 0000000000000000000000000000000000000000..caaad8f54fb892dfd6c7d4e02ab9c329 +} diff --git a/src/main/java/io/papermc/paper/inventory/recipe/StackedContentsExtrasMap.java b/src/main/java/io/papermc/paper/inventory/recipe/StackedContentsExtrasMap.java new file mode 100644 -index 0000000000000000000000000000000000000000..bdb876a0e687d4b9e885118523e91185a164b27c +index 0000000000000000000000000000000000000000..f47c12e9dd6cfa857ca07a764edc22de372e25b6 --- /dev/null +++ b/src/main/java/io/papermc/paper/inventory/recipe/StackedContentsExtrasMap.java -@@ -0,0 +1,67 @@ +@@ -0,0 +1,68 @@ +package io.papermc.paper.inventory.recipe; + +import it.unimi.dsi.fastutil.objects.Object2IntMap; @@ -96,6 +96,7 @@ index 0000000000000000000000000000000000000000..bdb876a0e687d4b9e885118523e91185 +import net.minecraft.world.item.ItemStack; +import net.minecraft.world.item.ItemStackLinkedSet; +import net.minecraft.world.item.crafting.CraftingInput; ++import net.minecraft.world.item.crafting.Ingredient; +import net.minecraft.world.item.crafting.Recipe; + +public final class StackedContentsExtrasMap { @@ -110,9 +111,9 @@ index 0000000000000000000000000000000000000000..bdb876a0e687d4b9e885118523e91185 + + public void initialize(final Recipe recipe) { + this.exactIngredients.clear(); -+ for (final StackedContents.IngredientInfo info : recipe.placementInfo().unpackedIngredients()) { -+ if (info.isExact()) { -+ this.exactIngredients.addAll(info.allowedItems().stream().map(o -> ((ItemOrExact.Exact) o).stack()).toList()); ++ for (final Ingredient ingredient : recipe.placementInfo().ingredients()) { ++ if (ingredient.isExact()) { ++ this.exactIngredients.addAll(ingredient.itemStacks()); + } + } + } @@ -154,10 +155,10 @@ index 0000000000000000000000000000000000000000..bdb876a0e687d4b9e885118523e91185 + } +} diff --git a/src/main/java/net/minecraft/recipebook/ServerPlaceRecipe.java b/src/main/java/net/minecraft/recipebook/ServerPlaceRecipe.java -index 462a970ffa610bc1eb3c813dafb768c014d077d1..1afb544fb028b645821063ba1eaa9e3c45cee63f 100644 +index 6d3ccd19baab8f0571b71bd05979efb6b372a6f5..dc9b01db0853964da146ad4ccdc9e0e6f2a279f4 100644 --- a/src/main/java/net/minecraft/recipebook/ServerPlaceRecipe.java +++ b/src/main/java/net/minecraft/recipebook/ServerPlaceRecipe.java -@@ -41,6 +41,7 @@ public class ServerPlaceRecipe> { +@@ -40,6 +40,7 @@ public class ServerPlaceRecipe> { return RecipeBookMenu.PostPlaceAction.NOTHING; } else { StackedItemContents stackedItemContents = new StackedItemContents(); @@ -165,88 +166,109 @@ index 462a970ffa610bc1eb3c813dafb768c014d077d1..1afb544fb028b645821063ba1eaa9e3c inventory.fillStackedContents(stackedItemContents); handler.fillCraftSlotsStackedContents(stackedItemContents); return serverPlaceRecipe.tryPlaceRecipe(recipe, stackedItemContents); -@@ -100,9 +101,9 @@ public class ServerPlaceRecipe> { +@@ -99,7 +100,7 @@ public class ServerPlaceRecipe> { } int j = this.calculateAmountToCraft(i, bl); - List> list = new ArrayList<>(); + List list = new ArrayList<>(); // Paper - Improve exact choice recipe ingredients if (finder.canCraft(recipe.value(), j, list::add)) { -- OptionalInt optionalInt = list.stream().mapToInt(item -> item.value().getDefaultMaxStackSize()).min(); -+ OptionalInt optionalInt = list.stream().mapToInt(io.papermc.paper.inventory.recipe.ItemOrExact::getMaxStackSize).min(); // Paper - Improve exact choice recipe ingredients - if (optionalInt.isPresent()) { - j = Math.min(j, optionalInt.getAsInt()); - } -@@ -119,7 +120,7 @@ public class ServerPlaceRecipe> { - int kx = k; + int k = clampToMaxStackSize(j, list); + if (k != j) { +@@ -114,7 +115,7 @@ public class ServerPlaceRecipe> { + this.gridWidth, this.gridHeight, recipe.value(), recipe.value().placementInfo().slotsToIngredientIndex(), (slotx, index, x, y) -> { + if (slotx != -1) { + Slot slot2 = this.inputGridSlots.get(index); +- Holder holder = list.get(slotx); ++ io.papermc.paper.inventory.recipe.ItemOrExact holder = list.get(slotx); // Paper - Improve exact choice recipe ingredients + int jx = k; - while (kx > 0) { -- Holder holder = list.get(jx); -+ io.papermc.paper.inventory.recipe.ItemOrExact holder = list.get(jx); // Paper - Improve exact choice recipe ingredients - kx = this.moveItemToGrid(slot2, holder, kx); - if (kx == -1) { - return; -@@ -155,7 +156,7 @@ public class ServerPlaceRecipe> { + while (jx > 0) { +@@ -129,9 +130,11 @@ public class ServerPlaceRecipe> { + } + } + +- private static int clampToMaxStackSize(int count, List> entries) { +- for (Holder holder : entries) { +- count = Math.min(count, holder.value().getDefaultMaxStackSize()); ++ // Paper start - Improve exact choice recipe ingredients ++ private static int clampToMaxStackSize(int count, List entries) { ++ for (io.papermc.paper.inventory.recipe.ItemOrExact holder : entries) { ++ count = Math.min(count, holder.getMaxStackSize()); ++ // Paper end - Improve exact choice recipe ingredients + } + + return count; +@@ -160,7 +163,7 @@ public class ServerPlaceRecipe> { } } - private int moveItemToGrid(Slot slot, Holder item, int count) { + private int moveItemToGrid(Slot slot, io.papermc.paper.inventory.recipe.ItemOrExact item, int count) { // Paper - Improve exact choice recipe ingredients - int i = this.inventory.findSlotMatchingCraftingIngredient(item); + ItemStack itemStack = slot.getItem(); + int i = this.inventory.findSlotMatchingCraftingIngredient(item, itemStack); if (i == -1) { - return -1; diff --git a/src/main/java/net/minecraft/world/entity/player/Inventory.java b/src/main/java/net/minecraft/world/entity/player/Inventory.java -index ad82e5aeb565b23c3ec565fa60e1f31d1710bd4e..0990bcf65f484b9a019c91fcdae1783bac6388da 100644 +index 36ba57e95b84f3d598bf4be624d6c88b05a6f9a6..110456deaa662bc1c0f6ba7878bb3074869a4350 100644 --- a/src/main/java/net/minecraft/world/entity/player/Inventory.java +++ b/src/main/java/net/minecraft/world/entity/player/Inventory.java -@@ -201,11 +201,11 @@ public class Inventory implements Container, Nameable { +@@ -188,11 +188,11 @@ public class Inventory implements Container, Nameable { return !stack.isDamaged() && !stack.isEnchanted() && !stack.has(DataComponents.CUSTOM_NAME); } -- public int findSlotMatchingCraftingIngredient(Holder item) { -+ public int findSlotMatchingCraftingIngredient(io.papermc.paper.inventory.recipe.ItemOrExact item) { // Paper - Improve exact choice recipe ingredients +- public int findSlotMatchingCraftingIngredient(Holder item, ItemStack stack) { ++ public int findSlotMatchingCraftingIngredient(io.papermc.paper.inventory.recipe.ItemOrExact item, ItemStack stack) { // Paper - Improve exact choice recipe ingredients for (int i = 0; i < this.items.size(); ++i) { - ItemStack itemstack = (ItemStack) this.items.get(i); + ItemStack itemstack1 = (ItemStack) this.items.get(i); -- if (!itemstack.isEmpty() && itemstack.is(item) && Inventory.isUsableForCrafting(itemstack)) { -+ if (!itemstack.isEmpty() && item.matches(itemstack) && (!(item instanceof io.papermc.paper.inventory.recipe.ItemOrExact.Item) || isUsableForCrafting(itemstack))) { // Paper - Improve exact choice recipe ingredients +- if (!itemstack1.isEmpty() && itemstack1.is(item) && Inventory.isUsableForCrafting(itemstack1) && (stack.isEmpty() || ItemStack.isSameItemSameComponents(stack, itemstack1))) { ++ if (!itemstack1.isEmpty() && item.matches(itemstack1) && (!(item instanceof io.papermc.paper.inventory.recipe.ItemOrExact.Item) || Inventory.isUsableForCrafting(itemstack1)) && (stack.isEmpty() || ItemStack.isSameItemSameComponents(stack, itemstack1))) { // Paper - Improve exact choice recipe ingredients return i; } } diff --git a/src/main/java/net/minecraft/world/entity/player/StackedContents.java b/src/main/java/net/minecraft/world/entity/player/StackedContents.java -index 3bc7c9b3df5547c6564696fce67417c96ffdebf9..9ad3c4510f0e0530dfbbc3ba7e6d19b7678e1294 100644 +index b645962fbcebf937a477dc5c94d96be998a84105..f5d737d8a1ad10df8a74c11a6f6394ed0d2ca8be 100644 --- a/src/main/java/net/minecraft/world/entity/player/StackedContents.java +++ b/src/main/java/net/minecraft/world/entity/player/StackedContents.java -@@ -10,7 +10,7 @@ import java.util.Set; +@@ -13,7 +13,7 @@ import java.util.List; import javax.annotation.Nullable; public class StackedContents { - public final Reference2IntOpenHashMap amounts = new Reference2IntOpenHashMap<>(); + public final it.unimi.dsi.fastutil.objects.Object2IntOpenHashMap amounts = new it.unimi.dsi.fastutil.objects.Object2IntOpenHashMap<>(); // Paper - Improve exact choice recipe ingredients (don't use "reference" map) - boolean hasAnyAmount(T input) { - return this.amounts.getInt(input) > 0; -@@ -47,12 +47,13 @@ public class StackedContents { - this.put(input, count); - } + boolean hasAtLeast(T input, int minimum) { + return this.amounts.getInt(input) >= minimum; +@@ -49,7 +49,7 @@ public class StackedContents { + List getUniqueAvailableIngredientItems(Iterable> ingredients) { + List list = new ArrayList<>(); -- public static record IngredientInfo(List allowedItems) { -- public IngredientInfo(List allowedItems) { -+ public static record IngredientInfo(List allowedItems, boolean isExact) { // Paper - Improve exact choice recipe ingredients -+ public IngredientInfo(List allowedItems, boolean isExact) { // Paper - Improve exact choice recipe ingredients - if (allowedItems.isEmpty()) { - throw new IllegalArgumentException("Ingredients can't be empty"); - } else { - this.allowedItems = allowedItems; -+ this.isExact = isExact; // Paper - Improve exact choice recipe ingredients +- for (Entry entry : Reference2IntMaps.fastIterable(this.amounts)) { ++ for (it.unimi.dsi.fastutil.objects.Object2IntMap.Entry entry : it.unimi.dsi.fastutil.objects.Object2IntMaps.fastIterable(this.amounts)) { // Paper - Improve exact choice recipe ingredients (don't use "reference" map) + if (entry.getIntValue() > 0 && anyIngredientMatches(ingredients, entry.getKey())) { + list.add(entry.getKey()); } - } - } +@@ -71,13 +71,13 @@ public class StackedContents { + @VisibleForTesting + public int getResultUpperBound(List> ingredients) { + int i = Integer.MAX_VALUE; +- ObjectIterable> objectIterable = Reference2IntMaps.fastIterable(this.amounts); ++ ObjectIterable> objectIterable = it.unimi.dsi.fastutil.objects.Object2IntMaps.fastIterable(this.amounts); // Paper - Improve exact choice recipe ingredients (don't use "reference" map) + + label31: + for (StackedContents.IngredientInfo ingredientInfo : ingredients) { + int j = 0; + +- for (Entry entry : objectIterable) { ++ for (it.unimi.dsi.fastutil.objects.Object2IntMap.Entry entry : objectIterable) { // Paper - Improve exact choice recipe ingredients (don't use "reference" map) + int k = entry.getIntValue(); + if (k > j) { + if (ingredientInfo.acceptsItem(entry.getKey())) { diff --git a/src/main/java/net/minecraft/world/entity/player/StackedItemContents.java b/src/main/java/net/minecraft/world/entity/player/StackedItemContents.java -index cc6c5cf0d1034ed074b6c354c307a0c2613f85c7..3f075c5c12f7ce331200fddb1b6602380d6f5f3e 100644 +index 9436fb2bfc5f4463bd958c7cbf8d700dbf819890..209ddab9e96169fe4be373b2f6f289cf06f08537 100644 --- a/src/main/java/net/minecraft/world/entity/player/StackedItemContents.java +++ b/src/main/java/net/minecraft/world/entity/player/StackedItemContents.java -@@ -12,9 +12,14 @@ import net.minecraft.world.item.crafting.PlacementInfo; +@@ -9,9 +9,14 @@ import net.minecraft.world.item.crafting.PlacementInfo; import net.minecraft.world.item.crafting.Recipe; public class StackedItemContents { @@ -262,7 +284,7 @@ index cc6c5cf0d1034ed074b6c354c307a0c2613f85c7..3f075c5c12f7ce331200fddb1b660238 if (Inventory.isUsableForCrafting(item)) { this.accountStack(item); } -@@ -27,39 +32,56 @@ public class StackedItemContents { +@@ -24,36 +29,53 @@ public class StackedItemContents { public void accountStack(ItemStack item, int maxCount) { if (!item.isEmpty()) { int i = Math.min(maxCount, item.getCount()); @@ -272,9 +294,7 @@ index cc6c5cf0d1034ed074b6c354c307a0c2613f85c7..3f075c5c12f7ce331200fddb1b660238 } } -- public static StackedContents.IngredientInfo> convertIngredientContents(Stream> items) { -- List> list = items.sorted(Comparator.comparingInt(item -> BuiltInRegistries.ITEM.getId(item.value()))).toList(); -- return new StackedContents.IngredientInfo<>(list); +- public boolean canCraft(Recipe recipe, @Nullable StackedContents.Output> itemCallback) { + // Paper start - Improve exact choice recipe ingredients + public void initializeExtras(final Recipe recipe, @Nullable final net.minecraft.world.item.crafting.CraftingInput input) { + if (this.extrasMap == null) { @@ -289,14 +309,8 @@ index cc6c5cf0d1034ed074b6c354c307a0c2613f85c7..3f075c5c12f7ce331200fddb1b660238 + this.extrasMap.resetExtras(); + } + } ++ // Paper end - Improve exact choice recipe ingredients + -+ public static StackedContents.IngredientInfo convertIngredientContents(Stream items, boolean isExact) { -+ List list = items.sorted(Comparator.comparingInt(item -> isExact ? ItemStack.hashItemAndComponents(((io.papermc.paper.inventory.recipe.ItemOrExact.Exact) item).stack()) : BuiltInRegistries.ITEM.getId(((io.papermc.paper.inventory.recipe.ItemOrExact.Item) item).item().value()))).toList(); -+ return new StackedContents.IngredientInfo<>(list, isExact); -+ // Paper end - Improve exact choice recipe ingredients - } - -- public boolean canCraft(Recipe recipe, @Nullable StackedContents.Output> itemCallback) { + public boolean canCraft(Recipe recipe, @Nullable StackedContents.Output itemCallback) { // Paper - Improve exact choice recipe ingredients return this.canCraft(recipe, 1, itemCallback); } @@ -304,17 +318,19 @@ index cc6c5cf0d1034ed074b6c354c307a0c2613f85c7..3f075c5c12f7ce331200fddb1b660238 - public boolean canCraft(Recipe recipe, int quantity, @Nullable StackedContents.Output> itemCallback) { + public boolean canCraft(Recipe recipe, int quantity, @Nullable StackedContents.Output itemCallback) { // Paper - Improve exact choice recipe ingredients PlacementInfo placementInfo = recipe.placementInfo(); - return !placementInfo.isImpossibleToPlace() && this.canCraft(placementInfo.unpackedIngredients(), quantity, itemCallback); + return !placementInfo.isImpossibleToPlace() && this.canCraft(placementInfo.ingredients(), quantity, itemCallback); } -- public boolean canCraft(List>> rawIngredients, @Nullable StackedContents.Output> itemCallback) { -+ public boolean canCraft(List> rawIngredients, @Nullable StackedContents.Output itemCallback) { // Paper - Improve exact choice recipe ingredients + public boolean canCraft( +- List>> rawIngredients, @Nullable StackedContents.Output> itemCallback ++ List> rawIngredients, @Nullable StackedContents.Output itemCallback // Paper - Improve exact choice recipe ingredients + ) { return this.canCraft(rawIngredients, 1, itemCallback); } private boolean canCraft( -- List>> rawIngredients, int quantity, @Nullable StackedContents.Output> itemCallback -+ List> rawIngredients, int quantity, @Nullable StackedContents.Output itemCallback // Paper - Improve exact choice recipe ingredients +- List>> rawIngredients, int quantity, @Nullable StackedContents.Output> itemCallback ++ List> rawIngredients, int quantity, @Nullable StackedContents.Output itemCallback // Paper - Improve exact choice recipe ingredients ) { return this.raw.tryPick(rawIngredients, quantity, itemCallback); } @@ -326,14 +342,82 @@ index cc6c5cf0d1034ed074b6c354c307a0c2613f85c7..3f075c5c12f7ce331200fddb1b660238 - public int getBiggestCraftableStack(Recipe recipe, int max, @Nullable StackedContents.Output> itemCallback) { + public int getBiggestCraftableStack(Recipe recipe, int max, @Nullable StackedContents.Output itemCallback) { // Paper - Improve exact choice recipe ingredients - return this.raw.tryPickAll(recipe.placementInfo().unpackedIngredients(), max, itemCallback); + return this.raw.tryPickAll(recipe.placementInfo().ingredients(), max, itemCallback); } diff --git a/src/main/java/net/minecraft/world/item/crafting/Ingredient.java b/src/main/java/net/minecraft/world/item/crafting/Ingredient.java -index 2dce801e06687c218be3333ac9f000bae09f0caf..812f919a7a7e309c8513f44104f092496037608f 100644 +index 0bd0935e76038e07c063bbfc61fa1a6339c23eed..0b0054b3d5d56ba24e1aee0e3ab56ea5b01a82a8 100644 --- a/src/main/java/net/minecraft/world/item/crafting/Ingredient.java +++ b/src/main/java/net/minecraft/world/item/crafting/Ingredient.java -@@ -139,6 +139,11 @@ public final class Ingredient implements Predicate { +@@ -25,7 +25,7 @@ import java.util.List; + import javax.annotation.Nullable; + // CraftBukkit end + +-public final class Ingredient implements StackedContents.IngredientInfo>, Predicate { ++public final class Ingredient implements StackedContents.IngredientInfo, Predicate { // Paper - Improve exact choice recipe ingredients + + public static final StreamCodec CONTENTS_STREAM_CODEC = ByteBufCodecs.holderSet(Registries.ITEM).map(Ingredient::new, (recipeitemstack) -> { + return recipeitemstack.values; +@@ -44,19 +44,23 @@ public final class Ingredient implements StackedContents.IngredientInfo values; + // CraftBukkit start + @Nullable +- private List itemStacks; ++ private java.util.Set itemStacks; // Paper - Improve exact choice recipe ingredients + + public boolean isExact() { + return this.itemStacks != null; + } + +- public List itemStacks() { ++ public java.util.Set itemStacks() { // Paper - Improve exact choice recipe ingredients + return this.itemStacks; + } + + public static Ingredient ofStacks(List stacks) { + Ingredient recipe = Ingredient.of(stacks.stream().map(ItemStack::getItem)); +- recipe.itemStacks = stacks; ++ // Paper start - Improve exact choice recipe ingredients ++ recipe.itemStacks = net.minecraft.world.item.ItemStackLinkedSet.createTypeAndComponentsSet(); ++ recipe.itemStacks.addAll(stacks); ++ recipe.itemStacks = java.util.Collections.unmodifiableSet(recipe.itemStacks); ++ // Paper end - Improve exact choice recipe ingredients + return recipe; + } + // CraftBukkit end +@@ -94,20 +98,22 @@ public final class Ingredient implements StackedContents.IngredientInfo holder) { +- return this.values.contains(holder); ++ // Paper start - Improve exact choice recipe ingredients ++ @Override ++ public boolean acceptsItem(final io.papermc.paper.inventory.recipe.ItemOrExact holder) { ++ return switch (holder) { ++ case io.papermc.paper.inventory.recipe.ItemOrExact.Item(final Holder item) -> ++ !this.isExact() && this.values.contains(item); ++ case io.papermc.paper.inventory.recipe.ItemOrExact.Exact(final ItemStack exact) -> ++ this.isExact() && this.itemStacks.contains(exact); ++ }; ++ // Paper end - Improve exact choice recipe ingredients + } + + public boolean equals(Object object) { +@@ -137,6 +143,11 @@ public final class Ingredient implements StackedContents.IngredientInfo { return new SlotDisplay.Composite(list.stream().map(Ingredient::displayForSingleItem).toList()); }); -diff --git a/src/main/java/net/minecraft/world/item/crafting/PlacementInfo.java b/src/main/java/net/minecraft/world/item/crafting/PlacementInfo.java -index 43124a000f48e243d75df64051fbda816035af25..400fd1cdfd17d4d34552f9bb3d91bc71fd394301 100644 ---- a/src/main/java/net/minecraft/world/item/crafting/PlacementInfo.java -+++ b/src/main/java/net/minecraft/world/item/crafting/PlacementInfo.java -@@ -11,26 +11,28 @@ import net.minecraft.world.item.Item; - public class PlacementInfo { - public static final PlacementInfo NOT_PLACEABLE = new PlacementInfo(List.of(), List.of(), List.of()); - private final List ingredients; -- private final List>> unpackedIngredients; -+ private final List> unpackedIngredients; // Paper - Improve exact choice recipe ingredients - private final List> slotInfo; - - private PlacementInfo( -- List ingredients, List>> rawIngredients, List> placementSlots -+ List ingredients, List> rawIngredients, List> placementSlots // Paper - Improve exact choice recipe ingredients - ) { - this.ingredients = ingredients; - this.unpackedIngredients = rawIngredients; - this.slotInfo = placementSlots; - } - -- public static StackedContents.IngredientInfo> ingredientToContents(Ingredient ingredient) { -- return StackedItemContents.convertIngredientContents(ingredient.items().stream()); -+ // Paper start - Improve exact choice recipe ingredients -+ public static StackedContents.IngredientInfo ingredientToContents(Ingredient ingredient) { -+ return StackedItemContents.convertIngredientContents(ingredient.isExact() ? ingredient.itemStacks().stream().map(io.papermc.paper.inventory.recipe.ItemOrExact.Exact::new) : ingredient.items().stream().map(io.papermc.paper.inventory.recipe.ItemOrExact.Item::new), ingredient.isExact()); -+ // Paper end - Improve exact choice recipe ingredients - } - - public static PlacementInfo create(Ingredient ingredient) { - if (ingredient.items().isEmpty()) { - return NOT_PLACEABLE; - } else { -- StackedContents.IngredientInfo> ingredientInfo = ingredientToContents(ingredient); -+ StackedContents.IngredientInfo ingredientInfo = ingredientToContents(ingredient); // Paper - Improve exact choice recipe ingredients - PlacementInfo.SlotInfo slotInfo = new PlacementInfo.SlotInfo(0); - return new PlacementInfo(List.of(ingredient), List.of(ingredientInfo), List.of(Optional.of(slotInfo))); - } -@@ -39,7 +41,7 @@ public class PlacementInfo { - public static PlacementInfo createFromOptionals(List> ingredients) { - int i = ingredients.size(); - List list = new ArrayList<>(i); -- List>> list2 = new ArrayList<>(i); -+ List> list2 = new ArrayList<>(i); // Paper - Improve exact choice recipe ingredients - List> list3 = new ArrayList<>(i); - int j = 0; - -@@ -63,7 +65,7 @@ public class PlacementInfo { - - public static PlacementInfo create(List ingredients) { - int i = ingredients.size(); -- List>> list = new ArrayList<>(i); -+ List> list = new ArrayList<>(i); // Paper - Improve exact choice recipe ingredients - List> list2 = new ArrayList<>(i); - - for (int j = 0; j < i; j++) { -@@ -87,7 +89,7 @@ public class PlacementInfo { - return this.ingredients; - } - -- public List>> unpackedIngredients() { -+ public List> unpackedIngredients() { // Paper - Improve exact choice recipe ingredients - return this.unpackedIngredients; - } - diff --git a/src/main/java/net/minecraft/world/item/crafting/ShapelessRecipe.java b/src/main/java/net/minecraft/world/item/crafting/ShapelessRecipe.java index 6ec7b234b468755835107be40d0080222c0b9263..12f95bee2a69fd5df7c4a165537e01299e60c5f6 100644 --- a/src/main/java/net/minecraft/world/item/crafting/ShapelessRecipe.java