mirror of
https://github.com/PaperMC/Paper.git
synced 2025-02-22 04:33:28 +01:00
Deprecate for removal Block#isValidTool (#11439)
The method's implementation uses Block#getDrops which re-computes the drops from the loot table each call leading to isValidTool returning different values with subsequent calls.
This commit is contained in:
parent
fb91090522
commit
ddd068d513
1 changed files with 10 additions and 5 deletions
|
@ -3,24 +3,29 @@ From: Jake Potrebic <jake.m.potrebic@gmail.com>
|
||||||
Date: Mon, 6 Jul 2020 12:44:23 -0700
|
Date: Mon, 6 Jul 2020 12:44:23 -0700
|
||||||
Subject: [PATCH] Add Block#isValidTool
|
Subject: [PATCH] Add Block#isValidTool
|
||||||
|
|
||||||
|
Deprecated for removal
|
||||||
|
|
||||||
diff --git a/src/main/java/org/bukkit/block/Block.java b/src/main/java/org/bukkit/block/Block.java
|
diff --git a/src/main/java/org/bukkit/block/Block.java b/src/main/java/org/bukkit/block/Block.java
|
||||||
index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644
|
index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644
|
||||||
--- a/src/main/java/org/bukkit/block/Block.java
|
--- a/src/main/java/org/bukkit/block/Block.java
|
||||||
+++ b/src/main/java/org/bukkit/block/Block.java
|
+++ b/src/main/java/org/bukkit/block/Block.java
|
||||||
@@ -0,0 +0,0 @@ public interface Block extends Metadatable, Translatable, net.kyori.adventure.tr
|
@@ -0,0 +0,0 @@ public interface Block extends Metadatable, Translatable, net.kyori.adventure.tr
|
||||||
public static int getBlockKeyZ(long packed) {
|
|
||||||
return (int) ((packed << 10) >> 37);
|
|
||||||
}
|
}
|
||||||
+
|
// Paper end
|
||||||
|
|
||||||
|
+ // Paper start - add isValidTool
|
||||||
+ /**
|
+ /**
|
||||||
+ * Checks if the itemstack is a valid tool to
|
+ * Checks if the itemstack is a valid tool to
|
||||||
+ * break the block with
|
+ * break the block with
|
||||||
+ *
|
+ *
|
||||||
+ * @param itemStack The (tool) itemstack
|
+ * @param itemStack The (tool) itemstack
|
||||||
+ * @return whether the block will drop items
|
+ * @return whether the block will drop items
|
||||||
|
+ * @deprecated partially replaced by {@link Block#isPreferredTool(ItemStack)}
|
||||||
+ */
|
+ */
|
||||||
|
+ @Deprecated(since = "1.21", forRemoval = true) // Paper
|
||||||
+ boolean isValidTool(@NotNull ItemStack itemStack);
|
+ boolean isValidTool(@NotNull ItemStack itemStack);
|
||||||
// Paper end
|
+ // Paper end - add isValidTool
|
||||||
|
+
|
||||||
/**
|
/**
|
||||||
|
* Gets the Location of the block
|
||||||
|
*
|
||||||
|
|
Loading…
Add table
Reference in a new issue