#1233: Remove some old MC bug fixes now fixed in vanilla

By: Owen1212055 <23108066+Owen1212055@users.noreply.github.com>

paper-server/nms-patches/net/minecraft/world/entity/animal/EntityDolphin.patch

@@ -42,15 +42,6 @@
                  this.onItemPickup(entityitem);
                  this.setItemSlot(EnumItemSlot.MAINHAND, itemstack);
                  this.setGuaranteedDrop(EnumItemSlot.MAINHAND);
-@@ -389,7 +406,7 @@
- 
-         @Override
-         public boolean canUse() {
--            return this.dolphin.gotFish() && this.dolphin.getAirSupply() >= 100;
-+            return this.dolphin.gotFish() && this.dolphin.getAirSupply() >= 100 && this.dolphin.level().getWorld().canGenerateStructures(); // MC-151364, SPIGOT-5494: hangs if generate-structures=false
-         }
- 
-         @Override
 @@ -489,7 +506,7 @@
  
          @Override

paper-server/nms-patches/net/minecraft/world/item/ItemCrossbow.patch

@@ -1,17 +1,6 @@
 --- a/net/minecraft/world/item/ItemCrossbow.java
 +++ b/net/minecraft/world/item/ItemCrossbow.java
-@@ -113,6 +113,10 @@
+@@ -236,11 +236,27 @@
-             if (itemstack1.isEmpty() && flag) {
-                 itemstack1 = new ItemStack(Items.ARROW);
-                 itemstack2 = itemstack1.copy();
-+                // CraftBukkit start - SPIGOT-4870, MC-150847
-+            } else if (itemstack1.isEmpty()) {
-+                return false;
-+                // CraftBukkit end
-             }
- 
-             if (!loadProjectile(entityliving, itemstack, itemstack1, k > 0, flag)) {
-@@ -236,11 +240,27 @@
  
                  ((IProjectile) object).shoot((double) vector3f.x(), (double) vector3f.y(), (double) vector3f.z(), f1, f2);
              }