1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2025-01-18 23:23:19 +01:00

Hide unnecessary decorated pot data ()

Prevent decorated pots from sending their contents to clients as
contents are not needed for rendering.
This commit is contained in:
Bjarne Koll 2025-01-12 17:49:49 +01:00 committed by GitHub
parent 9746d73ade
commit e5542cfdc3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -49,3 +49,28 @@
public static final String TAG_SHERDS = "sherds";
public static final String TAG_ITEM = "item";
public static final int EVENT_POT_WOBBLES = 1;
@@ -41,8 +_,8 @@
protected void saveAdditional(CompoundTag tag, HolderLookup.Provider registries) {
super.saveAdditional(tag, registries);
this.decorations.save(tag);
- if (!this.trySaveLootTable(tag) && !this.item.isEmpty()) {
- tag.put("item", this.item.save(registries));
+ if (!this.trySaveLootTable(tag) && !this.item.isEmpty()) { // Paper - diff on change - hide unnecessary update data
+ tag.put("item", this.item.save(registries)); // Paper - diff on change - hide unnecessary update data
}
}
@@ -66,7 +_,12 @@
@Override
public CompoundTag getUpdateTag(HolderLookup.Provider registries) {
- return this.saveCustomOnly(registries);
+ // Paper start - hide unnecessary update data
+ // Like chests, decorated pots should not allow clients to inspect their contents without breaking them.
+ final CompoundTag compoundTag = new CompoundTag();
+ this.decorations.save(compoundTag);
+ return compoundTag;
+ // Paper end - hide unnecessary update data
}
public Direction getDirection() {