mirror of
https://github.com/PaperMC/Paper.git
synced 2025-03-22 15:05:35 +01:00
address compile and test issue (#10890)
This commit is contained in:
parent
f63023a6ac
commit
f594b47eda
5 changed files with 35 additions and 5 deletions
|
@ -2827,5 +2827,5 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000
|
||||||
- final org.bukkit.plugin.PluginManager pluginManager = new io.papermc.paper.plugin.manager.PaperPluginManagerImpl(instance, new org.bukkit.command.SimpleCommandMap(instance), null);
|
- final org.bukkit.plugin.PluginManager pluginManager = new io.papermc.paper.plugin.manager.PaperPluginManagerImpl(instance, new org.bukkit.command.SimpleCommandMap(instance), null);
|
||||||
+ final org.bukkit.plugin.PluginManager pluginManager = new io.papermc.paper.plugin.manager.PaperPluginManagerImpl(instance, new org.bukkit.command.SimpleCommandMap(instance, new java.util.HashMap<>()), null); // Paper
|
+ final org.bukkit.plugin.PluginManager pluginManager = new io.papermc.paper.plugin.manager.PaperPluginManagerImpl(instance, new org.bukkit.command.SimpleCommandMap(instance, new java.util.HashMap<>()), null); // Paper
|
||||||
when(instance.getPluginManager()).thenReturn(pluginManager);
|
when(instance.getPluginManager()).thenReturn(pluginManager);
|
||||||
when(instance.getTag(anyString(), any(org.bukkit.NamespacedKey.class), any())).thenAnswer(ignored -> new io.papermc.paper.util.EmptyTag());
|
|
||||||
// paper end - testing additions
|
// paper end - testing additions
|
||||||
|
|
||||||
|
|
|
@ -100,7 +100,7 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000
|
||||||
--- a/src/test/java/org/bukkit/support/DummyServer.java
|
--- a/src/test/java/org/bukkit/support/DummyServer.java
|
||||||
+++ b/src/test/java/org/bukkit/support/DummyServer.java
|
+++ b/src/test/java/org/bukkit/support/DummyServer.java
|
||||||
@@ -0,0 +0,0 @@ public final class DummyServer {
|
@@ -0,0 +0,0 @@ public final class DummyServer {
|
||||||
when(instance.getTag(anyString(), any(org.bukkit.NamespacedKey.class), any())).thenAnswer(ignored -> new io.papermc.paper.util.EmptyTag());
|
when(instance.getPluginManager()).thenReturn(pluginManager);
|
||||||
// paper end - testing additions
|
// paper end - testing additions
|
||||||
|
|
||||||
+ // Paper start - add test for recipe conversion
|
+ // Paper start - add test for recipe conversion
|
||||||
|
|
|
@ -8161,5 +8161,5 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000
|
||||||
- final org.bukkit.plugin.PluginManager pluginManager = new org.bukkit.plugin.SimplePluginManager(instance, new org.bukkit.command.SimpleCommandMap(instance));
|
- final org.bukkit.plugin.PluginManager pluginManager = new org.bukkit.plugin.SimplePluginManager(instance, new org.bukkit.command.SimpleCommandMap(instance));
|
||||||
+ final org.bukkit.plugin.PluginManager pluginManager = new io.papermc.paper.plugin.manager.PaperPluginManagerImpl(instance, new org.bukkit.command.SimpleCommandMap(instance), null);
|
+ final org.bukkit.plugin.PluginManager pluginManager = new io.papermc.paper.plugin.manager.PaperPluginManagerImpl(instance, new org.bukkit.command.SimpleCommandMap(instance), null);
|
||||||
when(instance.getPluginManager()).thenReturn(pluginManager);
|
when(instance.getPluginManager()).thenReturn(pluginManager);
|
||||||
when(instance.getTag(anyString(), any(org.bukkit.NamespacedKey.class), any())).thenAnswer(ignored -> new io.papermc.paper.util.EmptyTag());
|
|
||||||
// paper end - testing additions
|
// paper end - testing additions
|
||||||
|
|
||||||
|
|
|
@ -3,6 +3,7 @@ From: Jake Potrebic <jake.m.potrebic@gmail.com>
|
||||||
Date: Mon, 13 Feb 2023 14:14:56 -0800
|
Date: Mon, 13 Feb 2023 14:14:56 -0800
|
||||||
Subject: [PATCH] Test changes
|
Subject: [PATCH] Test changes
|
||||||
|
|
||||||
|
Co-authored-by: yannnicklamprecht <yannicklamprecht@live.de>
|
||||||
|
|
||||||
diff --git a/build.gradle.kts b/build.gradle.kts
|
diff --git a/build.gradle.kts b/build.gradle.kts
|
||||||
index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644
|
index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644
|
||||||
|
@ -355,6 +356,36 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000
|
||||||
--- a/src/test/java/org/bukkit/support/DummyServer.java
|
--- a/src/test/java/org/bukkit/support/DummyServer.java
|
||||||
+++ b/src/test/java/org/bukkit/support/DummyServer.java
|
+++ b/src/test/java/org/bukkit/support/DummyServer.java
|
||||||
@@ -0,0 +0,0 @@ public final class DummyServer {
|
@@ -0,0 +0,0 @@ public final class DummyServer {
|
||||||
|
when(instance.getTag(any(), any(), any())).then(mock -> {
|
||||||
|
String registry = mock.getArgument(0);
|
||||||
|
Class<?> clazz = mock.getArgument(2);
|
||||||
|
- MinecraftKey key = CraftNamespacedKey.toMinecraft(mock.getArgument(1));
|
||||||
|
+ net.minecraft.resources.ResourceLocation key = CraftNamespacedKey.toMinecraft(mock.getArgument(1)); // Paper - address remapping issues
|
||||||
|
|
||||||
|
switch (registry) {
|
||||||
|
case org.bukkit.Tag.REGISTRY_BLOCKS -> {
|
||||||
|
@@ -0,0 +0,0 @@ public final class DummyServer {
|
||||||
|
}
|
||||||
|
case org.bukkit.Tag.REGISTRY_FLUIDS -> {
|
||||||
|
Preconditions.checkArgument(clazz == org.bukkit.Fluid.class, "Fluid namespace must have fluid type");
|
||||||
|
- TagKey<FluidType> fluidTagKey = TagKey.create(Registries.FLUID, key);
|
||||||
|
+ TagKey<net.minecraft.world.level.material.Fluid> fluidTagKey = TagKey.create(Registries.FLUID, key); // Paper - address remapping issues
|
||||||
|
if (BuiltInRegistries.FLUID.getTag(fluidTagKey).isPresent()) {
|
||||||
|
return new CraftFluidTag(BuiltInRegistries.FLUID, fluidTagKey);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
case org.bukkit.Tag.REGISTRY_ENTITY_TYPES -> {
|
||||||
|
Preconditions.checkArgument(clazz == org.bukkit.entity.EntityType.class, "Entity type namespace must have entity type");
|
||||||
|
- TagKey<EntityTypes<?>> entityTagKey = TagKey.create(Registries.ENTITY_TYPE, key);
|
||||||
|
+ TagKey<net.minecraft.world.entity.EntityType<?>> entityTagKey = TagKey.create(Registries.ENTITY_TYPE, key); // Paper - address remapping issues
|
||||||
|
if (BuiltInRegistries.ENTITY_TYPE.getTag(entityTagKey).isPresent()) {
|
||||||
|
return new CraftEntityTag(BuiltInRegistries.ENTITY_TYPE, entityTagKey);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
- default -> throw new IllegalArgumentException();
|
||||||
|
+ default -> new io.papermc.paper.util.EmptyTag(); // Paper - testing additions
|
||||||
|
}
|
||||||
|
|
||||||
return null;
|
return null;
|
||||||
});
|
});
|
||||||
|
|
||||||
|
@ -364,7 +395,6 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000
|
||||||
+
|
+
|
||||||
+ final org.bukkit.plugin.PluginManager pluginManager = new org.bukkit.plugin.SimplePluginManager(instance, new org.bukkit.command.SimpleCommandMap(instance));
|
+ final org.bukkit.plugin.PluginManager pluginManager = new org.bukkit.plugin.SimplePluginManager(instance, new org.bukkit.command.SimpleCommandMap(instance));
|
||||||
+ when(instance.getPluginManager()).thenReturn(pluginManager);
|
+ when(instance.getPluginManager()).thenReturn(pluginManager);
|
||||||
+ when(instance.getTag(anyString(), any(org.bukkit.NamespacedKey.class), any())).thenAnswer(ignored -> new io.papermc.paper.util.EmptyTag());
|
|
||||||
+ // paper end - testing additions
|
+ // paper end - testing additions
|
||||||
+
|
+
|
||||||
Bukkit.setServer(instance);
|
Bukkit.setServer(instance);
|
||||||
|
|
|
@ -808,7 +808,7 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000
|
||||||
+ public void checkAllMetasHaveHandledTags() {
|
+ public void checkAllMetasHaveHandledTags() {
|
||||||
+ try (final ScanResult result = new ClassGraph()
|
+ try (final ScanResult result = new ClassGraph()
|
||||||
+ .whitelistPackages("org.bukkit.craftbukkit.inventory")
|
+ .whitelistPackages("org.bukkit.craftbukkit.inventory")
|
||||||
+ .enableAllInfo().scan()) {
|
+ .enableClassInfo().scan()) {
|
||||||
+ final ClassInfoList subclasses = result.getSubclasses(CraftMetaItem.class.getName());
|
+ final ClassInfoList subclasses = result.getSubclasses(CraftMetaItem.class.getName());
|
||||||
+ assertFalse(subclasses.isEmpty(), "found 0 sub types");
|
+ assertFalse(subclasses.isEmpty(), "found 0 sub types");
|
||||||
+ for (final ClassInfo subclass : subclasses) {
|
+ for (final ClassInfo subclass : subclasses) {
|
||||||
|
|
Loading…
Add table
Reference in a new issue