OpenSource/PaperMC

3198 commits 46 branches 0 tags 289 MiB

Author	SHA1	Message	Date
Minecrell	81688d28d2	Avoid Netty buffer leak in LegacyPingHandler. Fixes #1200 (#1201 ) The extra buffer used to decode the strings sent by the client in the legacy ping protocol was never released. However, creating an extra copy of the buffer just to decode it to a string isn't actually necessary: We can just call toString() directly on the original buffer. Additionally, free the buffer in handlerRemoved() to handle cases where the client never sends enough bytes to form a valid legacy ping request.	2018-07-13 02:43:56 -05:00

Author

SHA1

Message

Date

Minecrell

81688d28d2

Avoid Netty buffer leak in LegacyPingHandler. Fixes #1200 (#1201 )

The extra buffer used to decode the strings sent by the client
in the legacy ping protocol was never released. However, creating
an extra copy of the buffer just to decode it to a string isn't
actually necessary: We can just call toString() directly on the
original buffer.

Additionally, free the buffer in handlerRemoved() to handle cases
where the client never sends enough bytes to form a valid legacy
ping request.

2018-07-13 02:43:56 -05:00

Renamed from Spigot-Server-Patches/0284-Make-the-legacy-ping-handler-more-reliable.patch (Browse further)

1 commit