Commit graph

1079 commits

Author SHA1 Message Date
Spigot
1180c5cc83 Upstream merge
By: md_5 <git@md-5.net>
2014-01-15 20:28:26 +11:00
Spigot
e4f2987e65 Move replace-commands to commands.replace-commands
By: Thinkofdeath <thethinkofdeath@gmail.com>
2014-01-15 09:20:19 +00:00
Spigot
b5cf4ed39d Fix ConcurrentModificationException while being idle kicked in a vehicle
By: Thinkofdeath <thethinkofdeath@gmail.com>
2014-01-14 20:14:36 +00:00
Spigot
cd2ca0fee0 Revert previous change to clear chunk list on the end of each tick, make it configurable instead.
Whilst the new behaviour was technically correct as it prevented the possibility of the chunk tick list actually increasing over time, it introduced a few issues, namely the fact that it slowed growth to unreasonable levels, and interfered with the values which server admins have finally tuned, and come to enjoy over the last few years.
If it is absolutely essential that growth be halted and ticking reduced as much as possible, the config option is there for power users.
If we wish to 'fix' this by default in the future, a new chunk ticking algorithm, which actually has meaningful config options should be designed.

By: md_5 <git@md-5.net>
2014-01-14 19:16:43 +11:00
Spigot
7cc82556e3 Tweak tab complete disabled to only disable completion of the /command section, and not any subsequent arguments to the command, such as player names or plugin provided completions.
By: md_5 <git@md-5.net>
2014-01-13 08:57:22 +11:00
Spigot
25cedf3056 Remove accidentally added code
By: md_5 <git@md-5.net>
2014-01-13 08:28:17 +11:00
Spigot
c264381f25 Replace AutoSave Mechanism
The problem here is that MinecraftServer.save(..), will attempt to sleep whilst all pending chunks are written to disk, however due to various and complicated bugs, it will wait for an incorrect amount of chunks, which may cause it to sleep for an overly long amount of time. Instead we will mimic the save-all command in its behaviour, which is both safe and performant.

By: md_5 <git@md-5.net>
2014-01-12 21:07:27 +11:00
Spigot
a15ec9e415 Add more code to try and Debug [Mojang] Crash Reports Crashing
By: md_5 <git@md-5.net>
2014-01-12 20:56:59 +11:00
Spigot
bfbfa6fc75 Take 2 at fixing unbreakable code
By: md_5 <git@md-5.net>
2014-01-10 15:39:36 +11:00
Spigot
e5cfd144eb Fix ItemStack Unbreakable Code.
This code needs brackets to be compiled correctly.

By: md_5 <git@md-5.net>
2014-01-10 15:16:18 +11:00
Spigot
63e137c5f0 Fix anvil collisions
This fixes the server incorrectly moving the player out of an anvil when touching it on the side. The server used the rotation of the last placed anvil instead the of the rotation of the anvil the player was touching.

By: Thinkofdeath <thethinkofdeath@gmail.com>
2014-01-09 14:28:04 +00:00
Spigot
34acf177c9 Allow statistics to be disabled/forced
By: Thinkofdeath <thethinkofdeath@gmail.com>
2014-01-08 22:00:00 +00:00
Spigot
1bd8195a1b Update Client's Hand when BlockPlaceEvent Cancelled
Send a Packet103SetSlot to client when a BlockPlaceEvent is cancelled.

Fixes BUKKIT-5284

Currently, whenever a player places a block in a protected area the
equipped itemstack size on client is never updated properly since the
client thinks the block was placed. The reason this happens is because
ItemStack.matches returns true since the server does not decrement stack
size if a BlockPlaceEvent is cancelled. This causes
PlayerConnection.a(handlePlace) not to send the appropriate packet to
client which causes the bug.

By: md_5 <git@md-5.net>
2014-01-08 14:45:45 +11:00
Spigot
26ba98c875 Update Chest Animation when Cancelling Event
Update chest animation after cancelling InventoryOpenEvent. Fixes BUKKIT-1440

Currently if a plugin cancels an InventoryOpenEvent for vanilla chests,
the chest animation for clients is stuck in the open state since
IInventory's closeChest method is never called. To fix the issue, closeChest
is called before exiting the display GUI method.
More info can be found here
https://bukkit.atlassian.net/browse/BUKKIT-1440

By: md_5 <git@md-5.net>
2014-01-08 14:44:50 +11:00
Spigot
e25e9553b1 Clear chunkTickList at the end of every tick.
By: md_5 <git@md-5.net>
2014-01-08 14:38:38 +11:00
Spigot
a7ba50b65d Fix orebfuscator startup message showing hide blocks instead of replace blocks
By: md_5 <git@md-5.net>
2014-01-06 11:38:59 +11:00
Spigot
a3160ad8a5 Fix Biome Decoration Crashes
We don't really know what affect this will have on the terrain generation, but its better than crashing and not having terrain generate at all!

By: md_5 <git@md-5.net>
2014-01-05 09:35:15 +11:00
Spigot
5974c1d8e1 Disconnect for spam in the main thread
By: Thinkofdeath <thethinkofdeath@gmail.com>
2014-01-03 17:32:20 +00:00
Spigot
29ab75468d Handle different sizes (G,K) for the PermGen warning
By: Thinkofdeath <thethinkofdeath@gmail.com>
2013-12-28 23:54:44 +00:00
Spigot
8bf1066c23 Fix Effect.TILE_BREAK
The particle's name got changed with @Grum 's tile -> block rename

By: Thinkofdeath <thethinkofdeath@gmail.com>
2013-12-27 19:45:04 +00:00
Spigot
1cf67ea855 Revert "Use Entity.teleportTo in CraftEntity.teleport"
This reverts commit f192df4023.

By: md_5 <git@md-5.net>
2013-12-24 14:52:45 +11:00
Spigot
d6dcaceca3 Add Late Bind Option
Add late-bind config option to delay binding until loading is done.

By: slide23 <me@slide.ws>
2013-12-24 10:22:53 +11:00
Spigot
f192df4023 Use Entity.teleportTo in CraftEntity.teleport
Entity.teleportTo is largely stable and correct. CraftEntity.teleport,
however, still cannot properly handle cross-world teleportation. Fix it
to defer to the better code in core Minecraft.

By: Andrew Krieger <Slizyboy@hotmail.com>
2013-12-24 10:18:01 +11:00
Spigot
549c85c400 Fix tab completion for some Vanilla commands (reload, plugins, testfor, tell) Thanks @ams2990
By: md_5 <git@md-5.net>
2013-12-24 10:14:53 +11:00
Spigot
59ef7aefd5 Revert the revert for now.
By: md_5 <git@md-5.net>
2013-12-23 21:03:39 +11:00
Spigot
ae3407bbd5 Increase verbosity of watchdog dumps
By: md_5 <git@md-5.net>
2013-12-23 21:01:45 +11:00
Spigot
b8d5260367 Revert check pending blocks patch as it (may) be causing some crash issues
By: md_5 <git@md-5.net>
2013-12-23 20:19:37 +11:00
Spigot
036da35bdf Disable connected check on setScoreboard. Mojang's semi async Netty implementation can lead to race conditions, and this exception being thrown when it really shouldn't.
By: md_5 <git@md-5.net>
2013-12-23 15:58:41 +11:00
Spigot
c9a666e78e Fix missing bitshifts
By: md_5 <git@md-5.net>
2013-12-23 15:43:33 +11:00
Spigot
dd91bed703 Warn if PermGen may be insufficient. Since 1.7 Mojang added a lot of new classes to their jar. This, coupled with plugins, may cause the loaded classes to exceed the default perm gem of 64mb. As such we will print a small warning advising users to set a higher PermGen if they haven't already.
By: md_5 <git@md-5.net>
2013-12-23 14:08:28 +11:00
Spigot
c8fe541778 Fix Biome Decoration Crashes
By: Dan Mulloy <dmulloy2@live.com>
2013-12-23 11:18:44 +11:00
Spigot
f8fe98c65f Add option to nerfs mobs from spawners. When this option is enabled, mobs which originate from a mob spawner will not have any AI, ie: brains. They will generally only be affected by water movement, with the exception of blazes which will still emit fireballs and float up and down.
This is disabled by default as it has a strong behavioural impact.

By: md_5 <git@md-5.net>
2013-12-22 21:00:50 +11:00
Spigot
20401f69c2 Add the getCubes patch back. Turns out the user with lockups had 23k+ entities in a single chunk.
By: md_5 <git@md-5.net>
2013-12-22 10:41:48 +11:00
Spigot
fe21d2887d Fix patch tree.
By: md_5 <git@md-5.net>
2013-12-22 10:06:06 +11:00
Spigot
79590b808a Redo previous getCubes removal.
By: md_5 <git@md-5.net>
2013-12-22 10:05:27 +11:00
Spigot
790cb1348c Fix patches some more.
By: md_5 <git@md-5.net>
2013-12-22 10:04:44 +11:00
Spigot
7d692a40aa Revert "Remove getCubes patch as under some circumstances it can loop around itself forever. For anyone wishing to reimplement this patch, the rationale behind it is quite simple, get all cubes within each chunk at the same time."
This reverts commit 5261962003.

By: md_5 <git@md-5.net>
2013-12-22 10:03:57 +11:00
Spigot
7de62a057d Save ticks lived to nbttag
By: DerFlash <bte@freenet.de>
2013-12-22 10:00:13 +11:00
Spigot
5261962003 Remove getCubes patch as under some circumstances it can loop around itself forever. For anyone wishing to reimplement this patch, the rationale behind it is quite simple, get all cubes within each chunk at the same time.
By: md_5 <git@md-5.net>
2013-12-22 09:59:17 +11:00
Spigot
3d37af4544 Force Load Chunks for Biome Decoration. May solve some random.nextInt() crashes people have been seeing.
By: md_5 <git@md-5.net>
2013-12-21 20:08:42 +11:00
Spigot
4ddeed1993 Fix accidentally reverted mc-dev imports.
By: md_5 <git@md-5.net>
2013-12-21 19:14:34 +11:00
Spigot
2c6428f4b1 Upstream merge, nothing major.
By: md_5 <git@md-5.net>
2013-12-21 19:13:39 +11:00
Spigot
c14cb5a15b Re-add the particle API
By: Thinkofdeath <thethinkofdeath@gmail.com>
2013-12-20 21:37:22 +00:00
Spigot
e715887ac8 Stage BiomeDecorator so we can get line numbers to match for stack traces.
By: md_5 <git@md-5.net>
2013-12-19 17:44:57 +11:00
Spigot
3361b3f92a Allow the console to use vanilla commands
By: Thinkofdeath <thethinkofdeath@gmail.com>
2013-12-18 11:40:35 +00:00
Spigot
384711f512 Fall back to our own URL clicking method as it works with more cases.
By: md_5 <git@md-5.net>
2013-12-18 20:41:42 +11:00
Spigot
72cde1fd01 Upstream merge
By: md_5 <git@md-5.net>
2013-12-18 17:48:18 +11:00
Spigot
be8c216be7 Invert command complete check
By: md_5 <git@md-5.net>
2013-12-18 17:24:24 +11:00
Spigot
0b64be883f Log Cause of Unexpected Exceptions
By: md_5 <git@md-5.net>
2013-12-18 13:39:28 +11:00
Spigot
a8fee4cba9 Fire PreLogin Events in Offline Mode
By: md_5 <git@md-5.net>
2013-12-18 13:32:30 +11:00