1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2024-12-22 22:45:31 +01:00
Commit graph

9 commits

Author SHA1 Message Date
Spottedleaf
8c5b837e05 Rework async chunk api implementation
Firstly, the old methods all routed to the CompletableFuture method.
However, the CF method could not guarantee that if the caller
was off-main that the future would be "completed" on-main. Since
the callback methods used the CF one, this meant that the callback
methods did not guarantee that the callbacks were to be called on
the main thread.

Now, all methods route to getChunkAtAsync(x, z, gen, urgent, cb)
so that the methods with the callback are guaranteed to invoke
the callback on the main thread. The CF behavior remains unchanged;
it may still appear to complete on main if invoked off-main.

Secondly, remove the scheduleOnMain invocation in the async
chunk completion. This unnecessarily delays the callback
by 1 tick.

Thirdly, add getChunksAtAsync(minX, minZ, maxX, maxZ, ...) which
will load chunks within an area. This method is provided as a helper
as keeping all chunks loaded within an area can be complicated to
implement for plugins (due to the lacking ticket API), and is
already implemented internally anyways.

Fourthly, remove the ticket addition that occured with getChunkAt
and getChunkAtAsync. The ticket addition may delay the unloading
of the chunk unnecessarily. It also fixes a very rare timing bug
where the future/callback would be completed after the chunk
unloads.
2024-11-18 23:00:59 -08:00
Nassim Jahnke
17dbf74ccf
Improve CraftEntity and CraftPlayer equals 2024-11-09 21:17:42 +01:00
Nassim Jahnke
02bca1e655
Remove timings impl 2024-10-27 18:39:30 +01:00
Spottedleaf
b711764991 Rebase fixups 2024-10-25 12:24:15 -07:00
Bjarne Koll
0a8fd78e37
Compiler issue v5 2024-10-25 18:08:28 +02:00
Bjarne Koll
6fb86bb20a
Compiler issues v2 2024-10-25 14:25:28 +02:00
Bjarne Koll
9047541397
Upstream update 2024-10-24 19:29:35 +02:00
Bjarne Koll
1f8b53733f
440 2024-10-23 17:13:43 +02:00
Bjarne Koll
dc5af4848a
Breakpoint before projectile mess 2024-10-23 11:04:00 +02:00
Renamed from patches/unapplied/server/0208-InventoryCloseEvent-Reason-API.patch (Browse further)