Spigot
ece477d0c7
Remove a fair chunk of existing patches now applied to CraftBukkit
...
By: md_5 <md_5@live.com.au>
2013-04-13 17:06:23 +10:00
Spigot
b4464fc721
Update netty & kindof hacky fix for anvil mishaps
...
By: md_5 <md_5@live.com.au>
2013-04-12 13:57:00 +10:00
Spigot
8e28115981
Add written bytes tracking for @bergerkiller
...
By: md_5 <md_5@live.com.au>
2013-04-10 16:37:43 +10:00
Spigot
a893386a86
Remove stats completely from patches.
...
By: md_5 <md_5@live.com.au>
2013-04-10 14:08:33 +10:00
Spigot
f5b1669094
Fix patches.
...
By: md_5 <md_5@live.com.au>
2013-04-10 14:06:41 +10:00
Spigot
7d84569b06
Add engine mode 2
...
By: SuPaH sPii <r29jk10@gmail.com>
2013-02-16 10:13:00 +11:00
Spigot
25a0b1356d
Please don't spam console every ping.
...
By: md_5 <md_5@live.com.au>
2013-02-15 18:25:53 +11:00
Spigot
00275b6d81
Remove extra disconnect info - confuses people into thinking something is wrong
...
By: md_5 <md_5@live.com.au>
2013-02-14 17:33:09 +11:00
Spigot
4937d401df
Remove locking in favour of a volatile state variable.
...
By: md_5 <md_5@live.com.au>
2013-02-13 12:22:25 +11:00
Spigot
2b28813233
Break packet reading into states to reduce object churn.
...
By: md_5 <md_5@live.com.au>
2013-02-13 12:11:37 +11:00
Spigot
c6a2240466
Reorder check for isEmpty, on a ConcurrentLinkedQueue its
...
more expensive than would appear.
By: md_5 <md_5@live.com.au>
2013-02-12 16:29:15 +11:00
Spigot
4546d28bde
Switch back to unbounded queue.
...
By: md_5 <md_5@live.com.au>
2013-02-12 16:23:43 +11:00
Spigot
bf3fab5c13
Add proper thread safety. Please let me know if this deadlocks your server.
...
By: md_5 <md_5@live.com.au>
2013-02-10 18:35:09 +11:00
Spigot
3e9cf48079
If you are a server list owner, and you have not fixed your shit, I kindly request that you do so NOW. I will not waste another 5 hours of my life covering up for you. 4 months is more than long enough for 3 lines of code change.
...
By: md_5 <md_5@live.com.au>
2013-02-10 16:50:54 +11:00
Spigot
52fc2b1ea2
Add volatile to be sure the JVM wont cache the value
...
By: md_5 <md_5@live.com.au>
2013-02-10 15:12:35 +11:00
Spigot
ffe44eefa2
Fix occasionally showing as 1.3
...
By: md_5 <md_5@live.com.au>
2013-02-10 15:04:27 +11:00
Spigot
1ccfa93293
Revert "Reduce legacy ping threshold to 1000ms"
...
This reverts commit eb53806048
2013-02-10 14:52:14 +11:00
Spigot
eb53806048
Reduce legacy ping threshold to 1000ms
...
By: md_5 <md_5@live.com.au>
2013-02-10 14:35:13 +11:00
Spigot
07ebde686f
Fix legacy pinging with some uber ninja coding.
...
By: md_5 <md_5@live.com.au>
2013-02-10 14:26:59 +11:00
Spigot
3b1b3a1a6a
Fix support for windows xp / server 2003
...
By: md_5 <md_5@live.com.au>
2013-02-10 12:35:52 +11:00
Spigot
4a2b769924
It came to me in a dream - literally. This should fix all known issues.
...
By: md_5 <md_5@live.com.au>
2013-02-10 11:54:49 +11:00
Spigot
0470d35982
Tweak to thread pool and safety.
...
By: md_5 <md_5@live.com.au>
2013-02-10 10:30:58 +11:00
Spigot
913785e91c
Clearing the queue when they are disconnected might actually fix some issues.
...
By: md_5 <md_5@live.com.au>
2013-02-10 09:33:31 +11:00
Spigot
93e8ed2af2
Add extra info regarding why a user is disconnected. Should help us troubleshoot these errors - please post the full DC line if reporting a bug.
...
By: md_5 <md_5@live.com.au>
2013-02-10 08:55:18 +11:00
Spigot
b91a5519b8
*break when dc'd
...
By: md_5 <md_5@live.com.au>
2013-02-09 23:00:03 +11:00
Spigot
beb405de3d
Remove debug code now that we know it can be called.
...
By: md_5 <md_5@live.com.au>
2013-02-09 22:54:14 +11:00
Spigot
b86ff9221a
Run disconnect code on the main thread.
...
By: md_5 <md_5@live.com.au>
2013-02-09 21:55:33 +11:00
Spigot
cacf82702a
Add debug to see if statement is ever true
...
By: md_5 <md_5@live.com.au>
2013-02-09 21:28:34 +11:00
Spigot
cf017832f9
Give a pot shot at bringing network logic a bit closer to CB/Vanilla
...
By: md_5 <md_5@live.com.au>
2013-02-09 21:05:34 +11:00
Spigot
0dd1a832f2
Small cleanup to netty code, no functional changes.
...
By: md_5 <md_5@live.com.au>
2013-02-09 20:58:03 +11:00
Spigot
27b63340b1
Don't scare users with debug mode.
...
By: md_5 <md_5@live.com.au>
2013-02-09 20:42:08 +11:00
Spigot
e274cc30a0
Add debug logging + more cleanup
...
By: md_5 <md_5@live.com.au>
2013-02-09 20:27:25 +11:00
Spigot
4d4b061767
Nullcheck channel just in case, only null channel on disconnect.
...
By: md_5 <md_5@live.com.au>
2013-02-09 20:16:23 +11:00
Spigot
b0cc5c98b9
Use a synced arraylist
...
By: md_5 <md_5@live.com.au>
2013-02-09 20:10:34 +11:00
Spigot
01590fb1fa
Implement an uber efficient network engine based on the Java NIO framework Netty. This is basically a complete rewrite of the Minecraft network engine with many distinct advantages. First and foremost, there will no longer be the horrid, and redundant case of 2, or even at times, 3 threads per a connection. Instead low level select/epoll based NIO is used. The number of threads used for network reading and writing will scale automatically to the number of cores for use on your server. In most cases this will be around 8 threads for a 4 core server, much better than the up to 1000 threads that could be in use at one time with the old engine. To facilitate asynchronous packet sending or receiving (currently only chat), a cached thread pool is kept handy. Currently this pool is unbounded, however at this stage we do not need to worry about servers being resource starved due to excessive spam or chat.
...
== Plugin incompatibilities
As a side effect of this change, plugins which rely on very specific implementation level details within Minecraft are broken. At this point in time, TagAPI and ProtocolLib are affected. If you are a user of ProtocolLib you are advised to update to the latest build, where full support is enabled. If you are a user of TagAPI, support has not yet been added, so you will need to install the updated ProtocolLib so that TagAPI may use its functions.
== Stability
The code within this commit has been very lightly tested in production (300 players for approximately 24 hours), however it is not guaranteed to be free from all bugs. If you experence weird connection behaviour, reporting the bug and steps to reproduce are advised. You are also free to downgrade to the latest recommend build, which is guaranteed to be stable.
== Summary
This commit provides a reduction in threads, which gives the CPU / operating system more time to allocate to the main server threads, as well as various other side benefits such as chat thread pooling and a slight reduction in latency.
This commit is licensed under the Creative Commons Attribution-ShareAlike 3.0 Unported license.
By: md_5 <md_5@live.com.au>
2013-02-09 17:16:27 +11:00
