Commit graph

4781 commits

Author SHA1 Message Date
blablubbabc
c9d7c16b5f SPIGOT-2623: Add EntityEquipment methods to get/set ItemStacks by slot. 2020-06-13 20:56:32 +10:00
Spottedleaf
fad2494af1 #673: Fix Craftworld#isChunkLoaded
The flag for getChunkAt(int, int, ChunkStatus, boolean)
is actually a flag for whether to bring the underlying
PlayerChunk up to the required ticket level to load the
chunk. So, if the chunk is already at the required level,
but has not yet loaded, the call will actually either
start the load if it has not already been started and
block until completion.

This behaviour is not suitable for just
checking if the chunk is loaded.
2020-06-06 19:23:46 +10:00
Lars Dormans
8637ec008d SPIGOT-5751: Made breakNaturally and getDrops returns the correct item if no argument is given 2020-06-03 19:28:13 +10:00
Aikar
1b2830a3b3 SPIGOT-4441: Fix serializing Components to and from Legacy
While cfeef75cd9 might of semi helped being able to save black text
lore, it actually took a fundamental problem with the legacy serialization
code and expanded it to break even more aspects of the server when dealing
with Component to Legacy conversion.

This is causing data loss in Spigot with cases such as setting an item name
to white gets stripped resulting in it being italic.

Additionally, things such as book pages have been returning black formatting
codes for the end of the line even when the user doesn't have colors in the book.

The root issue is that the "Default Color" system is fundamentally wrong.

Components do not and should not care about what element of the game they
are being used by, and that's what the default color system did.

It results in components that if obtained from 1 source such as a Book
where the default / rendered color is black, is then copied to another
source such as an Entity name, the black is carried forward and shown
in the Entity name, when in reality it should have been white.

This commit reverts cfeef75cd9 and fixes the underlying serialization
issues when it comes to Legacy to and From conversions.

There was quite a number of issues with this code overall, in how
it handles inserting color codes, new line parsing and such.

Books was using mojangs own "getLegacyString" which doesn't match behavior.
We also do not want to use Mojangs method as there is no guarantee they don't
remove that in future.
Plus, everything about books uses the CB implementation anyways, and it should
be consistent (this was mandatory to avoid serialization format changes on old vs new)

These changes as is results in Item Stacks already serialized will not
change contents when they go to component and back, so this won't impact
any existing data.

Newly created books though for example will change behavior in that they
will no longer insert black color codes in the serialized data and will
only represent intentional color changes by the creator of the book.
This will result in cleaner data on them, and books are the only thing
I'm aware of that has a behavioral shift due to the likelyhood of the
default color system kicking in on other parts of the string.

A unit test has been added to verify integrity of serialization to
ensure that any legacy string that is converted into Components will
always re-encode back in the same way when going back to Legacy.
2020-06-01 19:19:42 +10:00
ben
aae46f82ea #665: Add test for Material#getCraftingRemainingItem() 2020-05-28 19:31:27 +10:00
md_5
cfeef75cd9 SPIGOT-5749: ItemMeta serializing to YAML not saving black colour code 2020-05-26 19:39:03 +10:00
WinX64
eb1b19d979 SPIGOT-5748: Add instant effect potion break to the Effect enum
Conversion from Color to integer for the data of the new enum entry
2020-05-26 19:34:39 +10:00
md_5
d07a78b1f3 SPIGOT-5716: Clarify documentation of MultipleFacing 2020-05-09 16:12:18 +10:00
md_5
46a1386066 SPIGOT-5718: Block.BreakBlockNaturally does not reflect tool used 2020-05-09 16:05:17 +10:00
ShaneBeee
214ffea95e SPIGOT-5727: GameRule doImmediateRespawn cannot be set per-world 2020-05-09 15:45:52 +10:00
Parker Hawke
933e9094bf #664: Add methods to get/set ItemStacks in EquipmentSlots 2020-05-05 19:10:03 +10:00
Parker Hawke
1872231235 #662: Expose ItemStack and hand used in PlayerShearEntityEvent 2020-05-02 17:48:37 +10:00
Parker Hawke
77fd87e4d0 SPIGOT-2304: Implement LootGenerateEvent 2020-04-30 19:15:58 +10:00
Parker Hawke
a1a705ee9a SPIGOT-5566: Doused campfires & fires should call EntityChangeBlockEvent 2020-04-29 17:26:40 +10:00
md_5
41712eddeb SPIGOT-5707: PersistentDataHolder not Persistent on API dropped Item 2020-04-29 17:21:06 +10:00
DiamondDagger590
893ad93b3e #650: Add method to get player's attack cooldown 2020-04-23 11:13:40 +10:00
Martoph
ef706b064e #655: Added support for the VM tag jansi.passthrough when processing messages sent to a ColouredConsoleSender. 2020-04-23 11:06:13 +10:00
md_5
e0cfb34742 SPIGOT-5689: Fireball.setDirection increases velocity too much 2020-04-23 08:33:33 +10:00
md_5
94cb030fb5 SPIGOT-5673: swingHand API does not show to self 2020-04-22 12:06:24 +10:00
md_5
b331a05509 SPIGOT-5680: isChunkGenerated creates empty region files 2020-04-22 12:00:50 +10:00
md_5
e1335932a7 Improve build process 2020-04-22 11:50:23 +10:00
md_5
a8ec1d60f3 Add a couple of method null checks to CraftWorld 2020-04-17 08:39:22 +10:00
md_5
ce66f6937b Misc checkstyle fixes 2020-04-14 12:34:43 +10:00
Lars Dormans
8bd0e9ab0e SPIGOT-5669: Fix Beehive.isSedated 2020-04-13 15:45:52 +10:00
md_5
183139d41f SPIGOT-5665: Improve loading spawn egg NBT 2020-04-10 11:16:58 +10:00
md_5
dec5df2632 SPIGOT-5667: Can't add recipe without (vanilla) datapack 2020-04-10 10:56:00 +10:00
konsolas
f7d6ad53ee SPIGOT-5603: Use LootContext#lootingModifier in CraftLootTable 2020-04-08 17:13:29 +10:00
md_5
5838285d60 SPIGOT-5657: BlockPlaceEvent not cancelling for tripwire hooks 2020-04-05 17:19:03 +10:00
md_5
f325b9beac SPIGOT-5641: Add Block.getDrops(ItemStack, Entity) 2020-04-05 16:52:06 +10:00
md_5
e25a2272f8 Fix some formatting in CraftHumanEntity 2020-04-05 16:30:47 +10:00
md_5
498540e082 Add Merchant slot delegate 2020-04-05 16:29:43 +10:00
Tim
b2de47d581 SPIGOT-5621: Add missing container types for opening InventoryView 2020-04-05 16:28:43 +10:00
SydMontague
aa3a2f2767 #645: Allow statistics to be accessed for offline players 2020-04-05 15:58:43 +10:00
ShaneBee
2122c0b128 #649: CraftBell should implement Bell 2020-04-05 15:40:54 +10:00
md_5
bbe3d58efc SPIGOT-5650: Lectern.setPage(int) causes a NullPointerException 2020-04-01 09:30:47 +11:00
md_5
3075579f61 Add FaceAttachable interface to handle Grindstone facing in common with Switches 2020-04-01 09:14:29 +11:00
md_5
95bd4238fb SPIGOT-5647: ZombieVillager entity should have getVillagerType() 2020-03-30 12:15:21 +11:00
md_5
4d975ac3b7 SPIGOT-5617: setBlockData does not work when NotPlayEvent is called by redstone current 2020-03-29 16:24:11 +11:00
Parker Hawke
fc318cc10e #642: Add a DragonBattle API to manipulate respawn phases etc 2020-03-24 19:53:47 +11:00
Spottedleaf
796eb15a5b #644: Fix ChunkMapDistance#removeAllTicketsFor not propagating ticket level updates
Now call the method used in removeTicket for propagating the change,
so that chunks are guaranteed to unload
2020-03-22 20:02:22 +11:00
Jan Boerman
a6f809378c SPIGOT-5606: call BlockRedstoneEvent for fence gates 2020-03-15 19:05:50 +11:00
Phoenix616
fc24934098 SPIGOT-5484: Add more spawn tick settings 2020-03-08 19:43:47 +11:00
Spottedleaf
7f61a2526e #640: Fix chunk load/unload callbacks for chunk load cancellations
When a chunk goes from a ticket level where it is loading a
full chunk to an inactive state (i.e ticket level 33 to
ticket level 45) the full status future will be completed
with a "Right" Either (indicating unloaded). However, this
will also schedule the unload callback immediately.

However, the callback is not immediately executed. This means
the next unload/load callback that needs to be scheduled will
fail. The fix applied is to not schedule a callback if the
chunk is not loaded - if the Either is "right."

Even better, due to how completablefuture works, exceptions
are not printed by default. So the exception thrown by the
callback executor was not printed and the failure
hidden from console. This explains why no-one has tracked this issue.
Now the exception is printed so future failures with the
callback system (if any) can be tracked easier.
2020-03-06 14:34:13 +11:00
md_5
13ed05decd Prepare for Java 14 2020-03-02 13:30:33 +11:00
Bjarne Koll
6b00b14539 #639: Deep clone itemmetas persistent container on clone
After this commit, spigot now creates a deep copy of the
itemmeta's persistent data container when the itemmeta
instance is cloned.

This change fixes the bug that, after cloning itemmeta, the container
instance the cloned meta would point to was equal to the original one.
This resulted in two itemmeta instances sharing a single persistent
container.
2020-03-02 13:10:21 +11:00
md_5
3d61a853e3 Fix formatting in CraftLivingEntity 2020-02-23 19:01:11 +11:00
konsolas
f7ab30557e #633: Add LivingEntity#attack, LivingEntity#swingMainHand, LivingEntity#swingOffHand 2020-02-23 19:00:18 +11:00
md_5
d5ef2eab9e SPIGOT-5591: Allow concurrent potion effects 2020-02-23 10:33:10 +11:00
md_5
25a9a9ff62 SPIGOT-5592: Custom ChunkGenerator can cause bugged dirt 2020-02-23 10:29:46 +11:00
md_5
3f6d0de989 Make it clear in error messages that api-version above 1.13 is also supported 2020-02-23 09:42:33 +11:00