--- a/net/minecraft/world/item/crafting/CraftingManager.java +++ b/net/minecraft/world/item/crafting/CraftingManager.java @@ -34,11 +34,13 @@ import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; +import it.unimi.dsi.fastutil.objects.Object2ObjectLinkedOpenHashMap; // CraftBukkit + public class CraftingManager extends ResourceDataJson { private static final Gson GSON = (new GsonBuilder()).setPrettyPrinting().disableHtmlEscaping().create(); private static final Logger LOGGER = LogManager.getLogger(); - public Map, Map>> recipes = ImmutableMap.of(); + public Map, Object2ObjectLinkedOpenHashMap>> recipes = ImmutableMap.of(); // CraftBukkit private boolean hasErrors; public CraftingManager() { @@ -47,7 +49,12 @@ protected void apply(Map map, IResourceManager iresourcemanager, GameProfilerFiller gameprofilerfiller) { this.hasErrors = false; - Map, Builder>> map1 = Maps.newHashMap(); + // CraftBukkit start - SPIGOT-5667 make sure all types are populated and mutable + Map, Object2ObjectLinkedOpenHashMap>> map1 = Maps.newHashMap(); + for (Recipes recipeType : IRegistry.RECIPE_TYPE) { + map1.put(recipeType, new Object2ObjectLinkedOpenHashMap<>()); + } + // CraftBukkit end Iterator iterator = map.entrySet().iterator(); while (iterator.hasNext()) { @@ -57,8 +64,10 @@ try { IRecipe irecipe = fromJson(minecraftkey, ChatDeserializer.convertToJsonObject((JsonElement) entry.getValue(), "top element")); - ((Builder) map1.computeIfAbsent(irecipe.getType(), (recipes) -> { - return ImmutableMap.builder(); + // CraftBukkit start + (map1.computeIfAbsent(irecipe.getType(), (recipes) -> { + return new Object2ObjectLinkedOpenHashMap<>(); + // CraftBukkit end })).put(minecraftkey, irecipe); } catch (IllegalArgumentException | JsonParseException jsonparseexception) { CraftingManager.LOGGER.error("Parsing error loading recipe {}", minecraftkey, jsonparseexception); @@ -66,19 +75,35 @@ } this.recipes = (Map) map1.entrySet().stream().collect(ImmutableMap.toImmutableMap(Entry::getKey, (entry1) -> { - return ((Builder) entry1.getValue()).build(); + return (entry1.getValue()); // CraftBukkit })); CraftingManager.LOGGER.info("Loaded {} recipes", map1.size()); } + // CraftBukkit start + public void addRecipe(IRecipe irecipe) { + Object2ObjectLinkedOpenHashMap> map = this.recipes.get(irecipe.getType()); // CraftBukkit + + if (map.containsKey(irecipe.getId())) { + throw new IllegalStateException("Duplicate recipe ignored with ID " + irecipe.getId()); + } else { + map.putAndMoveToFirst(irecipe.getId(), irecipe); // CraftBukkit - SPIGOT-4638: last recipe gets priority + } + } + // CraftBukkit end + public boolean hadErrorsLoading() { return this.hasErrors; } public > Optional getRecipeFor(Recipes recipes, C c0, World world) { - return this.byType(recipes).values().stream().flatMap((irecipe) -> { + // CraftBukkit start + Optional recipe = this.byType(recipes).values().stream().flatMap((irecipe) -> { return SystemUtils.toStream(recipes.tryMatch(irecipe, world, c0)); }).findFirst(); + c0.setCurrentRecipe(recipe.orElse(null)); // CraftBukkit - Clear recipe when no recipe is found + // CraftBukkit end + return recipe; } public > List getAllRecipesFor(Recipes recipes) { @@ -96,7 +121,7 @@ } private > Map> byType(Recipes recipes) { - return (Map) this.recipes.getOrDefault(recipes, Collections.emptyMap()); + return (Map) this.recipes.getOrDefault(recipes, new Object2ObjectLinkedOpenHashMap<>()); // CraftBukkit } public > NonNullList getRemainingItemsFor(Recipes recipes, C c0, World world) { @@ -117,7 +142,7 @@ public Optional> byKey(MinecraftKey minecraftkey) { return this.recipes.values().stream().map((map) -> { - return (IRecipe) map.get(minecraftkey); + return map.get(minecraftkey); // CraftBukkit - decompile error }).filter(Objects::nonNull).findFirst(); } @@ -143,11 +168,11 @@ public void replaceRecipes(Iterable> iterable) { this.hasErrors = false; - Map, Map>> map = Maps.newHashMap(); + Map, Object2ObjectLinkedOpenHashMap>> map = Maps.newHashMap(); // CraftBukkit iterable.forEach((irecipe) -> { Map> map1 = (Map) map.computeIfAbsent(irecipe.getType(), (recipes) -> { - return Maps.newHashMap(); + return new Object2ObjectLinkedOpenHashMap<>(); // CraftBukkit }); IRecipe irecipe1 = (IRecipe) map1.put(irecipe.getId(), irecipe); @@ -157,4 +182,14 @@ }); this.recipes = ImmutableMap.copyOf(map); } + + // CraftBukkit start + public void clearRecipes() { + this.recipes = Maps.newHashMap(); + + for (Recipes recipeType : IRegistry.RECIPE_TYPE) { + this.recipes.put(recipeType, new Object2ObjectLinkedOpenHashMap<>()); + } + } + // CraftBukkit end }