--- a/net/minecraft/world/entity/projectile/EntityArrow.java +++ b/net/minecraft/world/entity/projectile/EntityArrow.java @@ -52,6 +52,13 @@ import net.minecraft.world.phys.Vec3D; import net.minecraft.world.phys.shapes.VoxelShape; +// CraftBukkit start +import net.minecraft.world.entity.item.EntityItem; +import org.bukkit.event.entity.EntityCombustByEntityEvent; +import org.bukkit.event.entity.EntityRemoveEvent; +import org.bukkit.event.player.PlayerPickupArrowEvent; +// CraftBukkit end + public abstract class EntityArrow extends IProjectile { private static final double ARROW_BASE_DAMAGE = 2.0D; @@ -242,7 +249,7 @@ } if (object != null && !flag) { - ProjectileDeflection projectiledeflection = this.hitTargetOrDeflectSelf((MovingObjectPosition) object); + ProjectileDeflection projectiledeflection = this.preHitTargetOrDeflectSelf((MovingObjectPosition) object); // CraftBukkit - projectile hit event this.hasImpulse = true; if (projectiledeflection != ProjectileDeflection.NONE) { @@ -333,7 +340,7 @@ protected void tickDespawn() { ++this.life; if (this.life >= 1200) { - this.discard(); + this.discard(EntityRemoveEvent.Cause.DESPAWN); // CraftBukkit - add Bukkit remove cause } } @@ -380,7 +387,7 @@ } if (this.piercingIgnoreEntityIds.size() >= this.getPierceLevel() + 1) { - this.discard(); + this.discard(EntityRemoveEvent.Cause.HIT); // CraftBukkit - add Bukkit remove cause return; } @@ -401,7 +408,13 @@ int k = entity.getRemainingFireTicks(); if (this.isOnFire() && !flag) { - entity.igniteForSeconds(5.0F); + // CraftBukkit start + EntityCombustByEntityEvent combustEvent = new EntityCombustByEntityEvent(this.getBukkitEntity(), entity.getBukkitEntity(), 5.0F); + org.bukkit.Bukkit.getPluginManager().callEvent(combustEvent); + if (!combustEvent.isCancelled()) { + entity.igniteForSeconds(combustEvent.getDuration(), false); + } + // CraftBukkit end } if (entity.hurt(damagesource, (float) i)) { @@ -447,7 +460,7 @@ this.playSound(this.soundEvent, 1.0F, 1.2F / (this.random.nextFloat() * 0.2F + 0.9F)); if (this.getPierceLevel() <= 0) { - this.discard(); + this.discard(EntityRemoveEvent.Cause.HIT); // CraftBukkit - add Bukkit remove cause } } else { entity.setRemainingFireTicks(k); @@ -458,7 +471,7 @@ this.spawnAtLocation(this.getPickupItem(), 0.1F); } - this.discard(); + this.discard(EntityRemoveEvent.Cause.HIT); // CraftBukkit - add Bukkit remove cause } } @@ -614,7 +627,7 @@ } if (nbttagcompound.contains("weapon", 10)) { - this.firedFromWeapon = (ItemStack) ItemStack.parse(this.registryAccess(), nbttagcompound.getCompound("weapon")).orElse((Object) null); + this.firedFromWeapon = (ItemStack) ItemStack.parse(this.registryAccess(), nbttagcompound.getCompound("weapon")).orElse(null); // CraftBukkit - decompile error } else { this.firedFromWeapon = null; } @@ -630,17 +643,10 @@ EntityArrow.PickupStatus entityarrow_pickupstatus; label16: - while(true) { - //$FF: b0->value - //0->net/minecraft/world/entity/player/EntityHuman - //1->net/minecraft/world/entity/OminousItemSpawner - switch (entity1.typeSwitch(entity1, b0)) { - case -1: - default: - entityarrow_pickupstatus = this.pickup; - break label16; - case 0: - EntityHuman entityhuman = (EntityHuman)entity1; + // CraftBukkit start - decompile error + while (true) { + switch (entity1) { + case EntityHuman entityhuman: if (this.pickup != EntityArrow.PickupStatus.DISALLOWED) { b0 = 1; @@ -649,12 +655,15 @@ entityarrow_pickupstatus = EntityArrow.PickupStatus.ALLOWED; break label16; - case 1: - OminousItemSpawner ominousitemspawner = (OminousItemSpawner)entity1; + case OminousItemSpawner ominousitemspawner: entityarrow_pickupstatus = EntityArrow.PickupStatus.DISALLOWED; break label16; + default: + entityarrow_pickupstatus = this.pickup; + break label16; } + // CraftBukkit end } this.pickup = entityarrow_pickupstatus; @@ -663,9 +672,24 @@ @Override public void playerTouch(EntityHuman entityhuman) { if (!this.level().isClientSide && (this.inGround || this.isNoPhysics()) && this.shakeTime <= 0) { - if (this.tryPickup(entityhuman)) { + // CraftBukkit start + ItemStack itemstack = this.getPickupItem(); + if (this.pickup == PickupStatus.ALLOWED && !itemstack.isEmpty() && entityhuman.getInventory().canHold(itemstack) > 0) { + EntityItem item = new EntityItem(this.level(), this.getX(), this.getY(), this.getZ(), itemstack); + PlayerPickupArrowEvent event = new PlayerPickupArrowEvent((org.bukkit.entity.Player) entityhuman.getBukkitEntity(), new org.bukkit.craftbukkit.entity.CraftItem(this.level().getCraftServer(), item), (org.bukkit.entity.AbstractArrow) this.getBukkitEntity()); + // event.setCancelled(!entityhuman.canPickUpLoot); TODO + this.level().getCraftServer().getPluginManager().callEvent(event); + + if (event.isCancelled()) { + return; + } + itemstack = item.getItem(); + } + + if ((this.pickup == EntityArrow.PickupStatus.ALLOWED && entityhuman.getInventory().add(itemstack)) || (this.pickup == EntityArrow.PickupStatus.CREATIVE_ONLY && entityhuman.getAbilities().instabuild)) { + // CraftBukkit end entityhuman.take(this, 1); - this.discard(); + this.discard(EntityRemoveEvent.Cause.PICKUP); // CraftBukkit - add Bukkit remove cause } }