mirror of
https://github.com/PaperMC/Paper.git
synced 2024-11-22 07:08:47 +01:00
ac554ad46d
Updated Upstream (Bukkit/CraftBukkit) Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: fa99e752 PR-1007: Add ItemMeta#getAsComponentString() 94a91782 Fix copy-pasted BlockType.Typed documentation 9b34ac8c Largely restore deprecated PotionData API 51a6449b PR-1008: Deprecate ITEMS_TOOLS, removed in 1.20.5 702d15fe Fix Javadoc reference 42f6cdf4 PR-919: Add internal ItemType and BlockType, delegate Material methods to them 237bb37b SPIGOT-1166, SPIGOT-7647: Expose Damager BlockState in EntityDamageByBlockEvent 035ea146 SPIGOT-6993: Allow #setVelocity to change the speed of a fireball and add a note to #setDirection about it 8c7880fb PR-1004: Improve field rename handling and centralize conversion between bukkit and string more 87c90e93 SPIGOT-7650: Add DamageSource for EntityDeathEvent and PlayerDeathEvent CraftBukkit Changes: 4af0f22e8 SPIGOT-7664: Item meta should prevail over block states c2ccc46ec SPIGOT-7666: Fix access to llama and horse special slot 124ac66d7 SPIGOT-7665: Fix ThrownPotion#getEffects() implementation only bringing custom effects 66f1f439a Restore null page behaviour of signed books even though not strictly allowed by API 6118e5398 Fix regression listening to minecraft:brand custom payloads c1a26b366 Fix unnecessary and potential not thread-safe chat visibility check 12360a7ec Remove unused imports 147b098b4 PR-1397: Add ItemMeta#getAsComponentString() 428aefe0e Largely restore deprecated PotionData API afe5b5ee9 PR-1275: Add internal ItemType and BlockType, delegate Material methods to them 8afeafa7d SPIGOT-1166, SPIGOT-7647: Expose Damager BlockState in EntityDamageByBlockEvent 4e7d749d4 SPIGOT-6993: Allow #setVelocity to change the speed of a fireball and add a note to #setDirection about it 441880757 Support both entity_data and bucket_entity_data on axolotl/fish buckets 0e22fdd1e Fix custom direct BlockState being not correctly set in DamageSource f2182ed47 SPIGOT-7659: TropicalFishBucketMeta should use BUCKET_ENTITY_DATA 2a6207fe1 PR-1393: Improve field rename handling and centralize conversion between bukkit and string more c024a5039 SPIGOT-7650: Add DamageSource for EntityDeathEvent and PlayerDeathEvent 741b84480 PR-1390: Improve internal handling of damage sources 0364df4e1 SPIGOT-7657: Error when loading angry entities
91 lines
4 KiB
Diff
91 lines
4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jake Potrebic <jake.m.potrebic@gmail.com>
|
|
Date: Sun, 8 May 2022 13:35:58 -0700
|
|
Subject: [PATCH] ItemStack damage API
|
|
|
|
Adds methods notify clients about item breaks and
|
|
to simulate damage done to an itemstack and all
|
|
the logic associated with damaging them
|
|
|
|
diff --git a/src/main/java/org/bukkit/entity/LivingEntity.java b/src/main/java/org/bukkit/entity/LivingEntity.java
|
|
index 6bfc8a2148f504370df938447f4f6b757f1a516b..208bab1f5a3200f54141c38ee4272629cfc66da5 100644
|
|
--- a/src/main/java/org/bukkit/entity/LivingEntity.java
|
|
+++ b/src/main/java/org/bukkit/entity/LivingEntity.java
|
|
@@ -1365,4 +1365,53 @@ public interface LivingEntity extends Attributable, Damageable, ProjectileSource
|
|
*/
|
|
void knockback(double strength, double directionX, double directionZ);
|
|
// Paper end - knockback API
|
|
+
|
|
+ // Paper start - ItemStack damage API
|
|
+ /**
|
|
+ * Notifies all clients tracking this entity that the item in
|
|
+ * the slot of this entity broke.
|
|
+ * <p>
|
|
+ * NOTE: this does not mutate any entity state
|
|
+ *
|
|
+ * @param slot the slot
|
|
+ */
|
|
+ void broadcastSlotBreak(org.bukkit.inventory.@NotNull EquipmentSlot slot);
|
|
+
|
|
+ /**
|
|
+ * Notifies specified players that the item in the slot
|
|
+ * of this entity broke.
|
|
+ * <p>
|
|
+ * NOTE: this does not mutate any entity state
|
|
+ *
|
|
+ * @param slot the slot
|
|
+ * @param players the players to notify
|
|
+ */
|
|
+ void broadcastSlotBreak(org.bukkit.inventory.@NotNull EquipmentSlot slot, @NotNull Collection<Player> players);
|
|
+
|
|
+ /**
|
|
+ * Damages the itemstack in this slot by the specified amount.
|
|
+ * <p>
|
|
+ * This runs all logic associated with damaging an itemstack like
|
|
+ * gamemode and enchantment checks, events, stat changes, and advancement
|
|
+ * triggers.
|
|
+ *
|
|
+ * @param stack the itemstack to damage
|
|
+ * @param amount the amount of damage to do
|
|
+ * @return the damaged itemstack, or an empty stack if it broke. There are no
|
|
+ * guarantees the returned itemstack is the same instance
|
|
+ */
|
|
+ @NotNull ItemStack damageItemStack(@NotNull ItemStack stack, int amount);
|
|
+
|
|
+ /**
|
|
+ * Damages the itemstack in this slot by the specified amount.
|
|
+ * <p>
|
|
+ * This runs all logic associated with damaging an itemstack like
|
|
+ * gamemode and enchantment checks, events, stat changes, advancement
|
|
+ * triggers, and notifying clients to play break animations.
|
|
+ *
|
|
+ * @param slot the slot of the stack to damage
|
|
+ * @param amount the amount of damage to do
|
|
+ */
|
|
+ void damageItemStack(org.bukkit.inventory.@NotNull EquipmentSlot slot, int amount);
|
|
+ // Paper end - ItemStack damage API
|
|
}
|
|
diff --git a/src/main/java/org/bukkit/inventory/ItemStack.java b/src/main/java/org/bukkit/inventory/ItemStack.java
|
|
index 105cf1bf6e8b44846cdd3a8881fed36007daaa22..ee5d2a30f634ccbe6f2cc2f82f9e56783939f5dd 100644
|
|
--- a/src/main/java/org/bukkit/inventory/ItemStack.java
|
|
+++ b/src/main/java/org/bukkit/inventory/ItemStack.java
|
|
@@ -993,5 +993,19 @@ public class ItemStack implements Cloneable, ConfigurationSerializable, Translat
|
|
public boolean canRepair(@NotNull ItemStack toBeRepaired) {
|
|
return Bukkit.getUnsafe().isValidRepairItemStack(toBeRepaired, this);
|
|
}
|
|
+
|
|
+ /**
|
|
+ * Damages this itemstack by the specified amount. This
|
|
+ * runs all logic associated with damaging an itemstack like
|
|
+ * events and stat changes.
|
|
+ *
|
|
+ * @param amount the amount of damage to do
|
|
+ * @param livingEntity the entity related to the damage
|
|
+ * @return the damaged itemstack or an empty one if it broke. May return the same instance of ItemStack
|
|
+ * @see org.bukkit.entity.LivingEntity#damageItemStack(EquipmentSlot, int) to damage itemstacks in equipment slots
|
|
+ */
|
|
+ public @NotNull ItemStack damage(int amount, @NotNull org.bukkit.entity.LivingEntity livingEntity) {
|
|
+ return livingEntity.damageItemStack(this, amount);
|
|
+ }
|
|
// Paper end
|
|
}
|