mirror of
https://github.com/PaperMC/Paper.git
synced 2024-12-02 13:07:06 +01:00
ef0e5a642d
Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 9ae3f10f SPIGOT-3842: Add Player#fireworkBoost() and expand Firework API 48c0c547 PR-786: Add methods to get sounds from entities CraftBukkit Changes: 5cc9c022a SPIGOT-7152: Handle hand item changing during air interact event 4ffa1acf6 SPIGOT-7154: Players get kicked when interacting with a conversation 4daa21123 SPIGOT-3842: Add Player#fireworkBoost() and expand Firework API e5d6a9bbf PR-1100: Add methods to get sounds from entities b7e9f1c8b SPIGOT-7146: Reduce use of Material switch in ItemMeta Spigot Changes: 4c157bb4 Rebuild patches
52 lines
2.5 KiB
Diff
52 lines
2.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Spottedleaf <spottedleaf@spottedleaf.dev>
|
|
Date: Sat, 4 Apr 2020 17:00:20 -0700
|
|
Subject: [PATCH] Consolidate flush calls for entity tracker packets
|
|
|
|
Most server packets seem to be sent from here, so try to avoid
|
|
expensive flush calls from them.
|
|
|
|
This change was motivated due to local testing:
|
|
|
|
- My server spawn has 130 cows in it (for testing a prev. patch)
|
|
- Try to let 200 players join spawn
|
|
|
|
Without this change, I could only get 20 players on before they
|
|
all started timing out due to the load put on the Netty I/O threads.
|
|
|
|
With this change I could get all 200 on at 0ms ping.
|
|
|
|
(one of the primary issues is that my CPU is kinda trash, and having
|
|
4 extra threads at 100% is just too much for it).
|
|
|
|
So in general this patch should reduce Netty I/O thread load.
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/level/ServerChunkCache.java b/src/main/java/net/minecraft/server/level/ServerChunkCache.java
|
|
index 98e279e5330b45d0587d1afebddaf876e9802e33..4c82f17313e18c9dfd9b28653715b8a3242b826c 100644
|
|
--- a/src/main/java/net/minecraft/server/level/ServerChunkCache.java
|
|
+++ b/src/main/java/net/minecraft/server/level/ServerChunkCache.java
|
|
@@ -893,7 +893,24 @@ public class ServerChunkCache extends ChunkSource {
|
|
this.level.timings.broadcastChunkUpdates.stopTiming(); // Paper - timing
|
|
gameprofilerfiller.pop();
|
|
// Paper end - use set of chunks requiring updates, rather than iterating every single one loaded
|
|
+ // Paper start - controlled flush for entity tracker packets
|
|
+ List<net.minecraft.network.Connection> disabledFlushes = new java.util.ArrayList<>(this.level.players.size());
|
|
+ for (ServerPlayer player : this.level.players) {
|
|
+ net.minecraft.server.network.ServerGamePacketListenerImpl connection = player.connection;
|
|
+ if (connection != null) {
|
|
+ connection.connection.disableAutomaticFlush();
|
|
+ disabledFlushes.add(connection.connection);
|
|
+ }
|
|
+ }
|
|
+ try { // Paper end - controlled flush for entity tracker packets
|
|
this.chunkMap.tick();
|
|
+ // Paper start - controlled flush for entity tracker packets
|
|
+ } finally {
|
|
+ for (net.minecraft.network.Connection networkManager : disabledFlushes) {
|
|
+ networkManager.enableAutomaticFlush();
|
|
+ }
|
|
+ }
|
|
+ // Paper end - controlled flush for entity tracker packets
|
|
}
|
|
}
|
|
|