mirror of
https://github.com/PaperMC/Paper.git
synced 2024-10-24 01:46:42 +02:00
c5a10665b8
Spigot still maintains some partial implementation of "tick skipping", a practice in which the MinecraftServer.currentTick field is updated not by an increment of one per actual tick, but instead set to System.currentTimeMillis() / 50. This behaviour means that the tracked tick may "skip" a tick value in case a previous tick took more than the expected 50ms. To compensate for this in important paths, spigot/craftbukkit implements "wall-time". Instead of incrementing/decrementing ticks on block entities/entities by one for each call to their tick() method, they instead increment/decrement important values, like an ItemEntity's age or pickupDelay, by the difference of `currentTick - lastTick`, where `lastTick` is the value of `currentTick` during the last tick() call. These "fixes" however do not play nicely with minecraft's simulation distance as entities/block entities implementing the above behaviour would "catch up" their values when moving from a non-ticking chunk to a ticking one as their `lastTick` value remains stuck on the last tick in a ticking chunk and hence lead to a large "catch up" once ticked again. Paper completely removes the "tick skipping" behaviour (See patch "Further-improve-server-tick-loop"), making the above precautions completely unnecessary, which also rids paper of the previous described incompatibility with non-ticking chunks.
119 lines
6.9 KiB
Diff
119 lines
6.9 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: 2277 <38501234+2277@users.noreply.github.com>
|
|
Date: Tue, 31 Mar 2020 10:33:55 +0100
|
|
Subject: [PATCH] Move player to spawn point if spawn in unloaded world
|
|
|
|
If the playerdata contains an invalid world (missing, unloaded, invalid,
|
|
etc.), spawn the player at the spawn point of the main world.
|
|
|
|
Co-authored-by: Wyatt Childers <wchilders@nearce.com>
|
|
Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/players/PlayerList.java b/src/main/java/net/minecraft/server/players/PlayerList.java
|
|
index 5390ce62ec8afd24d2e028ea04d2ef3029a125f9..6f587c4bb4704d93552ba61335d87b1852fc169c 100644
|
|
--- a/src/main/java/net/minecraft/server/players/PlayerList.java
|
|
+++ b/src/main/java/net/minecraft/server/players/PlayerList.java
|
|
@@ -197,6 +197,7 @@ public abstract class PlayerList {
|
|
}
|
|
|
|
Optional<CompoundTag> optional = this.load(player); // CraftBukkit - decompile error
|
|
+ ResourceKey<Level> resourcekey = null; // Paper
|
|
// CraftBukkit start - Better rename detection
|
|
if (optional.isPresent()) {
|
|
CompoundTag nbttagcompound = optional.get();
|
|
@@ -206,19 +207,47 @@ public abstract class PlayerList {
|
|
}
|
|
}
|
|
// CraftBukkit end
|
|
- ResourceKey<Level> resourcekey = (ResourceKey) optional.flatMap((nbttagcompound) -> {
|
|
+ // Paper start - move logic in Entity to here, to use bukkit supplied world UUID & reset to main world spawn if no valid world is found
|
|
+ boolean[] invalidPlayerWorld = {false};
|
|
+ bukkitData: if (optional.isPresent()) {
|
|
+ // The main way for bukkit worlds to store the world is the world UUID despite mojang adding custom worlds
|
|
+ final org.bukkit.World bWorld;
|
|
+ if (optional.get().contains("WorldUUIDMost") && optional.get().contains("WorldUUIDLeast")) {
|
|
+ bWorld = org.bukkit.Bukkit.getServer().getWorld(new UUID(optional.get().getLong("WorldUUIDMost"), optional.get().getLong("WorldUUIDLeast")));
|
|
+ } else if (optional.get().contains("world", net.minecraft.nbt.Tag.TAG_STRING)) { // Paper - legacy bukkit world name
|
|
+ bWorld = org.bukkit.Bukkit.getServer().getWorld(optional.get().getString("world"));
|
|
+ } else {
|
|
+ break bukkitData; // if neither of the bukkit data points exist, proceed to the vanilla migration section
|
|
+ }
|
|
+ if (bWorld != null) {
|
|
+ resourcekey = ((CraftWorld) bWorld).getHandle().dimension();
|
|
+ } else {
|
|
+ resourcekey = Level.OVERWORLD;
|
|
+ invalidPlayerWorld[0] = true;
|
|
+ }
|
|
+ }
|
|
+ if (resourcekey == null) { // only run the vanilla logic if we haven't found a world from the bukkit data
|
|
+ // Below is the vanilla way of getting the dimension, this is for migration from vanilla servers
|
|
+ resourcekey = optional.flatMap((nbttagcompound) -> {
|
|
+ // Paper end
|
|
DataResult<ResourceKey<Level>> dataresult = DimensionType.parseLegacy(new Dynamic(NbtOps.INSTANCE, nbttagcompound.get("Dimension"))); // CraftBukkit - decompile error
|
|
Logger logger = PlayerList.LOGGER;
|
|
|
|
Objects.requireNonNull(logger);
|
|
- return dataresult.resultOrPartial(logger::error);
|
|
- }).orElse(player.serverLevel().dimension()); // CraftBukkit - SPIGOT-7507: If no dimension, fall back to existing dimension loaded from "WorldUUID", which in turn defaults to World.OVERWORLD
|
|
+ // Paper start - reset to main world spawn if no valid world is found
|
|
+ final Optional<ResourceKey<Level>> result = dataresult.resultOrPartial(logger::error);
|
|
+ invalidPlayerWorld[0] = result.isEmpty();
|
|
+ return result;
|
|
+ }).orElse(Level.OVERWORLD); // Paper - revert to vanilla default main world, this isn't an "invalid world" since no player data existed
|
|
+ }
|
|
+ // Paper end
|
|
ServerLevel worldserver = this.server.getLevel(resourcekey);
|
|
ServerLevel worldserver1;
|
|
|
|
if (worldserver == null) {
|
|
PlayerList.LOGGER.warn("Unknown respawn dimension {}, defaulting to overworld", resourcekey);
|
|
worldserver1 = this.server.overworld();
|
|
+ invalidPlayerWorld[0] = true; // Paper - reset to main world if no world with parsed value is found
|
|
} else {
|
|
worldserver1 = worldserver;
|
|
}
|
|
@@ -226,6 +255,10 @@ public abstract class PlayerList {
|
|
// Paper start - Entity#getEntitySpawnReason
|
|
if (optional.isEmpty()) {
|
|
player.spawnReason = org.bukkit.event.entity.CreatureSpawnEvent.SpawnReason.DEFAULT; // set Player SpawnReason to DEFAULT on first login
|
|
+ // Paper start - reset to main world spawn if first spawn or invalid world
|
|
+ }
|
|
+ if (optional.isEmpty() || invalidPlayerWorld[0]) {
|
|
+ // Paper end - reset to main world spawn if first spawn or invalid world
|
|
player.moveTo(player.adjustSpawnLocation(worldserver1, worldserver1.getSharedSpawnPos()).getBottomCenter(), 0.0F, 0.0F);
|
|
}
|
|
// Paper end - Entity#getEntitySpawnReason
|
|
diff --git a/src/main/java/net/minecraft/world/entity/Entity.java b/src/main/java/net/minecraft/world/entity/Entity.java
|
|
index 94242c19740ae6ab2c86e3949bab6cee631b938f..d80fd4e2f41583f83c9527ccf4ce80afe851276a 100644
|
|
--- a/src/main/java/net/minecraft/world/entity/Entity.java
|
|
+++ b/src/main/java/net/minecraft/world/entity/Entity.java
|
|
@@ -2385,27 +2385,8 @@ public abstract class Entity implements SyncedDataHolder, Nameable, EntityAccess
|
|
}
|
|
// CraftBukkit end
|
|
|
|
- // CraftBukkit start - Reset world
|
|
- if (this instanceof ServerPlayer) {
|
|
- Server server = Bukkit.getServer();
|
|
- org.bukkit.World bworld = null;
|
|
-
|
|
- // TODO: Remove World related checks, replaced with WorldUID
|
|
- String worldName = nbt.getString("world");
|
|
-
|
|
- if (nbt.contains("WorldUUIDMost") && nbt.contains("WorldUUIDLeast")) {
|
|
- UUID uid = new UUID(nbt.getLong("WorldUUIDMost"), nbt.getLong("WorldUUIDLeast"));
|
|
- bworld = server.getWorld(uid);
|
|
- } else {
|
|
- bworld = server.getWorld(worldName);
|
|
- }
|
|
-
|
|
- if (bworld == null) {
|
|
- bworld = ((org.bukkit.craftbukkit.CraftServer) server).getServer().getLevel(Level.OVERWORLD).getWorld();
|
|
- }
|
|
-
|
|
- ((ServerPlayer) this).setLevel(bworld == null ? null : ((CraftWorld) bworld).getHandle());
|
|
- }
|
|
+ // CraftBukkit start
|
|
+ // Paper - move world parsing/loading to PlayerList#placeNewPlayer
|
|
this.getBukkitEntity().readBukkitValues(nbt);
|
|
if (nbt.contains("Bukkit.invisible")) {
|
|
boolean bukkitInvisible = nbt.getBoolean("Bukkit.invisible");
|