mirror of
https://github.com/PaperMC/Paper.git
synced 2024-12-02 13:07:06 +01:00
2873869bb1
Signs no longer have a specific isEdiable state, the entire API in this regard needs updating/deprecation. The boolean field is completely gone, replaced by a uuid (which will need a new setEditingPlayer(UUID) method on the Sign interface), and the current upstream implementation of setEdiable simply flips the is_waxed state. This patch is hence not needed as it neither allows editing (which will be redone in a later patch) nor is required to copy the is_waxed boolean flag as it lives in the signs compound tag and is covered by applyTo.
51 lines
2.4 KiB
Diff
51 lines
2.4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jake <jake.m.potrebic@gmail.com>
|
|
Date: Tue, 30 Nov 2021 12:01:56 -0800
|
|
Subject: [PATCH] Fix removing recipes from RecipeIterator
|
|
|
|
== AT ==
|
|
public net.minecraft.world.item.crafting.RecipeManager byName
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/RecipeIterator.java b/src/main/java/org/bukkit/craftbukkit/inventory/RecipeIterator.java
|
|
index 24f336c89b548c5ba2a95372db0d7c83b5c4ec47..91895c639c33a1cafd2a35bab7b5fd83e558468d 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/inventory/RecipeIterator.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/inventory/RecipeIterator.java
|
|
@@ -11,6 +11,7 @@ import org.bukkit.inventory.Recipe;
|
|
public class RecipeIterator implements Iterator<Recipe> {
|
|
private final Iterator<Map.Entry<RecipeType<?>, Object2ObjectLinkedOpenHashMap<ResourceLocation, net.minecraft.world.item.crafting.Recipe<?>>>> recipes;
|
|
private Iterator<net.minecraft.world.item.crafting.Recipe<?>> current;
|
|
+ private Recipe currentRecipe; // Paper - fix removing recipes
|
|
|
|
public RecipeIterator() {
|
|
this.recipes = MinecraftServer.getServer().getRecipeManager().recipes.entrySet().iterator();
|
|
@@ -34,10 +35,16 @@ public class RecipeIterator implements Iterator<Recipe> {
|
|
public Recipe next() {
|
|
if (this.current == null || !this.current.hasNext()) {
|
|
this.current = this.recipes.next().getValue().values().iterator();
|
|
- return this.next();
|
|
+ // Paper start - fix removing recipes
|
|
+ this.currentRecipe = this.next();
|
|
+ return this.currentRecipe;
|
|
+ // Paper end
|
|
}
|
|
|
|
- return this.current.next().toBukkitRecipe();
|
|
+ // Paper start - fix removing recipes
|
|
+ this.currentRecipe = this.current.next().toBukkitRecipe();
|
|
+ return this.currentRecipe;
|
|
+ // Paper end
|
|
}
|
|
|
|
@Override
|
|
@@ -46,6 +53,11 @@ public class RecipeIterator implements Iterator<Recipe> {
|
|
throw new IllegalStateException("next() not yet called");
|
|
}
|
|
|
|
+ // Paper start - fix removing recipes
|
|
+ if (this.currentRecipe instanceof org.bukkit.Keyed keyed) {
|
|
+ MinecraftServer.getServer().getRecipeManager().byName.remove(org.bukkit.craftbukkit.util.CraftNamespacedKey.toMinecraft(keyed.getKey()));
|
|
+ }
|
|
+ // Paper end
|
|
this.current.remove();
|
|
}
|
|
}
|