mirror of
https://github.com/PaperMC/Paper.git
synced 2024-12-20 21:45:03 +01:00
c5a10665b8
Spigot still maintains some partial implementation of "tick skipping", a practice in which the MinecraftServer.currentTick field is updated not by an increment of one per actual tick, but instead set to System.currentTimeMillis() / 50. This behaviour means that the tracked tick may "skip" a tick value in case a previous tick took more than the expected 50ms. To compensate for this in important paths, spigot/craftbukkit implements "wall-time". Instead of incrementing/decrementing ticks on block entities/entities by one for each call to their tick() method, they instead increment/decrement important values, like an ItemEntity's age or pickupDelay, by the difference of `currentTick - lastTick`, where `lastTick` is the value of `currentTick` during the last tick() call. These "fixes" however do not play nicely with minecraft's simulation distance as entities/block entities implementing the above behaviour would "catch up" their values when moving from a non-ticking chunk to a ticking one as their `lastTick` value remains stuck on the last tick in a ticking chunk and hence lead to a large "catch up" once ticked again. Paper completely removes the "tick skipping" behaviour (See patch "Further-improve-server-tick-loop"), making the above precautions completely unnecessary, which also rids paper of the previous described incompatibility with non-ticking chunks.
32 lines
1.9 KiB
Diff
32 lines
1.9 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Aikar <aikar@aikar.co>
|
|
Date: Thu, 3 Nov 2016 20:28:12 -0400
|
|
Subject: [PATCH] Don't load Chunks from Hoppers and other things
|
|
|
|
Hoppers call this to I guess "get the primary side" of a double sided chest.
|
|
|
|
If the double sided chest crosses chunk lines, it causes the chunk to load.
|
|
This will end up causing sync chunk loads, which will unload with Chunk GC,
|
|
only to be reloaded again the next tick.
|
|
|
|
This of course is undesirable, so just return the loaded side as "primary"
|
|
and treat it as a single chest if the other sides are unloaded
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/level/block/DoubleBlockCombiner.java b/src/main/java/net/minecraft/world/level/block/DoubleBlockCombiner.java
|
|
index 963092cd5a4e756ad6a471379a81d8996cc2b091..20c9921339ec6b5127fbadcedc19577f3906074d 100644
|
|
--- a/src/main/java/net/minecraft/world/level/block/DoubleBlockCombiner.java
|
|
+++ b/src/main/java/net/minecraft/world/level/block/DoubleBlockCombiner.java
|
|
@@ -34,7 +34,12 @@ public class DoubleBlockCombiner {
|
|
return new DoubleBlockCombiner.NeighborCombineResult.Single<>(blockEntity);
|
|
} else {
|
|
BlockPos blockPos = pos.relative(directionMapper.apply(state));
|
|
- BlockState blockState = world.getBlockState(blockPos);
|
|
+ // Paper start - Don't load Chunks from Hoppers and other things
|
|
+ BlockState blockState = world.getBlockStateIfLoaded(blockPos);
|
|
+ if (blockState == null) {
|
|
+ return new DoubleBlockCombiner.NeighborCombineResult.Single<>(blockEntity);
|
|
+ }
|
|
+ // Paper end - Don't load Chunks from Hoppers and other things
|
|
if (blockState.is(state.getBlock())) {
|
|
DoubleBlockCombiner.BlockType blockType2 = typeMapper.apply(blockState);
|
|
if (blockType2 != DoubleBlockCombiner.BlockType.SINGLE
|