mirror of
https://github.com/PaperMC/Paper.git
synced 2024-12-19 21:22:02 +01:00
c5a10665b8
Spigot still maintains some partial implementation of "tick skipping", a practice in which the MinecraftServer.currentTick field is updated not by an increment of one per actual tick, but instead set to System.currentTimeMillis() / 50. This behaviour means that the tracked tick may "skip" a tick value in case a previous tick took more than the expected 50ms. To compensate for this in important paths, spigot/craftbukkit implements "wall-time". Instead of incrementing/decrementing ticks on block entities/entities by one for each call to their tick() method, they instead increment/decrement important values, like an ItemEntity's age or pickupDelay, by the difference of `currentTick - lastTick`, where `lastTick` is the value of `currentTick` during the last tick() call. These "fixes" however do not play nicely with minecraft's simulation distance as entities/block entities implementing the above behaviour would "catch up" their values when moving from a non-ticking chunk to a ticking one as their `lastTick` value remains stuck on the last tick in a ticking chunk and hence lead to a large "catch up" once ticked again. Paper completely removes the "tick skipping" behaviour (See patch "Further-improve-server-tick-loop"), making the above precautions completely unnecessary, which also rids paper of the previous described incompatibility with non-ticking chunks.
33 lines
1.7 KiB
Diff
33 lines
1.7 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Oliwier Miodun <naczs@blueflow.pl>
|
|
Date: Mon, 10 Jul 2023 17:59:42 +0200
|
|
Subject: [PATCH] SculkCatalyst bloom API
|
|
|
|
== AT ==
|
|
public net.minecraft.world.level.block.entity.SculkCatalystBlockEntity$CatalystListener bloom(Lnet/minecraft/server/level/ServerLevel;Lnet/minecraft/core/BlockPos;Lnet/minecraft/world/level/block/state/BlockState;Lnet/minecraft/util/RandomSource;)V
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/block/CraftSculkCatalyst.java b/src/main/java/org/bukkit/craftbukkit/block/CraftSculkCatalyst.java
|
|
index 5211dc80f449cec09f992a42667e869ab9e7115e..407d5b1d87d14e18878f0ebf1d676a7f49e7cfaf 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/block/CraftSculkCatalyst.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/block/CraftSculkCatalyst.java
|
|
@@ -38,4 +38,20 @@ public class CraftSculkCatalyst extends CraftBlockEntityState<SculkCatalystBlock
|
|
public CraftSculkCatalyst copy(Location location) {
|
|
return new CraftSculkCatalyst(this, location);
|
|
}
|
|
+
|
|
+ // Paper start - SculkCatalyst bloom API
|
|
+ @Override
|
|
+ public void bloom(@org.jetbrains.annotations.NotNull io.papermc.paper.math.Position position, int charge) {
|
|
+ com.google.common.base.Preconditions.checkNotNull(position);
|
|
+ requirePlaced();
|
|
+
|
|
+ getTileEntity().getListener().bloom(
|
|
+ world.getHandle(),
|
|
+ getTileEntity().getBlockPos(),
|
|
+ getTileEntity().getBlockState(),
|
|
+ world.getHandle().getRandom()
|
|
+ );
|
|
+ getTileEntity().getListener().getSculkSpreader().addCursors(io.papermc.paper.util.MCUtil.toBlockPos(position), charge);
|
|
+ }
|
|
+ // Paper end
|
|
}
|