mirror of
https://github.com/PaperMC/Paper.git
synced 2024-12-01 12:41:50 +01:00
2641c02193
Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 69fa4695 Add some missing deprecation annotations f850da2e Update Maven plugins/versions 8d8400db Use regular compiler seeing as ECJ doesn't support Java 21 JRE c29e1688 Revert "BUILDTOOLS-676: Downgrade Maven compiler version" 07bce714 SPIGOT-7355: More field renames and fixes 6a8ea764 Fix bad merge in penultimate commit 50a7920c Fix imports in previous commit 83640dd1 PR-995: Add required feature to MinecraftExperimental for easy lookups fc1f96cf BUILDTOOLS-676: Downgrade Maven compiler version CraftBukkit Changes: 90f1059ba Fix item placement 661afb43c SPIGOT-7633: Clearer error message for missing particle data 807b465b3 SPIGOT-7634: Armadillo updates infrequently 590cf09a8 Fix unit tests always seeing Mojang server as unavailable 7c7ac5eb2 SPIGOT-7636: Fix clearing ItemMeta 4a72905cf SPIGOT-7635: Fix Player#transfer and cookie methods ebb50e136 Fix incorrect Vault implementation b33fed8b7 Update Maven plugins/versions 6f00f0608 SPIGOT-7632: Control middle clicking chest does not copy contents db821f405 Use regular compiler seeing as ECJ doesn't support Java 21 JRE 8a2976737 Revert "BUILDTOOLS-676: Downgrade Maven compiler version" 0297f87bb SPIGOT-7355: More field renames and fixes 2d03bdf6a SPIGOT-7629: Fix loading banner patterns e77951fac Fix equality of deserialized display names c66f3e4fd SPIGOT-7631: Fix deserialisation of BlockStateMeta 9c2c7be8d SPIGOT-7630: Fix crash saving unticked leashed entities 8c1e7c841 PR-1384: Disable certain PlayerProfile tests, if Mojang's services or internet are not available ced93d572 SPIGOT-7626: sendSignChange() has no effect c77362cae SPIGOT-7625: ItemStack with lore cannot be serialized in 1.20.5 ff2004387 SPIGOT-7620: Fix server crash when hoppers transfer items to double chests 8b4abeb03 BUILDTOOLS-676: Downgrade Maven compiler version
54 lines
2.4 KiB
Diff
54 lines
2.4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Owen1212055 <23108066+Owen1212055@users.noreply.github.com>
|
|
Date: Thu, 29 Feb 2024 17:54:26 -0500
|
|
Subject: [PATCH] Deprecate ItemStack#setType
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/inventory/ItemStack.java b/src/main/java/org/bukkit/inventory/ItemStack.java
|
|
index b04e7b9c3f631c0bb7734b809a58dbb988414fbb..df2d5ad5ff1bcb1488a94edde9cc4d53cacdd91d 100644
|
|
--- a/src/main/java/org/bukkit/inventory/ItemStack.java
|
|
+++ b/src/main/java/org/bukkit/inventory/ItemStack.java
|
|
@@ -134,8 +134,18 @@ public class ItemStack implements Cloneable, ConfigurationSerializable, Translat
|
|
* {@link Material#isItem()} returns false.</b>
|
|
*
|
|
* @param type New type to set the items in this stack to
|
|
+ * @deprecated <b>Setting the material type of ItemStacks is no longer supported.</b>
|
|
+ * <p>
|
|
+ * This method is deprecated due to potential illegal behavior that may occur
|
|
+ * during the context of which this ItemStack is being used, allowing for certain item validation to be bypassed.
|
|
+ * It is recommended to instead create a new ItemStack object with the desired
|
|
+ * Material type, and if possible, set it in the appropriate context.
|
|
+ *
|
|
+ * Using this method in ItemStacks passed in events will result in undefined behavior.
|
|
+ * @see ItemStack#withType(Material)
|
|
*/
|
|
@Utility
|
|
+ @Deprecated // Paper
|
|
public void setType(@NotNull Material type) {
|
|
Preconditions.checkArgument(type != null, "Material cannot be null");
|
|
this.type = type;
|
|
@@ -148,6 +158,24 @@ public class ItemStack implements Cloneable, ConfigurationSerializable, Translat
|
|
this.data = null;
|
|
}
|
|
}
|
|
+ // Paper start
|
|
+ /**
|
|
+ * Creates a new ItemStack with the specified Material type, where the item count and item meta is preserved.
|
|
+ *
|
|
+ * @param type The Material type of the new ItemStack.
|
|
+ * @return A new ItemStack instance with the specified Material type.
|
|
+ */
|
|
+ @NotNull
|
|
+ @org.jetbrains.annotations.Contract(value = "_ -> new", pure = true)
|
|
+ public ItemStack withType(@NotNull Material type) {
|
|
+ ItemStack itemStack = new ItemStack(type, this.amount);
|
|
+ if (this.hasItemMeta()) {
|
|
+ itemStack.setItemMeta(this.getItemMeta());
|
|
+ }
|
|
+
|
|
+ return itemStack;
|
|
+ }
|
|
+ // Paper end
|
|
|
|
/**
|
|
* Gets the amount of items in this stack
|