mirror of
https://github.com/PaperMC/Paper.git
synced 2024-12-28 15:30:19 +01:00
c5a10665b8
Spigot still maintains some partial implementation of "tick skipping", a practice in which the MinecraftServer.currentTick field is updated not by an increment of one per actual tick, but instead set to System.currentTimeMillis() / 50. This behaviour means that the tracked tick may "skip" a tick value in case a previous tick took more than the expected 50ms. To compensate for this in important paths, spigot/craftbukkit implements "wall-time". Instead of incrementing/decrementing ticks on block entities/entities by one for each call to their tick() method, they instead increment/decrement important values, like an ItemEntity's age or pickupDelay, by the difference of `currentTick - lastTick`, where `lastTick` is the value of `currentTick` during the last tick() call. These "fixes" however do not play nicely with minecraft's simulation distance as entities/block entities implementing the above behaviour would "catch up" their values when moving from a non-ticking chunk to a ticking one as their `lastTick` value remains stuck on the last tick in a ticking chunk and hence lead to a large "catch up" once ticked again. Paper completely removes the "tick skipping" behaviour (See patch "Further-improve-server-tick-loop"), making the above precautions completely unnecessary, which also rids paper of the previous described incompatibility with non-ticking chunks.
35 lines
1.5 KiB
Diff
35 lines
1.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Owen1212055 <23108066+Owen1212055@users.noreply.github.com>
|
|
Date: Tue, 26 Mar 2024 21:42:23 -0400
|
|
Subject: [PATCH] Deprecate ItemStack#setType
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java b/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java
|
|
index a1a32a77bda0560a7b7f30a5d1c1837ee96997d3..9be7859ccb5283b2040ba68d72d6dbdafb4d6835 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java
|
|
@@ -417,4 +417,24 @@ public final class CraftItemStack extends ItemStack {
|
|
static boolean hasItemMeta(net.minecraft.world.item.ItemStack item) {
|
|
return !(item == null || item.getComponentsPatch().isEmpty());
|
|
}
|
|
+ // Paper start - with type
|
|
+ @Override
|
|
+ public ItemStack withType(final Material type) {
|
|
+ if (type == Material.AIR) {
|
|
+ return CraftItemStack.asCraftMirror(null);
|
|
+ }
|
|
+
|
|
+ final net.minecraft.world.item.ItemStack copy = new net.minecraft.world.item.ItemStack(
|
|
+ CraftItemType.bukkitToMinecraft(type), this.getAmount()
|
|
+ );
|
|
+
|
|
+ if (this.handle != null) {
|
|
+ copy.applyComponents(this.handle.getComponentsPatch());
|
|
+ }
|
|
+
|
|
+ final CraftItemStack mirrored = CraftItemStack.asCraftMirror(copy);
|
|
+ mirrored.setItemMeta(mirrored.getItemMeta());
|
|
+ return mirrored;
|
|
+ }
|
|
+ // Paper end
|
|
}
|