mirror of
https://github.com/PaperMC/Paper.git
synced 2025-01-23 08:46:44 +01:00
f6519a79fe
This is specifically aimed at fixing #471 Using a ConcurrentHashMap because thread safety The performance benefit of Map over ConcurrentMap is negligabe at best in this scenaio, as most operations will be get and not add or remove Even without considering the use-case the benefits are still negligable Original ideas for the system included an expiration policy and/or handler The simpler solution was to use a computeIfPresent in the get method This will simultaneously have an O(1) lookup time and automatically expire any values Since the get method (nor other similar methods) don't seem to have a critical need to flush the map to disk at any of these points further processing is simply wasteful Meaning the original function expired values unrelated to the current value without actually having any explicit need to The h method was heavily modified to be much more efficient in its processing Also instead of being called on every get, it's now called just before a save This will eliminate stale values being flushed to disk Modified isEmpty to use the isEmpty() method instead of the slightly confusing size() < 1 The point of this is readability, but does have a side-benefit of a small microptimization |
||
|---|---|---|
| .. | ||
| bossevents | ||
| commands | ||
| dedicated | ||
| gui | ||
| level | ||
| network | ||
| packs | ||
| players | ||
| rcon | ||
| Bootstrap.java.patch | ||
| Main.java.patch | ||
| MinecraftServer.java.patch | ||
| PlayerAdvancements.java.patch | ||
| ServerAdvancementManager.java.patch | ||
| ServerFunctionManager.java.patch | ||
| ServerScoreboard.java.patch | ||
| ServerTickRateManager.java.patch | ||
| Services.java.patch | ||