mirror of
https://activitypub.software/TransFem-org/Sharkey.git
synced 2024-12-14 18:25:45 +01:00
31e82fc29a
* kill any on utils:api
* kill any on timeline test
* use optional chain to kill TS2532 on timeline test
変更前: 該当ノートが見つからなければundefinedに対するプロパティアクセスとしてテストがクラッシュ
変更後: 該当ノートが見つからなければoptional chainがundefinedとして評価されるが、strictEqualの右辺がnon-nullableなためアサーションに失敗しテストがクラッシュ
* kill `as any` for ApMfmService
* kill argument any for api-visibility
* kill argument any across a few tests
* do not return value that has yielded from `await`-ing `Promise<void>`
* force cast
* runtime non-null assertion to coerce
* rewrite `assert.notEqual(expr, null)` to `assert.ok(expr)`
こうすることでassertion type扱いになり、non-nullableになる
* change return type of `failedApiCall` to `void`
戻り値がどこにも使われていない
* split bindings for exports.ts
型が合わなくて文句を言ってくるので適切に分割
* runtime non-null assertion
* runtime non-null assertion
* 何故かうまく行かないので、とりあえずXORしてみる
* Revert "何故かうまく行かないので、とりあえずXORしてみる"
This reverts commit 48cf32c930924840d0892af92d71b9437acb5844.
* castAsErrorで安全ではないキャストを隠蔽
* 型アサーションの追加
* 型アサーションの追加
* 型アサーションの追加
* voidで値を返さない
* castAsError
* assert.ok => kill nullability
* もはや明示的な型の指定は必要ない
* castAsError
* castAsError
* 型アサーションの追加
* nullableを一旦抑止
* 変数を分離して型エラーを排除
* 不要なプロパティを削除する処理を隠蔽してanyを排除
* Repository type
* simple type
* assert.ok => kill nullability
* revert `as any` drop
reverts fe95c05b3f53266108128680d9358a3796844232 partialy
* test: fix invalid assertion
partially revert b99b7b5392d9d20c81dfee1346ba8b33ff9e1fbb
* test: 52d8a54fc7
により型が合うようになった部分の`as any`を除去
* format
* test: apply https://github.com/misskey-dev/misskey/pull/14054#discussion_r1672369526 (part 1)
* test: use non-null assertion to suppress too many error
* Update packages/backend/test/utils.ts
Co-authored-by: anatawa12 <anatawa12@icloud.com>
---------
Co-authored-by: anatawa12 <anatawa12@icloud.com>
199 lines
5.4 KiB
TypeScript
199 lines
5.4 KiB
TypeScript
/*
|
|
* SPDX-FileCopyrightText: syuilo and misskey-project
|
|
* SPDX-License-Identifier: AGPL-3.0-only
|
|
*/
|
|
|
|
process.env.NODE_ENV = 'test';
|
|
|
|
import * as assert from 'assert';
|
|
import { api, port, post, signup, startJobQueue } from '../utils.js';
|
|
import type { INestApplicationContext } from '@nestjs/common';
|
|
import type * as misskey from 'misskey-js';
|
|
|
|
describe('export-clips', () => {
|
|
let queue: INestApplicationContext;
|
|
let alice: misskey.entities.SignupResponse;
|
|
let bob: misskey.entities.SignupResponse;
|
|
|
|
// XXX: Any better way to get the result?
|
|
async function pollFirstDriveFile() {
|
|
while (true) {
|
|
const files = (await api('drive/files', {}, alice)).body;
|
|
if (!files.length) {
|
|
await new Promise(r => setTimeout(r, 100));
|
|
continue;
|
|
}
|
|
if (files.length > 1) {
|
|
throw new Error('Too many files?');
|
|
}
|
|
const file = (await api('drive/files/show', { fileId: files[0].id }, alice)).body;
|
|
const res = await fetch(new URL(new URL(file.url).pathname, `http://127.0.0.1:${port}`));
|
|
return await res.json();
|
|
}
|
|
}
|
|
|
|
beforeAll(async () => {
|
|
queue = await startJobQueue();
|
|
alice = await signup({ username: 'alice' });
|
|
bob = await signup({ username: 'bob' });
|
|
}, 1000 * 60 * 2);
|
|
|
|
afterAll(async () => {
|
|
await queue.close();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
// Clean all clips and files of alice
|
|
const clips = (await api('clips/list', {}, alice)).body;
|
|
for (const clip of clips) {
|
|
const res = await api('clips/delete', { clipId: clip.id }, alice);
|
|
if (res.status !== 204) {
|
|
throw new Error('Failed to delete clip');
|
|
}
|
|
}
|
|
const files = (await api('drive/files', {}, alice)).body;
|
|
for (const file of files) {
|
|
const res = await api('drive/files/delete', { fileId: file.id }, alice);
|
|
if (res.status !== 204) {
|
|
throw new Error('Failed to delete file');
|
|
}
|
|
}
|
|
});
|
|
|
|
test('basic export', async () => {
|
|
const res1 = await api('clips/create', {
|
|
name: 'foo',
|
|
description: 'bar',
|
|
}, alice);
|
|
assert.strictEqual(res1.status, 200);
|
|
|
|
const res2 = await api('i/export-clips', {}, alice);
|
|
assert.strictEqual(res2.status, 204);
|
|
|
|
const exported = await pollFirstDriveFile();
|
|
assert.strictEqual(exported[0].name, 'foo');
|
|
assert.strictEqual(exported[0].description, 'bar');
|
|
assert.strictEqual(exported[0].clipNotes.length, 0);
|
|
});
|
|
|
|
test('export with notes', async () => {
|
|
const res = await api('clips/create', {
|
|
name: 'foo',
|
|
description: 'bar',
|
|
}, alice);
|
|
assert.strictEqual(res.status, 200);
|
|
const clip = res.body;
|
|
|
|
const note1 = await post(alice, {
|
|
text: 'baz1',
|
|
});
|
|
|
|
const note2 = await post(alice, {
|
|
text: 'baz2',
|
|
poll: {
|
|
choices: ['sakura', 'izumi', 'ako'],
|
|
},
|
|
});
|
|
|
|
for (const note of [note1, note2]) {
|
|
const res2 = await api('clips/add-note', {
|
|
clipId: clip.id,
|
|
noteId: note.id,
|
|
}, alice);
|
|
assert.strictEqual(res2.status, 204);
|
|
}
|
|
|
|
const res3 = await api('i/export-clips', {}, alice);
|
|
assert.strictEqual(res3.status, 204);
|
|
|
|
const exported = await pollFirstDriveFile();
|
|
assert.strictEqual(exported[0].name, 'foo');
|
|
assert.strictEqual(exported[0].description, 'bar');
|
|
assert.strictEqual(exported[0].clipNotes.length, 2);
|
|
assert.strictEqual(exported[0].clipNotes[0].note.text, 'baz1');
|
|
assert.strictEqual(exported[0].clipNotes[1].note.text, 'baz2');
|
|
assert.deepStrictEqual(exported[0].clipNotes[1].note.poll.choices[0], 'sakura');
|
|
});
|
|
|
|
test('multiple clips', async () => {
|
|
const res1 = await api('clips/create', {
|
|
name: 'kawaii',
|
|
description: 'kawaii',
|
|
}, alice);
|
|
assert.strictEqual(res1.status, 200);
|
|
const clip1 = res1.body;
|
|
|
|
const res2 = await api('clips/create', {
|
|
name: 'yuri',
|
|
description: 'yuri',
|
|
}, alice);
|
|
assert.strictEqual(res2.status, 200);
|
|
const clip2 = res2.body;
|
|
|
|
const note1 = await post(alice, {
|
|
text: 'baz1',
|
|
});
|
|
|
|
const note2 = await post(alice, {
|
|
text: 'baz2',
|
|
});
|
|
|
|
{
|
|
const res = await api('clips/add-note', {
|
|
clipId: clip1.id,
|
|
noteId: note1.id,
|
|
}, alice);
|
|
assert.strictEqual(res.status, 204);
|
|
}
|
|
|
|
{
|
|
const res = await api('clips/add-note', {
|
|
clipId: clip2.id,
|
|
noteId: note2.id,
|
|
}, alice);
|
|
assert.strictEqual(res.status, 204);
|
|
}
|
|
|
|
{
|
|
const res = await api('i/export-clips', {}, alice);
|
|
assert.strictEqual(res.status, 204);
|
|
}
|
|
|
|
const exported = await pollFirstDriveFile();
|
|
assert.strictEqual(exported[0].name, 'kawaii');
|
|
assert.strictEqual(exported[0].clipNotes.length, 1);
|
|
assert.strictEqual(exported[0].clipNotes[0].note.text, 'baz1');
|
|
assert.strictEqual(exported[1].name, 'yuri');
|
|
assert.strictEqual(exported[1].clipNotes.length, 1);
|
|
assert.strictEqual(exported[1].clipNotes[0].note.text, 'baz2');
|
|
});
|
|
|
|
test('Clipping other user\'s note', async () => {
|
|
const res = await api('clips/create', {
|
|
name: 'kawaii',
|
|
description: 'kawaii',
|
|
}, alice);
|
|
assert.strictEqual(res.status, 200);
|
|
const clip = res.body;
|
|
|
|
const note = await post(bob, {
|
|
text: 'baz',
|
|
visibility: 'followers',
|
|
});
|
|
|
|
const res2 = await api('clips/add-note', {
|
|
clipId: clip.id,
|
|
noteId: note.id,
|
|
}, alice);
|
|
assert.strictEqual(res2.status, 204);
|
|
|
|
const res3 = await api('i/export-clips', {}, alice);
|
|
assert.strictEqual(res3.status, 204);
|
|
|
|
const exported = await pollFirstDriveFile();
|
|
assert.strictEqual(exported[0].name, 'kawaii');
|
|
assert.strictEqual(exported[0].clipNotes.length, 1);
|
|
assert.strictEqual(exported[0].clipNotes[0].note.text, 'baz');
|
|
assert.strictEqual(exported[0].clipNotes[0].note.user.username, 'bob');
|
|
});
|
|
});
|