Don't remove the Sec-WebSocket-Key header in WebSocketUpgrade (#1972)

This commit is contained in:
David Pedersen 2023-04-30 11:54:41 +02:00 committed by GitHub
parent ce7739e76d
commit b663072504
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions

View file

@ -52,6 +52,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
use `axum::serve(listener, service)` or hyper/hyper-util for more configuration options ([#1868]) use `axum::serve(listener, service)` or hyper/hyper-util for more configuration options ([#1868])
- **breaking:** Only inherit fallbacks for routers nested with `Router::nest`. - **breaking:** Only inherit fallbacks for routers nested with `Router::nest`.
Routers nested with `Router::nest_service` will no longer inherit fallbacks ([#1956]) Routers nested with `Router::nest_service` will no longer inherit fallbacks ([#1956])
- **fixed:** Don't remove the `Sec-WebSocket-Key` header in `WebSocketUpgrade` ([#1972])
[#1664]: https://github.com/tokio-rs/axum/pull/1664 [#1664]: https://github.com/tokio-rs/axum/pull/1664
[#1751]: https://github.com/tokio-rs/axum/pull/1751 [#1751]: https://github.com/tokio-rs/axum/pull/1751
@ -61,6 +62,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#1850]: https://github.com/tokio-rs/axum/pull/1850 [#1850]: https://github.com/tokio-rs/axum/pull/1850
[#1868]: https://github.com/tokio-rs/axum/pull/1868 [#1868]: https://github.com/tokio-rs/axum/pull/1868
[#1956]: https://github.com/tokio-rs/axum/pull/1956 [#1956]: https://github.com/tokio-rs/axum/pull/1956
[#1972]: https://github.com/tokio-rs/axum/pull/1972
# 0.6.17 (25. April, 2023) # 0.6.17 (25. April, 2023)

View file

@ -381,8 +381,9 @@ where
let sec_websocket_key = parts let sec_websocket_key = parts
.headers .headers
.remove(header::SEC_WEBSOCKET_KEY) .get(header::SEC_WEBSOCKET_KEY)
.ok_or(WebSocketKeyHeaderMissing)?; .ok_or(WebSocketKeyHeaderMissing)?
.clone();
let on_upgrade = parts let on_upgrade = parts
.extensions .extensions