mirror of
https://github.com/mastodon/mastodon.git
synced 2024-12-22 12:55:56 +01:00
Add the ability to ignore specific browser errors for a spec (#31436)
This commit is contained in:
parent
9194197de5
commit
4545b8d6cb
2 changed files with 19 additions and 3 deletions
|
@ -1,23 +1,36 @@
|
|||
# frozen_string_literal: true
|
||||
|
||||
module BrowserErrorsHelpers
|
||||
def ignore_js_error(error)
|
||||
@ignored_js_errors_for_spec << error
|
||||
end
|
||||
end
|
||||
|
||||
RSpec.configure do |config|
|
||||
config.include BrowserErrorsHelpers, :js, type: :system
|
||||
|
||||
config.before(:each, :js, type: :system) do
|
||||
@ignored_js_errors_for_spec = []
|
||||
end
|
||||
|
||||
config.after(:each, :js, type: :system) do
|
||||
# Classes of intermittent ignorable errors
|
||||
ignored_errors = [
|
||||
/Error while trying to use the following icon from the Manifest/, # https://github.com/mastodon/mastodon/pull/30793
|
||||
/Manifest: Line: 1, column: 1, Syntax error/, # Similar parsing/interruption issue as above
|
||||
]
|
||||
].concat(@ignored_js_errors_for_spec)
|
||||
|
||||
errors = page.driver.browser.logs.get(:browser).reject do |error|
|
||||
ignored_errors.any? { |pattern| pattern.match(error.message) }
|
||||
end
|
||||
|
||||
if errors.present?
|
||||
aggregate_failures 'javascript errrors' do
|
||||
aggregate_failures 'browser errrors' do
|
||||
errors.each do |error|
|
||||
expect(error.level).to_not eq('SEVERE'), error.message
|
||||
next unless error.level == 'WARNING'
|
||||
|
||||
warn 'WARN: javascript warning'
|
||||
warn 'WARN: browser warning'
|
||||
warn error.message
|
||||
end
|
||||
end
|
|
@ -24,6 +24,9 @@ describe 'Log out' do
|
|||
|
||||
describe 'Logging out from the JS app', :js, :streaming do
|
||||
it 'logs the user out' do
|
||||
# The frontend tries to load announcements after a short delay, but the session might be expired by then, and the browser will output an error.
|
||||
ignore_js_error(/Failed to load resource: the server responded with a status of 422/)
|
||||
|
||||
visit root_path
|
||||
|
||||
within '.navigation-bar' do
|
||||
|
|
Loading…
Reference in a new issue